Joey Hess <[EMAIL PROTECTED]> writes:

> Otavio Salvador wrote:
>> +# Set initial value to includes and excludes
>> +db_get base-installer/includes
>> +INCLUDES="$RET" || true
>> +
>> +db_get base-installer/excludes
>> +EXCLUDES="$RET" || true
>> +
>> +
>>  log() {
>>      logger -t base-installer "$@"
>>  }
>> @@ -125,11 +131,11 @@
>>                      COMPONENTS="*"
>>              fi
>>              if [ -s /cdrom/.disk/base_include ]; then
>> -                    INCLUDES=`grep -v '^#' /cdrom/.disk/base_include | tr 
>> '\n' , | sed 's/,$//'`
>> +                    INCLUDES="$INCLUDES,`grep -v '^#' 
>> /cdrom/.disk/base_include | tr '\n' , | sed 's/,$//'`"
>
> This makes INCLUDES be set to ",foo,bar" if it comes from the CD only. Does
> debootstrap actually support that syntax for --include and --exclude?
> It's not documented to, and seems like the sort of thing that might
> currently work by accident but should not be assumed to keep working.

I'll fix it too. Apart of those details is it OK for you?

>> +                    --print-debs \
>
> Don't think you meant to leave this in.

I already removed it in my current patch.
-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: [EMAIL PROTECTED]      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://www.freedom.ind.br/otavio
---------------------------------------------
"Microsoft gives you Windows ... Linux gives
 you the whole house."


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to