Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v9]

2024-12-06 Thread Severin Gehwolf
On Thu, 5 Dec 2024 20:05:56 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> system

Re: RFR: 8329251: Print custom truststore/ keystore name [v13]

2024-12-06 Thread Prasadrao Koppula
On Thu, 5 Dec 2024 14:11:29 GMT, Alan Bateman wrote: > Would it possible to list down the API entry points where you want map the > InputStream back to its source? I assume methods such as > KeyStore.getInstance(File file, ..) are not a concern, is it the > load(InputStream,password) method?

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-06 Thread Alan Bateman
On Fri, 6 Dec 2024 09:31:21 GMT, Severin Gehwolf wrote: > > Just to double check, with the default build, then `jlink --add-modules > > ALL-MODULE-PATH --output myimage` would fail because the module path hasn't > > been specified. No difference between default and > > --generate-linkable-runt

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v5]

2024-12-06 Thread Quan Anh Mai
> Hi, > > This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly just > the revert of the backout. > > Regarding the related issues: > > - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and > [JDK-8309531](https://bugs.openjdk.org/browse/JDK-8309531) have been fix

Re: RFR: 8329251: Print custom truststore/ keystore name [v13]

2024-12-06 Thread Prasadrao Koppula
On Fri, 6 Dec 2024 11:14:53 GMT, Alan Bateman wrote: > > > Would it possible to list down the API entry points where you want map > > > the InputStream back to its source? I assume methods such as > > > KeyStore.getInstance(File file, ..) are not a concern, is it the > > > load(InputStream,pas

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-06 Thread Severin Gehwolf
On Thu, 5 Dec 2024 14:39:58 GMT, Alan Bateman wrote: > > Abort the link with an appropriate error when ALL-MODULE-PATH is being used > > and a link from the run-time image is used but no module path given > > (--module-path arg missing). > > Just to double check, with the default build, then `

Re: RFR: 8329251: Print custom truststore/ keystore name [v13]

2024-12-06 Thread Alan Bateman
On Fri, 6 Dec 2024 10:55:08 GMT, Prasadrao Koppula wrote: > > Would it possible to list down the API entry points where you want map the > > InputStream back to its source? I assume methods such as > > KeyStore.getInstance(File file, ..) are not a concern, is it the > > load(InputStream,passwo

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v2]

2024-12-06 Thread Quan Anh Mai
On Thu, 5 Dec 2024 20:48:07 GMT, Paul Sandoz wrote: >> `shuffleFromOp` is a slow path op so I don't think it is. Additionally, our >> vector multiplication is against a scalar, too. So we can optimize it if >> `step` is a constant. > > I incorrectly read `!=` as `==` :-) as that is the more com

Re: RFR: 8316804: Gracefully handle the case where --release is not specified last [v2]

2024-12-06 Thread Jaikiran Pai
On Wed, 13 Nov 2024 16:08:44 GMT, Christian Stein wrote: >> Please review this change for the `jar` tool to gracefully handle the case >> where `--release` is not specified as the last arguments. >> >> Prior to this commit, operation modes `-d --describe-module` and >> `--validate` expected to

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-06 Thread Chen Liang
On Thu, 5 Dec 2024 20:44:59 GMT, Chen Liang wrote: >> Remove the redundant `@enablePreview` and `--enable-preview` flags for >> enabling ClassFile API in the tests. The remainder of these flags in all >> tests seem to serve preview APIs (such as ScopedValue) or language features >> (primitive

Integrated: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714

2024-12-06 Thread Chen Liang
On Wed, 27 Nov 2024 23:10:15 GMT, Chen Liang wrote: > Remove the redundant `@enablePreview` and `--enable-preview` flags for > enabling ClassFile API in the tests. The remainder of these flags in all > tests seem to serve preview APIs (such as ScopedValue) or language features > (primitive pa

Integrated: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler

2024-12-06 Thread Brent Christian
On Thu, 5 Dec 2024 21:41:28 GMT, Brent Christian wrote: > `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call > through `ReflectUtil.forName()`. When > `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`, > it is doing so from `java.base`, and so using

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v4]

2024-12-06 Thread Brian Burkhalter
On Fri, 6 Dec 2024 04:41:19 GMT, Taizo Kurashige wrote: >> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use >> Cygwin’s `df` to get the size for comparison if the test target drive is a >> CD-ROM drive. >> >> As described in JDK-8343342, GetDiskSpaceInformationW can

RFC: Untangle native libraries and the JVM: SVML, SLEEF, and libsimdsort

2024-12-06 Thread Vladimir Ivanov
Recently, a trend emerged to use native libraries to back intrinsics in HotSpot JVM. SVML stubs for Vector API paved the road and it was soon followed by SLEEF and simdsort libraries. After examining their support, I must confess that it doesn't look pretty. It introduces significant accidenta

Re: RFC: Untangle native libraries and the JVM: SVML, SLEEF, and libsimdsort

2024-12-06 Thread Vladimir Ivanov
Thanks, Paul. Excellent work, very happy to see more of this moved to Java leveraging Panama features. The Java code looks very organized. I am wondering if this technique can be applied to stubs dynamically generated by HotSpot via some sort of special library lookup e.g., for crypto. It's

Re: RFR: 8344647: Make java.se participate in the preview language feature `requires transitive java.base`

2024-12-06 Thread Liam Miller-Cushon
On Fri, 22 Nov 2024 13:42:32 GMT, Jan Lahoda wrote: > There is a new preview language feature, `requires transitive java.base;`. > And the `java.se` module is permitted to use the feature, without being > marked as preview (i.e. the `java.se` module participates in preview). This > is currentl

Re: RFC: Untangle native libraries and the JVM: SVML, SLEEF, and libsimdsort

2024-12-06 Thread Paul Sandoz
Hi Vladimir, Excellent work, very happy to see more of this moved to Java leveraging Panama features. The Java code looks very organized. I am wondering if this technique can be applied to stubs dynamically generated by HotSpot via some sort of special library lookup e.g., for crypto. Do you h

[jdk24] RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714

2024-12-06 Thread Chen Liang
Hi all, This pull request contains a backport of commit [49664195](https://github.com/openjdk/jdk/commit/496641955041c5e48359e6256a4a61812653d900) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This is a test-only change so it is eligible for backport; in addition, this change

RFR: 8345573: Module dependencies not resolved from run-time image when --limit-module is being used

2024-12-06 Thread Severin Gehwolf
Please review this fix for JEP 493 enabled JDKs related to the `--limit-modules` option. The existing jlink `bindservices` tests cover this issue. Previously they didn't run on a JEP 493 enabled JDK, since `jmods` folder is missing for them. The gist of the issue is that multiple `ModuleFinder`

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v8]

2024-12-06 Thread Michel Charpentier
On Sat, 13 Apr 2024 14:27:12 GMT, Viktor Klang wrote: >> This PR implements Gatherer-inspired encoding of `flatMap` that shows that >> it is both competitive performance-wise as well as improve correctness. >> >> Below is the performance of `Stream::flatMap` (for reference types): >> >> Before

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v2]

2024-12-06 Thread Quan Anh Mai
On Fri, 6 Dec 2024 16:16:04 GMT, Paul Sandoz wrote: >> This piece of code follows the pattern: >> >> if (uncommonCondition) { >> return uncommonPath(); >> } >> // Continue the common path >> >> So I think it is better to keep it as it is. > > Ok, but since it deviates from t

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v2]

2024-12-06 Thread Quan Anh Mai
On Fri, 6 Dec 2024 16:20:55 GMT, Paul Sandoz wrote: >> Ah i see now, you want to ensure an invocation to the final/concrete method. >> (The IDE's highlighting of the redundant cast is misleading) > > The common way we tend to do this in other areas is assign to a local > variable with the sharp

RFR: 8345687: Improve the implementation of SegmentFactories::allocateSegment

2024-12-06 Thread Quan Anh Mai
Hi, This patch improves the performance of a typical `Arena::allocate` in several ways: - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge of the instance with the one obtained from the call in the uncommon path, increasing the chance the object being scalar replaced. -

Re: RFR: 8345687: Improve the implementation of SegmentFactories::allocateSegment

2024-12-06 Thread Quan Anh Mai
On Fri, 6 Dec 2024 16:30:47 GMT, Quan Anh Mai wrote: > Hi, > > This patch improves the performance of a typical `Arena::allocate` in several > ways: > > - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge of > the instance with the one obtained from the call in the unco

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-06 Thread Joe Wang
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v2]

2024-12-06 Thread Weijun Wang
On Mon, 18 Nov 2024 23:01:41 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

Re: RFR: 8345687: Improve the implementation of SegmentFactories::allocateSegment

2024-12-06 Thread Jorn Vernee
On Fri, 6 Dec 2024 16:30:47 GMT, Quan Anh Mai wrote: > Hi, > > This patch improves the performance of a typical `Arena::allocate` in several > ways: > > - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge of > the instance with the one obtained from the call in the unco

Re: RFR: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler [v3]

2024-12-06 Thread Brent Christian
> `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call > through `ReflectUtil.forName()`. When > `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`, > it is doing so from `java.base`, and so using the boot loader. > > Changing `XmlReaderContentHandler`

Re: RFR: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler [v3]

2024-12-06 Thread Lance Andersen
On Fri, 6 Dec 2024 19:24:51 GMT, Brent Christian wrote: >> `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call >> through `ReflectUtil.forName()`. When >> `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`, >> it is doing so from `java.base`, and so u

Re: RFR: 8315487: Security Providers Filter [v15]

2024-12-06 Thread Francisco Ferrari Bihurriet
On Thu, 5 Dec 2024 20:45:57 GMT, Martin Balao wrote: >> In addition to the goals, scope, motivation, specification and requirement >> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we >> would like to describe the most relevant decisions taken during the >> implementation

Re: RFR: 8315487: Security Providers Filter [v16]

2024-12-06 Thread Martin Balao
> In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of this enhancement. These notes are organized by feature,

Re: RFR: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler [v2]

2024-12-06 Thread Alan Bateman
On Fri, 6 Dec 2024 17:38:22 GMT, Brent Christian wrote: >> `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call >> through `ReflectUtil.forName()`. When >> `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`, >> it is doing so from `java.base`, and so u

Re: RFR: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler [v2]

2024-12-06 Thread Lance Andersen
On Fri, 6 Dec 2024 17:38:22 GMT, Brent Christian wrote: >> `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call >> through `ReflectUtil.forName()`. When >> `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`, >> it is doing so from `java.base`, and so u

Re: RFR: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler [v2]

2024-12-06 Thread Chen Liang
On Fri, 6 Dec 2024 17:38:22 GMT, Brent Christian wrote: >> `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call >> through `ReflectUtil.forName()`. When >> `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`, >> it is doing so from `java.base`, and so u

Re: RFR: 8343962: [REDO] Move getChars to DecimalDigits [v2]

2024-12-06 Thread Shaojin Wen
> This PR is a resubmission after PR #21593 was rolled back, and the unsafe > offset overflow issue has been fixed. > > 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to > reduce duplication. > > 2) HexDigits and OctalDigits also include getCharsLatin1 and getCharsUTF

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v2]

2024-12-06 Thread Weijun Wang
On Mon, 18 Nov 2024 23:01:41 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

Re: RFR: 8345335: Add excluded jdk_foreign tests to manual group

2024-12-06 Thread Jorn Vernee
On Fri, 6 Dec 2024 07:17:28 GMT, Alan Bateman wrote: >> test/jdk/TEST.groups line 625: >> >>> 623: javax/xml/jaxp/datatype/8033980/GregorianCalAndDurSerDataUtil.java >>> \ >>> 624: java/foreign/TestMatrix.java \ >>> 625: java/foreign/TestUpcallStress.java >> >> I note that the test

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v2]

2024-12-06 Thread Paul Sandoz
On Fri, 6 Dec 2024 09:14:07 GMT, Quan Anh Mai wrote: >> I incorrectly read `!=` as `==` :-) as that is the more common pattern used >> in the code base, so i was thinking the power of two code path was using >> `shuffleFromOp`. Could you invert the check to be more consistent? > > This piece of

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v2]

2024-12-06 Thread Paul Sandoz
On Thu, 5 Dec 2024 20:36:48 GMT, Paul Sandoz wrote: >> The cast is added so that we have the concrete type of the shuffle, the >> result of `toShuffle` is only `VectorShuffle` > > Ah i see now, you want to ensure an invocation to the final/concrete method. > (The IDE's highlighting of the redun

Re: RFR: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler [v2]

2024-12-06 Thread Mandy Chung
On Fri, 6 Dec 2024 17:38:22 GMT, Brent Christian wrote: >> `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call >> through `ReflectUtil.forName()`. When >> `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`, >> it is doing so from `java.base`, and so u

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v6]

2024-12-06 Thread Quan Anh Mai
> Hi, > > This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly just > the revert of the backout. > > Regarding the related issues: > > - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and > [JDK-8309531](https://bugs.openjdk.org/browse/JDK-8309531) have been fix

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-06 Thread Mandy Chung
On Mon, 2 Dec 2024 18:25:22 GMT, Severin Gehwolf wrote: > Please review this bug fix for using `jlink` when linking from the run-time > image. For regular JDK builds which include the `jmods` folder, that path is > automatically added as the `--module-path` when not otherwise specified on > th

Re: RFR: 8344611: Add missing classpath exception

2024-12-06 Thread Iris Clark
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote: > This PR adds missing Classpath exception in several files. > > JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611) Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/22272#

Re: RFR: 8328119: Support HKDF in SunPKCS11 (Preview) [v2]

2024-12-06 Thread Weijun Wang
On Mon, 18 Nov 2024 23:01:41 GMT, Martin Balao wrote: >> We would like to propose an implementation of the HKDF algorithms for >> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key >> Derivation Function API >> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)). >

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-06 Thread Chen Liang
On Thu, 5 Dec 2024 20:44:59 GMT, Chen Liang wrote: >> Remove the redundant `@enablePreview` and `--enable-preview` flags for >> enabling ClassFile API in the tests. The remainder of these flags in all >> tests seem to serve preview APIs (such as ScopedValue) or language features >> (primitive

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v6]

2024-12-06 Thread Paul Sandoz
On Fri, 6 Dec 2024 17:00:15 GMT, Quan Anh Mai wrote: >> Hi, >> >> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly >> just the revert of the backout. >> >> Regarding the related issues: >> >> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and >> [JDK-830

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v2]

2024-12-06 Thread Paul Sandoz
On Tue, 26 Nov 2024 18:17:05 GMT, Quan Anh Mai wrote: >> @merykitty Could you please merge with the latest and resolve conflicts? > > @sviswa7 @PaulSandoz @eme64 @jatin-bhateja Thanks for taking a look, I have > merged the PR with a more recent master and resolved the sematic difference > with

Re: RFR: 8333377: Migrate Generic Signature parsing to ClassFile API [v4]

2024-12-06 Thread Chen Liang
On Thu, 5 Dec 2024 19:48:49 GMT, Chen Liang wrote: >> Core reflection's generic signature parsing uses an ancient library with >> outdated visitor pattern on a tree model and contains unnecessary >> boilerplates. This is a duplication of ClassFile API's signature model. We >> should just move

Re: RFR: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler

2024-12-06 Thread Brent Christian
On Fri, 6 Dec 2024 05:58:55 GMT, Alan Bateman wrote: > ReflectUtil.forName can be removed as this is the last usage. Also java.base > no longer needs to export sun.reflect.misc to java.sql.rowset. Right, thanks. Done. - PR Comment: https://git.openjdk.org/jdk/pull/22585#issuecomme

Re: RFR: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler [v2]

2024-12-06 Thread Brent Christian
> `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call > through `ReflectUtil.forName()`. When > `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`, > it is doing so from `java.base`, and so using the boot loader. > > Changing `XmlReaderContentHandler`

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v2]

2024-12-06 Thread Quan Anh Mai
On Fri, 6 Dec 2024 17:22:33 GMT, Paul Sandoz wrote: >> @sviswa7 @PaulSandoz @eme64 @jatin-bhateja Thanks for taking a look, I have >> merged the PR with a more recent master and resolved the sematic difference >> with newly added intrinsics, too. > > @merykitty do you want me to initiate tier 1

Withdrawn: 8331467: ImageReaderFactory can cause a ClassNotFoundException if the default FileSystemProvider is not the system-default provider

2024-12-06 Thread jyxzwd
On Sat, 9 Nov 2024 02:18:22 GMT, jyxzwd wrote: > Use the built-in file system provider rather than the custom file system > provider. > Add "public static FileSystemProvider create" method in > DefaultFileSystemProvider which is from java8API to be compatible against > runtime. This pull requ