On Fri, 6 Dec 2024 09:14:07 GMT, Quan Anh Mai <qa...@openjdk.org> wrote:
>> I incorrectly read `!=` as `==` :-) as that is the more common pattern used
>> in the code base, so i was thinking the power of two code path was using
>> `shuffleFromOp`. Could you invert the check to be more consistent?
>
> This piece of code follows the pattern:
>
> if (uncommonCondition) {
> return uncommonPath();
> }
> // Continue the common path
>
> So I think it is better to keep it as it is.
Ok, but since it deviates from the pattern applied in other areas for POT
checks and caught me out would you mind adding a comment?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21042#discussion_r1873634643
