Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-17 Thread Naoto Sato
On Thu, 17 Apr 2025 14:01:07 GMT, Magnus Ihse Bursie wrote: > Is there some specific problem you are worried about on Windows that you were > thinking about? I would have tested on non-English (preferrably Chinese/Japanese) Windows where users set it to English. I believe we had issues from co

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-17 Thread Matthias Baesken
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-17 Thread Magnus Ihse Bursie
On Wed, 16 Apr 2025 16:14:39 GMT, Naoto Sato wrote: > We will probably need to make sure things are ok on Windows as well (they are > the other confusing environment) Windows is much more painful to work with, since there is no correspondence of `LC_ALL`; you must set the user's locale. There

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Naoto Sato
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Magnus Ihse Bursie
On Wed, 16 Apr 2025 10:35:02 GMT, Matthias Baesken wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Also document UTF-8 requirements (solves JDK-8338973) >> - Let configure only accept utf-8 locales >> -

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Matthias Baesken
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Magnus Ihse Bursie
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Martin Doerr
On Wed, 16 Apr 2025 09:51:49 GMT, Magnus Ihse Bursie wrote: > `locale -a` C POSIX en_US.8859-15 en_US.IBM-858 en_US.ISO8859-1 en_US I don't know if UTF-8 can be installed. If so, we should also document that as requirement for AIX build machines. - PR Comment: https://git.openj

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Magnus Ihse Bursie
On Wed, 16 Apr 2025 07:54:13 GMT, Martin Doerr wrote: > We get the following problem on AIX: > > ``` > checking for locale to use... no UTF-8 locale found > configure: error: No UTF-8 locale found. This is required for building > successfully. > configure exiting with result code 1 > ``` This

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Magnus Ihse Bursie
On Tue, 15 Apr 2025 23:20:45 GMT, Sergey Bylokhov wrote: > can we also force this rule by the jcheck? Well, yes and no. First, we can verify that we do not have invalid UTF-8. That might be a signal that the encoding is wrong. But then this check needs to be able to distinguish between pure bi

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-16 Thread Martin Doerr
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-15 Thread Sergey Bylokhov
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-14 Thread Magnus Ihse Bursie
> Most of the JDK code base has been transitioned to UTF-8, but not all. This > has recently become an acute problem, since our mixing of iso-8859-1 and > utf-8 in properties files confused the version of `sed` that is shipped with > the new macOS 15.4. > > The fix is basically simple, and incl

Re: RFR: 8301971: Make JDK source code UTF-8 [v3]

2025-04-14 Thread Kim Barrett
On Mon, 14 Apr 2025 12:53:35 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v2]

2025-04-14 Thread Kim Barrett
On Sun, 13 Apr 2025 23:14:41 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v2]

2025-04-14 Thread Magnus Ihse Bursie
On Sun, 13 Apr 2025 23:14:41 GMT, Magnus Ihse Bursie wrote: >> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with

Re: RFR: 8301971: Make JDK source code UTF-8 [v2]

2025-04-13 Thread Magnus Ihse Bursie
> Most of the JDK code base has been transitioned to UTF-8, but not all. This > has recently become an acute problem, since our mixing of iso-8859-1 and > utf-8 in properties files confused the version of `sed` that is shipped with > the new macOS 15.4. > > The fix is basically simple, and incl

Re: RFR: 8301971: Make JDK source code UTF-8

2025-04-13 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 14:28:02 GMT, Magnus Ihse Bursie wrote: > Most of the JDK code base has been transitioned to UTF-8, but not all. This > has recently become an acute problem, since our mixing of iso-8859-1 and > utf-8 in properties files confused the version of `sed` that is shipped with >