On Thu, 17 Apr 2025 16:26:59 GMT, Naoto Sato <na...@openjdk.org> wrote:
>>> We will probably need to make sure things are ok on Windows as well (they >>> are the other confusing environment) >> >> Windows is much more painful to work with, since there is no correspondence >> of `LC_ALL`; you must set the user's locale. There is a rather long >> paragraph detailing the requirements for building without problems in the >> build README. >> >> Is there some specific problem you are worried about on Windows that you >> were thinking about? > >> Is there some specific problem you are worried about on Windows that you >> were thinking about? > > I would have tested on non-English (preferrably Chinese/Japanese) Windows > where users set it to English. I believe we had issues from contributors in > those areas. @naotoj Unfortunately, I do not have the possibility to test on a Windows machine with Chinese locale. I'll ping Yi Yang who was behind https://github.com/openjdk/jdk/pull/3107, a suggested solution for [JDK-8263028](https://bugs.openjdk.org/browse/JDK-8263028). That is the best I was able to dig up for any contributor that clearly had run into this kind of problems before. @y1yang0 Can you please help us to test this patch so it works properly on Windows computers with Chinese locale? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24574#issuecomment-2854924350
