On Sun, 13 Apr 2025 23:14:41 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Most of the JDK code base has been transitioned to UTF-8, but not all. This >> has recently become an acute problem, since our mixing of iso-8859-1 and >> utf-8 in properties files confused the version of `sed` that is shipped with >> the new macOS 15.4. >> >> The fix is basically simple, and includes the following steps: >> * Look through the code base for text files containing non-ASCII characters, >> and convert them to UTF-8, if they are not already >> * Update tooling used in building to recognize the fact that files are now >> in UTF-8 and treat them accordingly (basically, updating compiler flags, git >> attributes, etc). > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Also tell javadoc that we have utf-8 now A couple of drive-by comments. Don't count me as a Reviewer for this. make/autoconf/flags-cflags.m4 line 577: > 575: elif test "x$TOOLCHAIN_TYPE" = xmicrosoft; then > 576: # The -utf-8 option sets source and execution character sets to > UTF-8 to enable correct > 577: # compilation of all source files regardless of the active code page > on Windows. Seems like this comment should be updated and moved near the new code block for setting up `CHARSET_CFLAGS`. make/common/JavaCompilation.gmk line 83: > 81: # The sed expression does this: > 82: # 1. Add a backslash before any :, = or ! that do not have a backslash > already. > 83: # 3. Delete all lines starting with #. There is no item 2 anymore, so following bullets are misnumbered. ------------- Changes requested by kbarrett (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24574#pullrequestreview-2762999364 PR Review Comment: https://git.openjdk.org/jdk/pull/24574#discussion_r2041326051 PR Review Comment: https://git.openjdk.org/jdk/pull/24574#discussion_r2041328098
