On Thu, 27 Jul 2023 18:07:12 GMT, Ioi Lam wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refactored KlassToOopHandleTable, Ioi and Alan comments
>
> Looks good. Just a couple of nits.
Thank you for the r
On Wed, 2 Aug 2023 04:01:46 GMT, David Holmes wrote:
>> Yes it should! Thank you for catching this.
>
> This suggests we don't have test coverage for this case.
If we want to add a test case, I would suggest adding a WhiteBox method like:
public native Object[] getResolvedReferences(Class c);
On Tue, 1 Aug 2023 21:02:36 GMT, Matias Saavedra Silva
wrote:
>> src/hotspot/share/oops/constantPool.cpp line 308:
>>
>>> 306: assert(java_lang_String::is_instance(obj), "must be");
>>> 307: if (!ArchiveHeapWriter::is_string_too_large_to_archive(obj))
>>> {
>>> 308:
On Tue, 1 Aug 2023 21:08:05 GMT, Matias Saavedra Silva
wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have
> Currently we exit the VM after static dumping with
> `MetaspaceShared::exit_after_static_dump()`.
>
>
> // We have finished dumping the static archive. At this point, there may be
> pending VM
> // operations. We have changed some global states (such as
> vmClasses::_klasses) that
> // m
On Tue, 1 Aug 2023 17:02:46 GMT, Calvin Cheung wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Ioi comments
>
> src/hotspot/share/oops/constantPool.cpp line 308:
>
>> 306: assert(java_lang_Strin
On Thu, 27 Jul 2023 19:09:00 GMT, Matias Saavedra Silva
wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have
On Thu, 27 Jul 2023 19:09:00 GMT, Matias Saavedra Silva
wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have
> Currently we exit the VM after static dumping with
> `MetaspaceShared::exit_after_static_dump()`.
>
>
> // We have finished dumping the static archive. At this point, there may be
> pending VM
> // operations. We have changed some global states (such as
> vmClasses::_klasses) that
> // m
On Thu, 27 Jul 2023 13:40:56 GMT, Matias Saavedra Silva
wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have
> Currently we exit the VM after static dumping with
> `MetaspaceShared::exit_after_static_dump()`.
>
>
> // We have finished dumping the static archive. At this point, there may be
> pending VM
> // operations. We have changed some global states (such as
> vmClasses::_klasses) that
> // m
On Thu, 27 Jul 2023 06:07:42 GMT, David Holmes wrote:
>> Yes, if you change it CHECK_EXCEPTION_LEAVE(1)then any pending exception
>> will be printed and it will exit with 1; if there is no pending exception
>> then it exit with the value of `ret` as the exit status, which will be 0
>> here.
>
On Thu, 27 Jul 2023 05:45:59 GMT, Alan Bateman wrote:
>> I am not incredibly familiar with the java launcher but I believe what I
>> have is a mistake. I will change it to `CHECK_EXCEPTION_LEAVE(1)` instead.
>
> Yes, if you change it CHECK_EXCEPTION_LEAVE(1)then any pending exception will
> be
On Wed, 26 Jul 2023 21:52:04 GMT, Matias Saavedra Silva
wrote:
>> src/java.base/share/native/libjli/java.c line 464:
>>
>>> 462: if (dumpSharedSpaces) {
>>> 463: CHECK_EXCEPTION_LEAVE(0);
>>> 464: LEAVE();
>>
>> What is exit status ($?) when -Xshare:dump fails. It looks like an
On Wed, 26 Jul 2023 18:52:41 GMT, Alan Bateman wrote:
>> Matias Saavedra Silva has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request now contains five commits:
>>
>> - Merge fix
>> - Restores java loaders
>> - Ioi and David comments
>> - Windows
On Tue, 25 Jul 2023 18:48:58 GMT, Matias Saavedra Silva
wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have
On Tue, 25 Jul 2023 18:48:58 GMT, Matias Saavedra Silva
wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have
On Thu, 13 Jul 2023 21:25:17 GMT, Matias Saavedra Silva
wrote:
> Currently we exit the VM after static dumping with
> `MetaspaceShared::exit_after_static_dump()`.
>
>
> // We have finished dumping the static archive. At this point, there may be
> pending VM
> // operations. We have change
> Currently we exit the VM after static dumping with
> `MetaspaceShared::exit_after_static_dump()`.
>
>
> // We have finished dumping the static archive. At this point, there may be
> pending VM
> // operations. We have changed some global states (such as
> vmClasses::_klasses) that
> // m
On Mon, 17 Jul 2023 16:55:03 GMT, Ioi Lam wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have changed some g
On Mon, 17 Jul 2023 17:14:01 GMT, Ioi Lam wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have changed some g
On Thu, 13 Jul 2023 21:25:17 GMT, Matias Saavedra Silva
wrote:
> Currently we exit the VM after static dumping with
> `MetaspaceShared::exit_after_static_dump()`.
>
>
> // We have finished dumping the static archive. At this point, there may be
> pending VM
> // operations. We have change
On Thu, 13 Jul 2023 21:25:17 GMT, Matias Saavedra Silva
wrote:
> Currently we exit the VM after static dumping with
> `MetaspaceShared::exit_after_static_dump()`.
>
>
> // We have finished dumping the static archive. At this point, there may be
> pending VM
> // operations. We have change
Currently we exit the VM after static dumping with
`MetaspaceShared::exit_after_static_dump()`.
// We have finished dumping the static archive. At this point, there may be
pending VM
// operations. We have changed some global states (such as
vmClasses::_klasses) that
// may cause these VM
24 matches
Mail list logo
