On Thu, 27 Jul 2023 05:45:59 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> I am not incredibly familiar with the java launcher but I believe what I >> have is a mistake. I will change it to `CHECK_EXCEPTION_LEAVE(1)` instead. > > Yes, if you change it CHECK_EXCEPTION_LEAVE(1)then any pending exception will > be printed and it will exit with 1; if there is no pending exception then it > exit with the value of `ret` as the exit status, which will be 0 here. Sorry I missed this. Unclear when `CHECK_EXCEPTION_LEAVE(0)` would ever be appropriate??? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14879#discussion_r1275772680
