On Thu, 27 Jul 2023 06:07:42 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Yes, if you change it CHECK_EXCEPTION_LEAVE(1)then any pending exception >> will be printed and it will exit with 1; if there is no pending exception >> then it exit with the value of `ret` as the exit status, which will be 0 >> here. > > Sorry I missed this. Unclear when `CHECK_EXCEPTION_LEAVE(0)` would ever be > appropriate??? I can't think of any case where `CHECK_EXCEPTION_LEAVE(0)` would be useful, in which case we need to check the -version/-showversion handling in the unlikely event that VersionProps.print completes with an exception (nothing to do this PR of course). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14879#discussion_r1275784806
