On Thu, 27 Jul 2023 19:09:00 GMT, Matias Saavedra Silva <[email protected]>
wrote:
>> Currently we exit the VM after static dumping with
>> `MetaspaceShared::exit_after_static_dump()`.
>>
>>
>> // We have finished dumping the static archive. At this point, there may be
>> pending VM
>> // operations. We have changed some global states (such as
>> vmClasses::_klasses) that
>> // may cause these VM operations to fail. For safety, forget these
>> operations and
>> // exit the VM directly.
>> void MetaspaceShared::exit_after_static_dump() {
>> os::_exit(0);
>> }
>>
>>
>> As the comment suggests, the VM state is altered when preparing and
>> performing the static dump, so this change aims to prevent these state
>> changes so the VM can exit normally after the static dump completes. There
>> are three major aspects to this change:
>> 1. Since the resolved references array in the Constant Pool is altered when
>> preparing for a static dump, a "scratch copy" is created and archived
>> instead
>> 2. Symbols are sorted by address and have their hash recalculated. Similarly
>> to point 1, the copies of the symbols that are to be archived have their
>> hashes updated as opposed to the originals.
>> 3. The handling of -Xshare:dump during argument parsing such that the VM can
>> continue and exit normally with an exit code of 0.
>>
>> Verified with tier 1-9 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Ioi comments
Looks good overall. I have one question.
src/hotspot/share/oops/constantPool.cpp line 308:
> 306: assert(java_lang_String::is_instance(obj), "must be");
> 307: if (!ArchiveHeapWriter::is_string_too_large_to_archive(obj)) {
> 308: scratch_rr->obj_at_put(i, nullptr);
Should the above be the following?
`scratch_rr->obj_at_put(i, obj);`
-------------
PR Review: https://git.openjdk.org/jdk/pull/14879#pullrequestreview-1557454731
PR Review Comment: https://git.openjdk.org/jdk/pull/14879#discussion_r1280919862
