Re: RFR: 8355746: Start of release updates for JDK 26

2025-05-02 Thread Joe Darcy
On Fri, 2 May 2025 16:55:49 GMT, Chen Liang wrote: > May I prepare a quick patch to bring this in line with `TraverseProc` so we > can skip this site for future start of release updates? I know it is possible to write getSupportedSourceVersion to return the latest version, but I don't think it

Re: RFR: 8355746: Start of release updates for JDK 26

2025-05-02 Thread Joe Darcy
On Fri, 2 May 2025 16:54:59 GMT, Chen Liang wrote: > I have asked @nizarbenalla in offline communications for a list of failing > hotspot tests. I aim to update them on a case-by-case basis, to determine if > the compile arguments should provide a `--release ` argument or migrate > class file

Re: RFR: 8355746: Start of release updates for JDK 26

2025-05-02 Thread Joe Darcy
On Fri, 2 May 2025 15:47:43 GMT, Chen Liang wrote: >> Get JDK 26 underway. > > make/conf/version-numbers.conf line 36: > >> 34: DEFAULT_VERSION_EXTRA2=0 >> 35: DEFAULT_VERSION_EXTRA3=0 >> 36: DEFAULT_VERSION_DATE=2026-03-16 > > Is this accurate? One day off; should be 2026-03-17. I should hav

Re: Namespace Prefix Issue in XML to XSL Transformation

2025-05-01 Thread Joe Wang
Hi Hempushpa, You may want to talk to Christoph on JDK-8168664, he might have temped a fix at the time. Otherwise, feel free to create a new bug and PR, and we can start from there. Thanks, Joe On 4/23/25 7:03 AM, Hempushpa Sahu wrote: Problem Description : XSLT transformation

Re: RFR: 8354424: java/util/logging/LoggingDeadlock5.java fails intermittently in tier6 [v2]

2025-05-01 Thread Joe Darcy
On Thu, 24 Apr 2025 16:24:53 GMT, Stuart Marks wrote: >> Hi Joe, yes `adjustTimeout` will scale based on the jtreg timeout factor. I >> believe the behaviour is to multiply whatever hardcoded timeout is passed by >> the timeout factor. >> On lower tiers, in our CI, I b

Integrated: 8354084: Streamline XPath API's extension function control

2025-05-01 Thread Joe Wang
On Fri, 11 Apr 2025 23:05:51 GMT, Joe Wang wrote: > Streamline the extension function control in the XPath API by relying solely > on > [XPathFunctionResolver](https://docs.oracle.com/en/java/javase/24/docs/api/java.xml/javax/xml/xpath/XPathFunctionResolver.html), > which provi

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v11]

2025-05-01 Thread Joe Darcy
On Thu, 1 May 2025 13:03:47 GMT, Markus KARG wrote: >> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 488: >> >>> 486: /** >>> 487: * {@inheritDoc CharSequence} >>> 488: */ >> >> Suggestion: >> >> * {@inheritDoc CharSequence} >> * @param srcBegin

Re: RFR: 8343110: Add getChars(int, int, char[], int) to CharSequence and CharBuffer [v9]

2025-04-30 Thread Joe Darcy
On Wed, 30 Apr 2025 17:59:55 GMT, Markus KARG wrote: >> Could this be a Javadoc bug? What does a simple `{@inheritDoc}` do? > > Unfortunately the same happens. 🙁 The following javadoc for String's getChars method has, I believe, the desired effect: /** * {@inheritDoc CharSequence}

Re: RFR: 8355301: Simplify Throwable::printStackTrace by replacing inner class with static method [v4]

2025-04-24 Thread Joe Darcy
On Fri, 25 Apr 2025 00:34:39 GMT, Shaojin Wen wrote: >> Again, what goal is this PR trying to accomplish? > > The goal of this PR is to simplify the code by using new language features. To what end? - "I was reading Throwable and noticed this possible refactoring." - "I've run an analysis of th

Re: RFR: 8355301: Simplify Throwable::printStackTrace by replacing inner class with static method [v4]

2025-04-24 Thread Joe Darcy
On Thu, 24 Apr 2025 23:52:09 GMT, Shaojin Wen wrote: >>> What should we replace it with? Do you have any suggestions? >> >> The wrapper classes were needed when there were was a mix of synchronized >> and j.u.concurrent locks in use. With JEP 491 integrated it meant that the >> java.io classes

Re: RFR: 8355215: Add @spec tags to Emoji related methods

2025-04-21 Thread Joe Wang
On Mon, 21 Apr 2025 20:11:47 GMT, Naoto Sato wrote: > Adding @spec tags to Emoji related methods in the Character class. A CSR has > also been drafted. Marked as reviewed by joehw (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24779#pullrequestreview-2782236067

Re: RFR: 8354424: java/util/logging/LoggingDeadlock5.java fails intermittently in tier6 [v2]

2025-04-21 Thread Joe Darcy
On Wed, 16 Apr 2025 17:37:07 GMT, David Beaumont wrote: >> Increasing timeout for deadlock detection and adjusting for the timeout >> factor in higher tiers. > > David Beaumont has updated the pull request incrementally with one additional > commit since the last revision: > > Removing test

Integrated: 8354774: DocumentBuilderFactory getAttribute throws NPE

2025-04-21 Thread Joe Wang
On Thu, 17 Apr 2025 17:41:56 GMT, Joe Wang wrote: > Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug > report. > > Also in this patch: consolidates get and set properties to use the same Util > methods to reduce potential errors when code cha

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-21 Thread Joe Wang
On Mon, 21 Apr 2025 08:11:33 GMT, Andrey Turbanov wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused variable pName; remove unused imports > > src/java.xml/share/classes/jdk

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v3]

2025-04-21 Thread Joe Wang
> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug > report. > > Also in this patch: consolidates get and set properties to use the same Util > methods to reduce potential errors when code changes. > > Test: > Tier1 - 3 passed > JC

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-19 Thread Joe Wang
On Sun, 20 Apr 2025 03:05:20 GMT, SendaoYan wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused variable pName; remove unused imports > > test/jaxp/javax/xml/jaxp/unittest/comm

Re: RFR: 8259540: MissingResourceException for key cvc-complex-type.2.4.d.1 [v3]

2025-04-18 Thread Joe Wang
On Fri, 18 Apr 2025 22:15:10 GMT, Alexey Bakhtin wrote: >> Please find a trivial fix for the missing `cvc-complex-type.2.4.d.1` >> resource in the main XMLSchemaMessages.properties file. > > Alexey Bakhtin has updated the pull request incrementally with one additional > commit since the last re

Re: RFR: 8259540: MissingResourceException for key cvc-complex-type.2.4.d.1

2025-04-18 Thread Joe Wang
On Fri, 18 Apr 2025 17:40:10 GMT, Joe Wang wrote: >> Added missed localized strings for _de, _ja and _zh_CN localities based on >> the JDK11 localizations > >> Added missed localized strings for _de, _ja and _zh_CN localities based on >> the JDK11 localizations >

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-18 Thread Joe Wang
On Fri, 18 Apr 2025 20:06:01 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unused variable pName; remove unused imports > > src/java.xml/share/classes/com/sun/o

Re: RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE [v2]

2025-04-18 Thread Joe Wang
> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug > report. > > Also in this patch: consolidates get and set properties to use the same Util > methods to reduce potential errors when code changes. > > Test: > Tier1 - 3 passed > JC

Re: RFR: 8259540: MissingResourceException for key cvc-complex-type.2.4.d.1

2025-04-18 Thread Joe Wang
On Fri, 18 Apr 2025 17:09:40 GMT, Alexey Bakhtin wrote: > Added missed localized strings for _de, _ja and _zh_CN localities based on > the JDK11 localizations Probably not necessary as they will be covered by L10n resource update. - PR Comment: https://git.openjdk.org/jdk/pull/247

Re: RFR: 8259540: MissingResourceException for key cvc-complex-type.2.4.d.1

2025-04-18 Thread Joe Wang
On Fri, 18 Apr 2025 04:08:56 GMT, Alexey Bakhtin wrote: > Please find a trivial fix for the missing `cvc-complex-type.2.4.d.1` resource > in the main XMLSchemaMessages.properties file. @alexeybakhtin also, I assigned the issue to you. Thanks. - PR Comment: https://git.openjdk.org/

Re: RFR: 8259540: MissingResourceException for key cvc-complex-type.2.4.d.1

2025-04-17 Thread Joe Wang
On Fri, 18 Apr 2025 04:08:56 GMT, Alexey Bakhtin wrote: > Please find a trivial fix for the missing `cvc-complex-type.2.4.d.1` resource > in the main XMLSchemaMessages.properties file. LGTM. Added a link to JDK-8355006. - Marked as reviewed by joehw (Reviewer). PR Review: https:/

RFR: 8354774: DocumentBuilderFactory getAttribute throws NPE

2025-04-17 Thread Joe Wang
Fix a NPE on calling DocumentBuilderFactory::getAttribute. This issue was found during the previous JCK test (JCK-7322355). The JCK failure was from a different method call, but it appears this is the root cause. Also in this patch: consolidates get and set properties to use the same Util metho

Re: RFR: 8354084: Streamline XPath API's extension function control [v4]

2025-04-16 Thread Joe Wang
On Wed, 16 Apr 2025 13:47:28 GMT, Roger Riggs wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update javadoc for the jdk.xml.enableExtensionFunctions property > > src/java.xml/share/cla

Re: RFR: 8354084: Streamline XPath API's extension function control [v5]

2025-04-16 Thread Joe Wang
. There were unrelated/known > failures (e.g. bug8329757). > JCK passed except the previously reported issue (JCK-7322355). Joe Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/reba

Re: RFR: 8354084: Streamline XPath API's extension function control [v4]

2025-04-16 Thread Joe Wang
. There were unrelated/known > failures (e.g. bug8329757). > JCK passed except the previously reported issue (JCK-7322355). Joe Wang has updated the pull request incrementally with one additional commit since the last revision: update javadoc for the jdk.xml.enableExtensionFunctions propert

Re: RFR: 8354084: Streamline XPath API's extension function control [v3]

2025-04-15 Thread Joe Wang
. There were unrelated/known > failures (e.g. bug8329757). > JCK passed except the previously reported issue (JCK-7322355). Joe Wang has updated the pull request incrementally with one additional commit since the last revision: rewind resource files, leave them to L10n resource files update --

Re: RFR: 8346230: [perf] scalability issue for the specjvm2008::xml.transform workload [v6]

2025-04-14 Thread Joe Wang
On Mon, 14 Apr 2025 15:22:21 GMT, Vladimir Ivanov wrote: >> The HashMap for caching was deleted. Now it use only ThreadLocal variable >> without synchronization. >> According to the specjvm2008::xml.transform workload the performance for low >> threads counts was not affected and improved for h

Re: RFR: 8354084: Streamline XPath API's extension function control [v2]

2025-04-11 Thread Joe Wang
. There were unrelated/known > failures (e.g. bug8329757). > JCK passed except the previously reported issue (JCK-7322355). Joe Wang has updated the pull request incrementally with one additional commit since the last revision: add copyright and docs - Changes: - a

RFR: 8354084: Streamline XPath API's extension function control

2025-04-11 Thread Joe Wang
Streamline the extension function control in the XPath API by relying solely on [XPathFunctionResolver](https://docs.oracle.com/en/java/javase/24/docs/api/java.xml/javax/xml/xpath/XPathFunctionResolver.html), which provides a secure and developer-defined mechanism. Remove the feature FEATURE_SEC

Re: RFR: 8341402: BigDecimal's square root optimization [v31]

2025-04-10 Thread Joe Darcy
On Tue, 18 Mar 2025 14:46:01 GMT, fabioromano1 wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> An optimization > > This comment is to avoid closing this PR. > @fabioromano1 Thanks so much for your great work and p

Re: RFR: 8353234: Refactor XMLSecurityPropertyManager

2025-04-04 Thread Joe Wang
On Mon, 31 Mar 2025 19:18:58 GMT, Joe Wang wrote: >> LGTM. Technically it is still March in PDT though > >> LGTM. Technically it is still March in PDT though > > Thanks. It is, tricky. Thought by the time it's out, it would be April. > @JoeWang-Java, > > Can

Re: RFR: 8319447: Improve performance of delayed task handling [v12]

2025-04-04 Thread Joe Darcy
On Sat, 22 Mar 2025 11:09:03 GMT, Doug Lea wrote: >> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) >> >> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is >> both ill-suited for many (if not most) of its applications, and is a >> performance bottleneck (a

Integrated: 8353234: Refactor XMLSecurityPropertyManager

2025-04-04 Thread Joe Wang
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote: > Refactor XMLSecurityPropertyManager. > The Xerces and Xalan components each had its own XMLSecurityManager and > XMLSecurityPropertyManager. In a previous fix, the former had been unified as > part of that changeset. This chang

Re: RFR: 8353234: Refactor XMLSecurityPropertyManager

2025-04-02 Thread Joe Wang
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote: > Refactor XMLSecurityPropertyManager. > The Xerces and Xalan components each had its own XMLSecurityManager and > XMLSecurityPropertyManager. In a previous fix, the former had been unified as > part of that changeset. This chang

Re: RFR: 8353234: Refactor XMLSecurityPropertyManager

2025-04-02 Thread Joe Wang
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote: > Refactor XMLSecurityPropertyManager. > The Xerces and Xalan components each had its own XMLSecurityManager and > XMLSecurityPropertyManager. In a previous fix, the former had been unified as > part of that changeset. This chang

Re: RFR: 8350704: Create tests to ensure the failure behavior of core reflection APIs [v3]

2025-04-01 Thread Joe Darcy
On Mon, 24 Mar 2025 21:29:29 GMT, Chen Liang wrote: >> Core reflection's generic signature parsing system is used for many aspects, >> including annotations and enclosing methods, yet it is under-tested. It is >> better for us to set up tests to ensure that sensitive error behaviors of >> core

Re: RFR: 8353234: Refactor XMLSecurityPropertyManager

2025-04-01 Thread Joe Wang
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote: > Refactor XMLSecurityPropertyManager. > The Xerces and Xalan components each had its own XMLSecurityManager and > XMLSecurityPropertyManager. In a previous fix, the former had been unified as > part of that changeset. This chang

RFR: 8353234: Refactor XMLSecurityPropertyManager

2025-03-31 Thread Joe Wang
Refactor XMLSecurityPropertyManager. The Xerces and Xalan components each had its own XMLSecurityManager and XMLSecurityPropertyManager. In a previous fix, the former had been unified as part of that changeset. This change will allow future changes to handle XMLSecurityManager and XMLSecurityPro

Re: RFR: 8353234: Refactor XMLSecurityPropertyManager

2025-03-31 Thread Joe Wang
On Mon, 31 Mar 2025 19:11:03 GMT, Naoto Sato wrote: > LGTM. Technically it is still March in PDT though Thanks. It is, tricky. Thought by the time it's out, it would be April. - PR Comment: https://git.openjdk.org/jdk/pull/24334#issuecomment-2767177971

Re: RFR: 8346230: [perf] scalability issue for the specjvm2008::xml.transform workload [v4]

2025-03-25 Thread Joe Wang
On Mon, 20 Jan 2025 13:51:22 GMT, Alan Bateman wrote: >> Vladimir Ivanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8346230 [perf] scalability issue for the specjvm2008::xml.transform >> workload > > src/java.xml/share/classes/com/

Re: RFR: 8352716: (tz) Update Timezone Data to 2025b

2025-03-25 Thread Joe Wang
On Tue, 25 Mar 2025 16:52:28 GMT, Naoto Sato wrote: > Incorporating the latest IANA Time Zone Database (2025b). Manually confirmed > the newly introduced time zone stays at the same offset (-03) on/after > 2025-04-06: > > jshell> > ZoneId.of("America/Coyhaique").getRules().getValidOffsets(Loc

Re: RFR: 8346230: [perf] scalability issue for the specjvm2008::xml.transform workload [v4]

2025-03-25 Thread Joe Wang
On Fri, 14 Mar 2025 01:28:34 GMT, Vladimir Ivanov wrote: >> The HashMap for caching was deleted. Now it use only ThreadLocal variable >> without synchronization. >> According to the specjvm2008::xml.transform workload the performance for low >> threads counts was not affected and improved for h

Re: RFR: 8350704: Create tests to ensure the failure behavior of core reflection APIs [v2]

2025-03-24 Thread Joe Darcy
On Thu, 27 Feb 2025 17:41:48 GMT, Chen Liang wrote: >> Core reflection's generic signature parsing system is used for many aspects, >> including annotations and enclosing methods, yet it is under-tested. It is >> better for us to set up tests to ensure that sensitive error behaviors of >> core

Re: RFR: 8352628: Refine Grapheme test

2025-03-21 Thread Joe Wang
On Fri, 21 Mar 2025 20:17:31 GMT, Naoto Sato wrote: > Refining regex tests for Grapheme break so that every test case will run even > with some failing ones. Marked as reviewed by joehw (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24168#pullrequestreview-2707275607

Re: RFR: 8346948: Update CLDR to Version 47.0 [v2]

2025-03-20 Thread Joe Wang
On Wed, 19 Mar 2025 17:48:20 GMT, Naoto Sato wrote: >> Upgrading the CLDR to version 47.0. A corresponding CSR has also been >> drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Copyright year/bugid update Marked as

Integrated: 8351969: Add Public Identifiers to the JDK built-in Catalog

2025-03-19 Thread Joe Wang
On Thu, 13 Mar 2025 19:01:03 GMT, Joe Wang wrote: > Add public identifiers to the JDK built-in Catalog; Replace the incorrect > Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct > Schema 1.0 DTDs. The JDK built-in Catalog contains Schema 1.0 files only.

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v3]

2025-03-19 Thread Joe Wang
On Wed, 19 Mar 2025 00:43:28 GMT, Joe Wang wrote: >> Add public identifiers to the JDK built-in Catalog; Replace the incorrect >> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct >> Schema 1.0 DTDs. The JDK built-in Catalog contains Schema 1.0 file

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v3]

2025-03-18 Thread Joe Wang
LSchema.dtd and datatypes.dtd, were > removed and replaced with those of Schema 1.0. These files were downloaded > from w3.org without modification. The file names were unfortunately the same, > which (with the Diffs) made it look like they were modified though they were > not. Joe Wang h

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-18 Thread Joe Wang
On Tue, 18 Mar 2025 19:05:32 GMT, Roger Riggs wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update the test: change variables and etc. > > test/jaxp/javax/xml/jaxp/unittest/common/jdkca

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-18 Thread Joe Wang
On Tue, 18 Mar 2025 18:26:09 GMT, Roger Riggs wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update the test: change variables and etc. > > src/java.xml/share/classes/jdk/xml/intern

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-18 Thread Joe Wang
On Tue, 18 Mar 2025 18:50:24 GMT, Roger Riggs wrote: > The XMLSchema.dtd changes the referenced version from the 2009 version to the > 2001 version. Is that intentional. Yes. Note the Public Identifier: "-//W3C//DTD XSD 1.1//EN" vs "-//W3C//DTD XMLSCHEMA 200102//EN" at line 2. The 2009 version

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-15 Thread Joe Wang
> Add public identifiers to the JDK built-in Catalog; Replace the incorrect > Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct > Shema 1.0 DTDs. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: u

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog

2025-03-14 Thread Joe Wang
On Thu, 13 Mar 2025 19:01:03 GMT, Joe Wang wrote: > Add public identifiers to the JDK built-in Catalog; Replace the incorrect > Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct > Shema 1.0 DTDs. Thanks for review. Updated the test. - PR Comme

RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog

2025-03-13 Thread Joe Wang
Add public identifiers to the JDK built-in Catalog; Replace the incorrect Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct Shema 1.0 DTDs. - Commit messages: - 8351969: Add Public Identifiers to the JDK built-in Catalog Changes: https://git.openjdk.org/

Re: RFR: 8351344: Avoid explicit Objects.requireNonNull in String.join

2025-03-06 Thread Joe Darcy
On Thu, 6 Mar 2025 20:01:47 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/java/lang/String.java line 3649: >> >>> 3647: Iterable elements) { >>> 3648: Objects.requireNonNull(delimiter); >>> 3649: Objects.requireNonNull(elements); >> >> Hello Andrey, I ha

Re: RFR: 8350460: org.openjdk.bench.vm.floatingpoint.DremFrem JMH fails with -ea

2025-03-05 Thread Joe Darcy
On Wed, 5 Mar 2025 15:16:03 GMT, Eric Caspole wrote: > The normal SQE process runs all the repo JMH with -ea to get the last bit of > extra testing. This DremFrem JMH contained some asserts that would always > fire on the correct answer, disturbing this normal SQE process. I removed a > lot mo

Re: adding Xalan's XSL 3 implementation within jdk

2025-03-03 Thread Joe Wang
On 3/1/25 10:19 PM, Mukul Gandhi wrote: Hi Joe,     Thanks for nice thoughts. On Fri, 28 Feb, 2025, 00:06 Joe Wang, wrote: What's your assessment on the readiness for a formal release (or how much additional work is needed)? What are the conformance test results? The link

Integrated: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA

2025-03-03 Thread Joe Wang
On Fri, 28 Feb 2025 17:42:24 GMT, Joe Wang wrote: > Fix handleCharacters by adding a guard to zero length and letting the rest of > the process continue (e.g. closing tags and etc). This pull request has now been integrated. Changeset: 96613cc5 Author: Joe Wang URL:

Re: RFR: 8343478: Remove unnecessary @SuppressWarnings annotations (core-libs) [v12]

2025-03-03 Thread Joe Darcy
On Sat, 15 Feb 2025 21:27:56 GMT, Archie Cobbs wrote: >> Please review this patch which removes unnecessary `@SuppressWarnings` >> annotations. > > Archie Cobbs has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 22 commits: > > - Me

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA [v2]

2025-03-03 Thread Joe Wang
On Mon, 3 Mar 2025 18:01:48 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove commented section > > test/jaxp/javax/xml/jaxp/unittest/validation/Validatio

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA [v3]

2025-03-03 Thread Joe Wang
> Fix handleCharacters by adding a guard to zero length and letting the rest of > the process continue (e.g. closing tags and etc). Joe Wang has updated the pull request incrementally with one additional commit since the last revision: improve the javadoc for the test - C

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA

2025-03-01 Thread Joe Wang
X.java > line 286: > >> 284: if (textLength > 0) { >> 285: staxStreamReader.getTextCharacters(0, chars, 0, textLength); >> 286: } > > Hi Joe, > The comment above this piece reads: > > // workaround for bugid 5046319 - sw

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA [v2]

2025-02-28 Thread Joe Wang
On Fri, 28 Feb 2025 23:02:28 GMT, Naoto Sato wrote: >> Hi Naoto, >> >> Yes, I did look through that code and bug 5046319. Unfortunately, it >> happened when JAXP was standalone, the history of the change was lost. >> The variable "buf" seems to be an instance variable that serves to cache the

Re: RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA [v2]

2025-02-28 Thread Joe Wang
> Fix handleCharacters by adding a guard to zero length and letting the rest of > the process continue (e.g. closing tags and etc). Joe Wang has updated the pull request incrementally with one additional commit since the last revision: remove commented section - C

RFR: 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA

2025-02-28 Thread Joe Wang
Fix handleCharacters by adding a guard to zero length and letting the rest of the process continue (e.g. closing tags and etc). - Commit messages: - 8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA Changes: https://git.openjdk.org/jdk/pull/23847/files Webrev: https

Re: adding Xalan's XSL 3 implementation within jdk

2025-02-27 Thread Joe Wang
opers? Thanks, Joe On 2/26/25 7:59 AM, Mukul Gandhi wrote: Hi Alan, I've just seen this mail from you. Apologies for a delayed response. My mail box has had few issues due to the volume of mails that I get from mailing lists. On Sun, Feb 2, 2025 at 9:38 PM Alan Bateman wrote:

Re: RFR: 8345213: JVM Prefers /etc/timezone Over /etc/localtime on Debian 12

2025-02-24 Thread Joe Wang
On Mon, 24 Feb 2025 19:46:52 GMT, Naoto Sato wrote: > Removing the support for /etc/timezone file that is Debian distro specific. > The file is no longer considered authoritative > (https://wiki.debian.org/TimeZoneChanges#Check_Configured_Timezone), and in > fact, it is now out of sync as the

Re: RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd [v2]

2025-02-21 Thread Joe Wang
On Fri, 21 Feb 2025 01:38:34 GMT, SendaoYan wrote: >> Hi all, >> >> Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes >> unexpectedly when missing the depentdent file >> test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a >> NULL check after cal

Re: RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd

2025-02-20 Thread Joe Wang
On Fri, 14 Feb 2025 07:44:26 GMT, SendaoYan wrote: > Hi all, > > Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes > unexpectedly when missing the depentdent file > test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a > NULL check after call `get

Re: RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd

2025-02-19 Thread Joe Wang
On Fri, 14 Feb 2025 07:44:26 GMT, SendaoYan wrote: > Hi all, > > Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes > unexpectedly when missing the depentdent file > test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a > NULL check after call `get

Integrated: 8349699: XSL transform fails with certain UTF-8 characters on 1024 byte boundaries

2025-02-19 Thread Joe Wang
On Fri, 14 Feb 2025 00:56:03 GMT, Joe Wang wrote: > Fix an edge case in the patch for JDK-8207760. This pull request has now been integrated. Changeset: 4e60c2d9 Author: Joe Wang URL: https://git.openjdk.org/jdk/commit/4e60c2d937fca8170b356f36e72b271104130c40 Stats: 127 lines

Re: RFR: 8349699: XSL transform fails with certain UTF-8 characters on 1024 byte boundaries [v3]

2025-02-18 Thread Joe Wang
> Fix an edge case in the patch for JDK-8207760. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: add tests verifying invalid sequence; also add tests to verify cases where the pairs are at the edges or anywhere in the t

Re: RFR: 8349699: XSL transform fails with certain UTF-8 characters on 1024 byte boundaries [v2]

2025-02-18 Thread Joe Wang
On Fri, 14 Feb 2025 19:55:05 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> un-needed property removed > > test/jaxp/javax/xml/jaxp/unittest/transform/JDK8207760.java l

Re: RFR: 8349699: XSL transform fails with certain UTF-8 characters on 1024 byte boundaries [v2]

2025-02-14 Thread Joe Wang
> Fix an edge case in the patch for JDK-8207760. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: un-needed property removed - Changes: - all: https://git.openjdk.org/jdk/pull/23623/files - new: https://git.openjdk.

Re: RFR: 8349699: XSL transform fails with certain UTF-8 characters on 1024 byte boundaries [v2]

2025-02-14 Thread Joe Wang
On Fri, 14 Feb 2025 18:25:30 GMT, Lance Andersen wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> un-needed property removed > > test/jaxp/javax/xml/jaxp/unittest/transform/JDK82

Re: RFR: 8349699: XSL transform fails with certain UTF-8 characters on 1024 byte boundaries

2025-02-14 Thread Joe Wang
On Fri, 14 Feb 2025 00:56:03 GMT, Joe Wang wrote: > Fix an edge case in the patch for JDK-8207760. Hello Skara (hopefully this will trigger the notification email). - PR Comment: https://git.openjdk.org/jdk/pull/23623#issuecomment-2659974504

Re: RFR: 8341402: BigDecimal's square root optimization [v31]

2025-02-13 Thread Joe Darcy
On Mon, 10 Feb 2025 09:17:51 GMT, Per Minborg wrote: > This PR seems to be targeting performance, yet no benchmarks are provided > comparing the current vs. proposed branch with respect to performance. We > need to understand the upside of the proposed changes. At my request, reimplementing Bi

Re: RFR: 8349873: StackOverflowError after JDK-8342550 if -Duser.timezone= is set to a deprecated zone id [v2]

2025-02-13 Thread Joe Wang
On Wed, 12 Feb 2025 23:07:26 GMT, Naoto Sato wrote: >> Fixing the regression caused by the JDK-8342550 fix. Since the logging >> facility depends on TimeZone class, it should not use the logging facility. >> Replacing the logging with simple System.err.printf() will fix the issue. > > Naoto Sat

Re: RFR: 8349873: StackOverflowError after JDK-8342550 if -Duser.timezone= is set to a deprecated zone id

2025-02-12 Thread Joe Wang
On Wed, 12 Feb 2025 19:35:18 GMT, Naoto Sato wrote: > Fixing the regression caused by the JDK-8342550 fix. Since the logging > facility depends on TimeZone class, it should not use the logging facility. > Replacing the logging with simple System.err.printf() will fix the issue. Marked as revie

Re: RFR: 8344925: translet-name ignored, when package-name is also set via TransformerFactory.setAttribute

2025-02-07 Thread Joe Wang
On Thu, 28 Nov 2024 01:09:47 GMT, Zheng Feng wrote: > …String) > > This bug seems from the improper handling of package and class name > initialization in `XSLTC` since there is a default value of `_packageName` > with `die.verwandlung`. This fix is just adjusting to call `setPackageName` >

Integrated: 8327378: XMLStreamReader throws EOFException instead of XMLStreamException

2025-02-07 Thread Joe Wang
On Fri, 7 Feb 2025 20:03:21 GMT, Joe Wang wrote: > Fix an error handling where the XMLStreamReader impl throws EOFException > instead of XMLStreamException as defined. This pull request has now been integrated. Changeset: 5395ffa0 Author: Joe Wang URL: https://git.openjdk.o

Re: RFR: 8327378: XMLStreamReader throws EOFException instead of XMLStreamException

2025-02-07 Thread Joe Wang
On Fri, 7 Feb 2025 20:03:21 GMT, Joe Wang wrote: > Fix an error handling where the XMLStreamReader impl throws EOFException > instead of XMLStreamException as defined. RN added. Thanks all! - PR Comment: https://git.openjdk.org/jdk/pull/23524#issuecomment-267199

RFR: 8327378: XMLStreamReader throws EOFException instead of XMLStreamException

2025-02-07 Thread Joe Wang
Fix an error handling where the XMLStreamReader impl throws EOFException instead of XMLStreamException as defined. - Commit messages: - 8327378: XMLStreamReader throws EOFException instead of XMLStreamException Changes: https://git.openjdk.org/jdk/pull/23524/files Webrev: https:/

Integrated: 8344925: translet-name ignored when package-name is also set

2025-02-06 Thread Joe Wang
On Tue, 4 Feb 2025 18:30:34 GMT, Joe Wang wrote: > Fix an issue where the translet-name is incorrectly set when the package-name > is also specified. This pull request has now been integrated. Changeset: 3989a199 Author: Joe Wang URL: https://git.openjdk.org/jdk/

Re: RFR: 8344925: translet-name ignored when package-name is also set [v2]

2025-02-06 Thread Joe Wang
> Fix an issue where the translet-name is incorrectly set when the package-name > is also specified. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: update test - Changes: - all: https://git.openjdk.org/jdk/pull

Re: RFR: 8344925: translet-name ignored when package-name is also set [v2]

2025-02-06 Thread Joe Wang
On Thu, 6 Feb 2025 17:58:08 GMT, Severin Gehwolf wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update test > > test/jaxp/javax/xml/jaxp/unittest/transform/PropertiesTest.java line 94

Re: RFR: 8344925: translet-name ignored when package-name is also set [v2]

2025-02-06 Thread Joe Wang
On Thu, 6 Feb 2025 18:04:47 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update test > > test/jaxp/javax/xml/jaxp/libs/jaxp/library/JUnitTestUtil.java line 33: >

Re: RFR: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing

2025-02-05 Thread Joe Darcy
On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote: > This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. > > JDK-8348190: Framework for tracing makefile inclusion and parsing > > The above issue caused problems in the Oracle closed builds and so needs to > be backed out until that

Re: RFR: 8344925: translet-name ignored when package-name is also set

2025-02-05 Thread Joe Wang
On Wed, 5 Feb 2025 10:57:14 GMT, Severin Gehwolf wrote: > > @JoeWang-Java Have you seen https://git.openjdk.org/jdk/pull/22425? > > Just mentioning since it looks like a duplicate proposal. Indeed, I missed that. The right procedure to take over an issue is to ask the person assigned to the bu

Re: RFR: 8344925: translet-name ignored, when package-name is also set via TransformerFactory.setAttribute

2025-02-05 Thread Joe Wang
On Thu, 28 Nov 2024 01:09:47 GMT, Zheng Feng wrote: > …String) > > This bug seems from the improper handling of package and class name > initialization in `XSLTC` since there is a default value of `_packageName` > with `die.verwandlung`. This fix is just adjusting to call `setPackageName` >

Re: RFR: 8315585: Optimization for decimal to string [v4]

2025-02-04 Thread Joe Darcy
On Sat, 1 Feb 2025 08:42:32 GMT, Shaojin Wen wrote: >> Continue to complete PR #16006 and PR #21593 to improve BigDecimal::toString >> and BigDecimal::toPlainString performance and reduce duplicate code > > Shaojin Wen has updated the pull request with a new target base due to a > merge or a re

RFR: 8344925: translet-name ignored when package-name is also set

2025-02-04 Thread Joe Wang
Fix an issue where the translet-name is incorrectly set when the package-name is also specified. - Commit messages: - update copyright - 8344925: translet-name ignored when package-name is also set Changes: https://git.openjdk.org/jdk/pull/23446/files Webrev: https://webrevs.ope

Re: RFR: 8301875: java.util.TimeZone.getSystemTimeZoneID uses C library default file mode

2025-01-29 Thread Joe Wang
On Wed, 29 Jan 2025 20:42:30 GMT, Naoto Sato wrote: > Force opening "tzmappings" file in text mode. Confirmed the fix with customer > provided test case. Also replaced the file open function with the safer one. Marked as reviewed by joehw (Reviewer). - PR Review: https://git.openj

Re: RFR: 8342465: Improve API documentation for java.lang.classfile [v2]

2025-01-24 Thread Joe Darcy
On Fri, 24 Jan 2025 22:42:27 GMT, Chen Liang wrote: >> This is the last piece in the API documentation improvement of the >> Class-File API. >> >> This includes general documentation about transforms, models (and >> traversals), options, constants, and CodeBuilder factories. In particular, >

Re: RFR: 8343609: Broken links in java.xml [v3]

2025-01-23 Thread Joe Wang
On Thu, 23 Jan 2025 00:46:07 GMT, Joe Wang wrote: >> Fix broken links in java.xml: >> >> Catalog: contacted Oasis. The standard page >> (https://www.oasis-open.org/standard/xmlcatalogs/) now links to the PDF >> version. That is what I'm using now, replacing

Integrated: 8343609: Broken links in java.xml

2025-01-23 Thread Joe Wang
On Wed, 22 Jan 2025 18:55:10 GMT, Joe Wang wrote: > Fix broken links in java.xml: > > Catalog: contacted Oasis. The standard page > (https://www.oasis-open.org/standard/xmlcatalogs/) now links to the PDF > version. That is what I'm using now, replacing the html pages.

Re: RFR: 8343609: Broken links in java.xml [v2]

2025-01-22 Thread Joe Wang
On Thu, 23 Jan 2025 00:35:25 GMT, Joe Wang wrote: >> Fix broken links in java.xml: >> >> Catalog: contacted Oasis. The standard page >> (https://www.oasis-open.org/standard/xmlcatalogs/) now links to the PDF >> version. That is what I'm using now, replacing

Re: RFR: 8343609: Broken links in java.xml [v3]

2025-01-22 Thread Joe Wang
thin the browser rather than downloaded as the html > version did. > > QName: rewrote the javadocs. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: s/javax.xml.XMLConstants/XMLConstants - Changes: - all: https:/

  1   2   3   4   5   6   7   8   9   10   >