On Fri, 18 Apr 2025 20:06:01 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> Joe Wang has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   remove unused variable pName; remove unused imports
>
> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/PropertyManager.java
>  line 261:
> 
>> 259:                 //fall back to the existing property manager
>> 260:                 supportedProps.put(property, value);
>> 261:             }
> 
> `JdkProperty` and `FeaturePropertyBase` can be removed from `import`. Applies 
> to other sources as well

Removed unused imports in classes affected in this patch. Thanks.

> src/java.xml/share/classes/jdk/xml/internal/JdkXmlUtils.java line 112:
> 
>> 110:     public static boolean setProperty(XMLSecurityManager xsm, 
>> XMLSecurityPropertyManager xspm,
>> 111:             String property, Object value) {
>> 112:         String pName;
> 
> `pName` is not needed

Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24732#discussion_r2051139824
PR Review Comment: https://git.openjdk.org/jdk/pull/24732#discussion_r2051139530

Reply via email to