On Mon, 24 Mar 2025 21:29:29 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Core reflection's generic signature parsing system is used for many aspects, >> including annotations and enclosing methods, yet it is under-tested. It is >> better for us to set up tests to ensure that sensitive error behaviors of >> core reflection remain the same across implementation updates, such as >> #19281. >> >> This patch also includes a JUnit converted version of >> https://github.com/openjdk/jdk/pull/22581#issuecomment-2521703511 test >> checking behavior around annotations with duplicate interfaces. Interesting >> that this causes failure in class, field, and methods (constructors), but >> not in parameters. >> >> Testing: jdk-tier 1, jdk-tier 2 > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains four additional commits since > the last revision: > > - Forgot to commit the updated tests > - Merge branch 'master' of https://github.com/openjdk/jdk into > fix/reflect-behavior-tests > - Remove useless directive > - 8350704: Create tests to ensure the failure behavior of core reflection > APIs Marked as reviewed by darcy (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/23788#pullrequestreview-2734106235
