On Tue, 22 Apr 2025 11:06:17 GMT, Shaojin Wen wrote:
> The current Throwable::printStackTrace implementation uses three inner
> classes PrintStreamOrWriter/WrappedPrintStream/WrappedPrintWriter. We can
> introduce a static method println to replace these three embedded classes.
This pull reque
kludge_c++11.h was introduced to work around older C++ versions not having
access to C++ utilities like std::unique_ptr. Since we are already on C++14
(And hopefully will get C++17 soon) this workaround can be removed from
jpackage code.
-
Commit messages:
- Include memory header
On Fri, 25 Apr 2025 01:36:50 GMT, Shaojin Wen wrote:
> In the Throwable::printStackTrace method, StringBuilder is created multiple
> times to build String. By sharing StringBuilder to build String, object
> allocation and copying are reduced.
>
> In the scenario without suppressed and ourCause
On Fri, 25 Apr 2025 01:36:50 GMT, Shaojin Wen wrote:
> In the Throwable::printStackTrace method, StringBuilder is created multiple
> times to build String. By sharing StringBuilder to build String, object
> allocation and copying are reduced.
>
> In the scenario without suppressed and ourCause
In the Throwable::printStackTrace method, StringBuilder is created multiple
times to build String. By sharing StringBuilder to build String, object
allocation and copying are reduced.
In the scenario without suppressed and ourCause, unused IdentityHashMap is not
created.
Through these optimiza
On Mon, 31 Mar 2025 18:30:37 GMT, Liam Miller-Cushon wrote:
>> This change overrides mutator methods in the implementation returned by
>> `Map.of().entrySet()` to throw `UnsupportedOperationException`.
>
> Liam Miller-Cushon has updated the pull request with a new target base due to
> a merge o
On Fri, 25 Apr 2025 03:16:09 GMT, Chen Liang wrote:
>> In the Throwable::printStackTrace method, StringBuilder is created multiple
>> times to build String. By sharing StringBuilder to build String, object
>> allocation and copying are reduced.
>>
>> In the scenario without suppressed and ourC
On Fri, 25 Apr 2025 23:37:13 GMT, Brent Christian wrote:
> The newly-added `WhiteBox.waitForReferenceProcessing()` (see
> [8305186](https://bugs.openjdk.org/browse/JDK-8305186)) always fails with
> assertions enabled.
> I've updated the assertion, and also added the test I used locally to test
On Fri, 25 Apr 2025 14:49:37 GMT, Aleksey Shipilev wrote:
> CDS cannot handle large number of classes, because `ClassLoader` data
> structures get too large for CDS archival. The new test captures such an
> occasion. We do `clear()`-s, but that is not enough to trim the backing
> storages for
On Fri, 25 Apr 2025 20:30:15 GMT, Chen Liang wrote:
> Currently, we are not generating all possible field lambda forms.
>
> Field lambda forms have these dimensions:
> - get/set
> - instance/static/static+class init barrier
> - plain/volatile
> - 8 primitive types, no-cast object, object with ca
On Fri, 25 Apr 2025 09:41:21 GMT, Jatin Bhateja wrote:
>> It does look attractive, but macro expansion-based solution requires JVM to
>> internalize such operations and their properties.
>>
>> IMO a higher-level solution based on more generic JVM primitives would
>> enable libraries to proper
On Fri, 25 Apr 2025 05:26:35 GMT, Vladimir Ivanov wrote:
>> Migrate Vector API math library (SVML and SLEEF) linkage from native code
>> (in JVM) to Java FFM API.
>>
>> Since FFM API doesn't support vector calling conventions yet, migration
>> affects only symbol lookup for now. But it still e
Currently, we are not generating all possible field lambda forms.
Field lambda forms have these dimensions:
- get/set
- instance/static/static+class init barrier
- plain/volatile
- 8 primitive types, no-cast object, object with cast
Bringing to a total of 2 × 3 × 2 × 10 = 120 lambda forms.
Previ
> I propose some cleanups to `FinalizerHistogramTest.java` to hopefully clear
> up the intermittent failures:
>
> * run with `othervm`: this test blocks the (global) finalizer thread, and
> also requires the (global) finalizer thread to enter the test's `finalize()`
> method
> * The test uses `
On Fri, 4 Apr 2025 22:52:24 GMT, Vladimir Ivanov wrote:
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in
> JVM) to Java FFM API.
>
> Since FFM API doesn't support vector calling conventions yet, migration
> affects only symbol lookup for now. But it still enables
On Fri, 25 Apr 2025 14:49:37 GMT, Aleksey Shipilev wrote:
> CDS cannot handle large number of classes, because `ClassLoader` data
> structures get too large for CDS archival. The new test captures such an
> occasion. We do `clear()`-s, but that is not enough to trim the backing
> storages for
On Fri, 25 Apr 2025 19:41:54 GMT, Naoto Sato wrote:
>> Stemmed from this PR: https://github.com/openjdk/jdk/pull/24838
>> After JEP 400, `file.encoding` is always UTF-8, so the test was never run.
>> Using `native.encoding` is appropriate so that the intention of the initial
>> test will hold.
On Fri, 25 Apr 2025 19:37:17 GMT, Naoto Sato wrote:
>> test/jdk/java/io/pathNames/win32/SJIS.java line 32:
>>
>>> 30: */
>>> 31:
>>> 32: import java.io.*;
>>
>> Maybe don't use wildcard import?
>
> Fixed.
Thanks!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24881#discus
The goal of this PR is to implement an x86_64 intrinsic for
java.lang.Math.cbrt() using libm.
The results of all tests posted below were captured with an [Intel® Xeon
6761P](https://www.intel.com/content/www/us/en/products/sku/241842/intel-xeon-6761p-processor-336m-cache-2-50-ghz/specifications.
On Fri, 18 Apr 2025 01:41:36 GMT, Ioi Lam wrote:
>>> Do we have a test case where `--add-opens` is used both at dump time and
>>> run time? That will verify that `--add-opens` at dump time is correctly
>>> processed.
>>>
>>
>> Yes, the new test `AddopensOption.java` uses the `--add-opens` bot
On Fri, 25 Apr 2025 19:00:43 GMT, Brian Burkhalter wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Expand wild card imports
>
> test/jdk/java/io/pathNames/win32/SJIS.java line 32:
>
>> 30: */
>> 31:
>> 32: import j
On Thu, 24 Apr 2025 16:59:45 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Clien
On Fri, 25 Apr 2025 14:49:37 GMT, Aleksey Shipilev wrote:
> CDS cannot handle large number of classes, because `ClassLoader` data
> structures get too large for CDS archival. The new test captures such an
> occasion. We do `clear()`-s, but that is not enough to trim the backing
> storages for
On Fri, 25 Apr 2025 05:56:15 GMT, Ioi Lam wrote:
>> This PR contains 2 parts
>>
>> - Upstream of Soft/Weak Reference support authored by @macarte from [the
>> Leyden
>> repo](https://github.com/openjdk/leyden/commit/4ca75d156519596e23abc8a312496b7c2f0e0ca5)
>> - New C++ class `AOTReferenceObjS
> Stemmed from this PR: https://github.com/openjdk/jdk/pull/24838
> After JEP 400, `file.encoding` is always UTF-8, so the test was never run.
> Using `native.encoding` is appropriate so that the intention of the initial
> test will hold. Tested on an English Windows in which the system locale is
On Thu, 24 Apr 2025 16:59:45 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Clien
On Thu, 24 Apr 2025 16:59:45 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Clien
On Fri, 25 Apr 2025 11:31:50 GMT, Jaikiran Pai wrote:
> Hello Jiangli, if I understand this change correctly, then this is forcing a
> non-JNI library to be a JNI library for it to work on static JDK. Is that a
> requirement for static JDK builds? Or is it just a convenient way to use
> existi
On Thu, 24 Apr 2025 16:59:45 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Clien
On Fri, 25 Apr 2025 17:02:30 GMT, Naoto Sato wrote:
> Stemmed from this PR: https://github.com/openjdk/jdk/pull/24838
> After JEP 400, `file.encoding` is always UTF-8, so the test was never run.
> Using `native.encoding` is appropriate so that the intention of the initial
> test will hold. Test
On Fri, 25 Apr 2025 09:57:38 GMT, Gautham Krishnan wrote:
> MET timezone entry in TimeZoneNames.java and TimeZoneNames_*.java needs to be
> updated as MET is alias to Europe/Brussels as per 2024b tzdata changes.
>
> Also Bug4848242.java needs to be removed as the test expects all euro locale
>
On Fri, 25 Apr 2025 05:26:35 GMT, Vladimir Ivanov wrote:
>> Migrate Vector API math library (SVML and SLEEF) linkage from native code
>> (in JVM) to Java FFM API.
>>
>> Since FFM API doesn't support vector calling conventions yet, migration
>> affects only symbol lookup for now. But it still e
On Fri, 25 Apr 2025 16:33:59 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/MacPathTest.java line 28:
>>
>>> 26: * @summary Tests paths on macOS
>>> 27: * @requires (os.family == "mac")
>>> 28: */
>>
>> The missing `@test` on this looked odd, since that would mean that this test
>> w
> The ClassFile API promotes usage of constant nominal descriptors over literal
> strings. However, for `class` file parsing, currently the efficient way to
> check if a constant pool entry matches a desired descriptor is via unrolling
> them back to strings. However, string unrolling is ugly, a
On Tue, 8 Apr 2025 20:20:56 GMT, Brent Christian wrote:
> Certain specific types of tests involving GC and reference processing need to
> account for the delay between a GC completing (during which the GC clears a
> Reference), and the Reference being added to its associated queue. At
> presen
Stemmed from this PR: https://github.com/openjdk/jdk/pull/24838
After JEP 400, `file.encoding` is always UTF-8, so the test was never run.
Using `native.encoding` is appropriate so that the intention of the initial
test will hold. Tested on an English Windows in which the system locale is set
to
> Use the `@requires` tag instead of obtaining the operating system name from
> the `os.name` property and then exiting if the test is not run on that
> operating system.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8355444:
On Wed, 23 Apr 2025 00:21:05 GMT, Chen Liang wrote:
>> The ClassFile API promotes usage of constant nominal descriptors over
>> literal strings. However, for `class` file parsing, currently the efficient
>> way to check if a constant pool entry matches a desired descriptor is via
>> unrolling
On Fri, 25 Apr 2025 07:19:32 GMT, Jaikiran Pai wrote:
>> Use the `@requires` tag instead of obtaining the operating system name from
>> the `os.name` property and then exiting if the test is not run on that
>> operating system.
>
> test/jdk/java/io/File/MacPathTest.java line 28:
>
>> 26: * @s
On Tue, 22 Apr 2025 23:55:54 GMT, Chen Liang wrote:
> In the future value objects JEP, class files must have one of ACC_IDENTITY
> (now ACC_SUPER), ACC_ABSTRACT, and ACC_FINAL bits set, otherwise they are
> rejected. The current default flag has none of these bits set, meaning that
> it will n
On Tue, 22 Apr 2025 23:55:54 GMT, Chen Liang wrote:
> In the future value objects JEP, class files must have one of ACC_IDENTITY
> (now ACC_SUPER), ACC_ABSTRACT, and ACC_FINAL bits set, otherwise they are
> rejected. The current default flag has none of these bits set, meaning that
> it will n
On Thu, 17 Apr 2025 18:59:33 GMT, Stuart Marks wrote:
> * Windows and Unix: set sprops.stdin_encoding if connected to a console
> * Add specs for stdin.encoding
> * Adjust specs to change "undefined" to "unspecified"
> * Rewrite System.in spec to refer to new property and to clarify usage with
>
On Wed, 16 Apr 2025 18:21:41 GMT, Calvin Cheung wrote:
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
On Fri, 25 Apr 2025 10:18:37 GMT, Mark Sheppard wrote:
> When running test locally that's fine, this is easily seen in the jtreg
> report, but when run in the test frameworks CI pipeline, this "not run "
> visibility is obscured. Thus when doing test run audit of a jobs, requires a
> bit more
On Thu, 24 Apr 2025 17:22:15 GMT, Naoto Sato wrote:
>> Sounds like a different issue needs to be filed.
>
> Yeah, that sounds better.
See https://bugs.openjdk.org/browse/JDK-838
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24838#discussion_r2060508271
On Fri, 25 Apr 2025 14:49:37 GMT, Aleksey Shipilev wrote:
> CDS cannot handle large number of classes, because `ClassLoader` data
> structures get too large for CDS archival. The new test captures such an
> occasion. We do `clear()`-s, but that is not enough to trim the backing
> storages for
On Tue, 22 Apr 2025 23:55:54 GMT, Chen Liang wrote:
> In the future value objects JEP, class files must have one of ACC_IDENTITY
> (now ACC_SUPER), ACC_ABSTRACT, and ACC_FINAL bits set, otherwise they are
> rejected. The current default flag has none of these bits set, meaning that
> it will n
On Tue, 22 Apr 2025 23:55:54 GMT, Chen Liang wrote:
> In the future value objects JEP, class files must have one of ACC_IDENTITY
> (now ACC_SUPER), ACC_ABSTRACT, and ACC_FINAL bits set, otherwise they are
> rejected. The current default flag has none of these bits set, meaning that
> it will n
On Wed, 23 Apr 2025 00:21:05 GMT, Chen Liang wrote:
>> The ClassFile API promotes usage of constant nominal descriptors over
>> literal strings. However, for `class` file parsing, currently the efficient
>> way to check if a constant pool entry matches a desired descriptor is via
>> unrolling
On Fri, 25 Apr 2025 07:54:03 GMT, Johannes Döbler wrote:
>>> @AlanBateman I have modified it to use interface + record. Is this what you
>>> want?
>>
>> I don't object to changing it to interface + record but it feels more like
>> needless code churn. I really disliked the next version that us
On Fri, 25 Apr 2025 14:21:55 GMT, Chen Liang wrote:
>> The record has fewer source lines but doesn't the generated record class
>> have a getter, toString(), hashCode() and equals(Object) which are not
>> needed here?
>> What about using a lock parameter and a method handle to pass in the
>> r
On Thu, 24 Apr 2025 10:37:59 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make public constuctor private
I think the design and the es
On Tue, 22 Apr 2025 23:55:54 GMT, Chen Liang wrote:
> In the future value objects JEP, class files must have one of ACC_IDENTITY
> (now ACC_SUPER), ACC_ABSTRACT, and ACC_FINAL bits set, otherwise they are
> rejected. The current default flag has none of these bits set, meaning that
> it will n
On Tue, 22 Apr 2025 23:55:54 GMT, Chen Liang wrote:
> In the future value objects JEP, class files must have one of ACC_IDENTITY
> (now ACC_SUPER), ACC_ABSTRACT, and ACC_FINAL bits set, otherwise they are
> rejected. The current default flag has none of these bits set, meaning that
> it will n
On Sun, 23 Mar 2025 09:28:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix an issue
>> `java.util.zip.ZipFile` which would cause failures when multiple instances
>> of `ZipFile` using non-UTF8 `Charset` were operating against the same
>> underlying
On Thu, 24 Apr 2025 17:36:29 GMT, Shaojin Wen wrote:
>> The current Throwable::printStackTrace implementation uses three inner
>> classes PrintStreamOrWriter/WrappedPrintStream/WrappedPrintWriter. We can
>> introduce a static method println to replace these three embedded classes.
>
> Shaojin W
On Sun, 23 Mar 2025 09:28:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix an issue
>> `java.util.zip.ZipFile` which would cause failures when multiple instances
>> of `ZipFile` using non-UTF8 `Charset` were operating against the same
>> underlying
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
On Sun, 23 Mar 2025 09:28:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix an issue
>> `java.util.zip.ZipFile` which would cause failures when multiple instances
>> of `ZipFile` using non-UTF8 `Charset` were operating against the same
>> underlying
On Fri, 18 Apr 2025 18:22:35 GMT, Brian Burkhalter wrote:
>>> From experimentation with C++ code is VS, it appears that
>>> `CreateDirectoryW` will create a directory with either a leading or
>>> trailing space in its name, whereas `createFileW` will create a file with a
>>> leading space in i
On Tue, 25 Mar 2025 14:20:24 GMT, Luca Kellermann wrote:
>>> Comments on visual noise and side effects in `toString`.
>>>
>>> `renderWrapped` is clever for a single stable value, but it makes for a
>>> very noisy display string, with confusing doubly-nested `[]`, for composite
>>> stable value
On Wed, 23 Apr 2025 00:56:18 GMT, Jiangli Zhou wrote:
>> Please review this PR that changes to use `NativeLibraries.loadLibrary()`
>> for loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>>
>> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
On Thu, 24 Apr 2025 10:37:59 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make public constuctor private
src/java.base/share/classes/j
On Thu, 24 Apr 2025 10:37:59 GMT, Per Minborg wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make public constuctor private
I've been through the API + i
On Thu, 24 Apr 2025 20:46:42 GMT, Brian Burkhalter wrote:
> Use the `@requires` tag instead of obtaining the operating system name from
> the `os.name` property and then exiting if the test is not run on that
> operating system.
test/jdk/java/io/File/MacPathTest.java
test/jdk/java/io/File/MaxP
On Thu, 24 Apr 2025 20:46:42 GMT, Brian Burkhalter wrote:
> Use the `@requires` tag instead of obtaining the operating system name from
> the `os.name` property and then exiting if the test is not run on that
> operating system.
a general comment on this approach of running tests selectively o
MET timezone entry in TimeZoneNames.java and TimeZoneNames_*.java needs to be
updated as MET is alias to Europe/Brussels as per 2024b tzdata changes.
Also Bug4848242.java needs to be removed as the test expects all euro locale
time zones should have the same short names.
-
Commit m
On Thu, 24 Apr 2025 08:57:14 GMT, erifan wrote:
>> erifan has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains two additional commits since
>> the la
On Thu, 24 Apr 2025 09:46:24 GMT, erifan wrote:
>> test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java line 38:
>>
>>> 36: * @summary test combining vector not operation with compare
>>> 37: * @modules jdk.incubator.vector
>>> 38: * @requires ((os.arch!="x86" & os.arch!="i386"
On Thu, 24 Apr 2025 23:03:09 GMT, Vladimir Ivanov wrote:
>> src/hotspot/share/opto/vectorIntrinsics.cpp line 563:
>>
>>> 561: debug_name =
>>> debug_name_oop->const_oop()->as_instance()->java_lang_String_str(buf,
>>> buflen);
>>> 562: }
>>> 563: Node* vcall = make_runtime_call(RC_VECTO
On Fri, 25 Apr 2025 07:06:05 GMT, Alan Bateman wrote:
>>> What should we replace it with? Do you have any suggestions?
>>
>> The wrapper classes were needed when there were was a mix of synchronized
>> and j.u.concurrent locks in use. With JEP 491 integrated it meant that the
>> java.io classe
On Fri, 25 Apr 2025 06:28:59 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make public constuctor private
>
> src/java.base/share/classes/java/lang/StableValue.java line 470:
>
>> 468: * @p
On Thu, 24 Apr 2025 09:37:07 GMT, erifan wrote:
>> src/hotspot/share/opto/vectornode.cpp line 2243:
>>
>>> 2241: in1 = in1->in(1);
>>> 2242: }
>>> 2243: if (in1->Opcode() != Op_VectorMaskCmp || in1->outcnt() > 1 ||
>>
>> Checks on outcnt on line 2243 and 2238 can be removed. Idealizatio
On Fri, 25 Apr 2025 09:11:43 GMT, Per Minborg wrote:
>> src/java.base/share/classes/java/lang/StableValue.java line 389:
>>
>>> 387: * Invocations of {@link #setOrThrow(Object)} form a total order of
>>> zero or more
>>> 388: * exceptional invocations followed by zero (if the contents were
>
On Thu, 24 Apr 2025 13:35:45 GMT, Luca Kellermann wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make public constuctor private
>
> src/java.base/share/classes/java/lang/StableValue.java line 389:
>
>> 387: * Inv
On Thu, 3 Apr 2025 01:19:18 GMT, Chen Liang wrote:
>> Seconded
>
> I personally think this is more of an implementation artifact for
> `StableValue::supplier` and doesn't merit its own API (as no other
> StableValue API utilizes the object monitor of a StableValue), but maybe we
> can adjust t
On Fri, 25 Apr 2025 07:57:53 GMT, Eirik Bjørsnøs wrote:
> @liach suggested to remove the wrapper classes and instead use a static
> method with `instanceof` checking. That would remove the need for both the
> interface and the wrapper classes which seems like a real improvement.
> @AlanBateman
On Thu, 24 Apr 2025 17:31:50 GMT, Severin Gehwolf wrote:
> Please review this fix to
> [JDK-8353185](https://bugs.openjdk.org/browse/JDK-8353185). The reading logic
> for the config file would erroneously use `scanner.nextLine()` when the
> current line to be added is in `line`. `line` is not
On Thu, 24 Apr 2025 17:31:50 GMT, Severin Gehwolf wrote:
> Please review this fix to
> [JDK-8353185](https://bugs.openjdk.org/browse/JDK-8353185). The reading logic
> for the config file would erroneously use `scanner.nextLine()` when the
> current line to be added is in `line`. `line` is not
On Thu, 24 Apr 2025 17:36:29 GMT, Shaojin Wen wrote:
>> The current Throwable::printStackTrace implementation uses three inner
>> classes PrintStreamOrWriter/WrappedPrintStream/WrappedPrintWriter. We can
>> introduce a static method println to replace these three embedded classes.
>
> Shaojin W
On Wed, 19 Feb 2025 09:22:09 GMT, Per Minborg wrote:
> This PR proposes to make all imports consistent in the FFM API tests and
> benchmarks.
>
> This is a follow-up PR from https://github.com/openjdk/jdk/pull/22827
>
> Passes tier1-3
test/jdk/java/foreign/TestFunctionDescriptor.java line 38:
On Thu, 9 Jan 2025 11:47:15 GMT, Per Minborg wrote:
>> This PR proposes to clean up all the imports in the FFM lib (excluding
>> tests).
>>
>> Passes tier1-tier3
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes th
On Thu, 24 Apr 2025 10:28:15 GMT, Andrew Haley wrote:
>> erifan has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains two additional commits since
>>
On Thu, 24 Apr 2025 09:39:58 GMT, erifan wrote:
>> src/hotspot/share/opto/vectornode.cpp line 2265:
>>
>>> 2263: vmcmp = new VectorMaskCastNode(phase->transform(vmcmp),
>>> vmcast_vt);
>>> 2264: }
>>> 2265: return vmcmp;
>>
>> It would be preferable if you could kindly re-factor the co
> This patch optimizes the following patterns:
> For integer types:
>
> (XorV (VectorMaskCmp src1 src2 cond) (Replicate -1))
> => (VectorMaskCmp src1 src2 ncond)
> (XorVMask (VectorMaskCmp src1 src2 cond) (MaskAll m1))
> => (VectorMaskCmp src1 src2 ncond)
>
> cond can be eq, ne, le, ge, l
On Thu, 24 Apr 2025 20:46:42 GMT, Brian Burkhalter wrote:
> Use the `@requires` tag instead of obtaining the operating system name from
> the `os.name` property and then exiting if the test is not run on that
> operating system.
test/jdk/java/io/File/MacPathTest.java line 28:
> 26: * @summar
On Wed, 23 Apr 2025 09:05:07 GMT, Alan Bateman wrote:
>>> Ugh, hopefully this will be replaced in the next iteration.
>>
>> What should we replace it with? Do you have any suggestions?
>
>> What should we replace it with? Do you have any suggestions?
>
> The wrapper classes were needed when the
87 matches
Mail list logo
