On Thu, 24 Apr 2025 16:59:45 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client >> API](https://bugs.openjdk.org/browse/JDK-8350588) >> >> This JEP proposes to enhance the HttpClient implementation to support HTTP/3. >> It adds a non-exposed / non-exported internal implementation of the QUIC >> protocol based on DatagramChannel and the SunJSSE SSLContext provider. > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 409 commits: > > - merge latest changes from master branch > - http3: add missing <p> separator to Http3DiscoveryMode.ALT_SVC API > documentation > - http3: improve documentation for Http3DiscoveryMode.ALT_SVC > - http3: Use AlgorithmConstraints and OCSP responses when validating server > certificate during QUIC TLS handshake > - http3: Artur's review - use SecurityUtils.removeFromDisabledTlsAlgs() in > test > - http3: minor improvement to log message > - http3: Artur's review - remove commented out code from test > - http3: Artur's review - make methods package private > - http3: qpack - allow 0 capacity when max capacity is 0 > - Remove flow control from stream limit comments > - ... and 399 more: https://git.openjdk.org/jdk/compare/1ec64811...4da61bbe src/java.base/share/classes/sun/security/ssl/X509TrustManagerImpl.java line 275: > 273: final X509Certificate[] trustedChain = v.validate(chain, null, > 274: responseList, constraints, authType); > 275: if (sslParameters != null && handshakeSession != null) { Looks like this `if` block is not needed: `sslParameters != null` condition is always `true`, and we should throw an exception in the beginning of the method if session is null. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2060782742
