On Fri, 25 Apr 2025 17:02:30 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Stemmed from this PR: https://github.com/openjdk/jdk/pull/24838 > After JEP 400, `file.encoding` is always UTF-8, so the test was never run. > Using `native.encoding` is appropriate so that the intention of the initial > test will hold. Tested on an English Windows in which the system locale is > set to `Japanese(Japan)`, and confirmed it succeeded without SkippedException. I don't have good knowledge of the encodings, but code-wise this looks fine. test/jdk/java/io/pathNames/win32/SJIS.java line 32: > 30: */ > 31: > 32: import java.io.*; Maybe don't use wildcard import? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24881#issuecomment-2831200780 PR Review Comment: https://git.openjdk.org/jdk/pull/24881#discussion_r2060750924
