On Thu, 24 Apr 2025 10:37:59 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make public constuctor private
I think the design and the essential implementation meets the "95% complete"
bar for preview features. There are some ceremony like toString and some other
details like null values, but they should not be serious enough for this to be
delivered for preview.
src/java.base/share/classes/java/util/ImmutableCollections.java line 1585:
> 1583:
> 1584: @jdk.internal.ValueBased
> 1585: final class StableMapEntrySet extends
> AbstractImmutableSet<Map.Entry<K, V>> {
One concern about the (non-static) inner classes is that we can't
stable-annotate the immediately enclosing instance - we might need general
trusting for java.util, but we need to ensure users aren't hacking collection
final fields first.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23972#pullrequestreview-2794371078
PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r2060378300
