On Wed, 19 Mar 2025 20:07:26 GMT, Roger Riggs wrote:
>> The current test program for the logging feature added in JDK-8301627 does
>> not fully check some important cases.
>>
>> Issue Details:
>> The test does not properly check cases where logging might not happen due to
>> different logging
On Wed, 23 Apr 2025 01:31:56 GMT, Shaojin Wen wrote:
>> The current Throwable::printStackTrace implementation uses three inner
>> classes PrintStreamOrWriter/WrappedPrintStream/WrappedPrintWriter. We can
>> introduce a static method println to replace these three embedded classes.
>
> Shaojin W
On 22/04/2025 14:28, Anton Rameykov wrote:
Alan, good day to you. I have a few questions. Could you please advise
me to forward my initial message to the net-dev mailing list? Sorry,
it's just my first time with the mailing model. And second question,
if the thread went to native code why Djdk.
On Thu, 31 Oct 2024 05:43:11 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Wed, 23 Apr 2025 00:23:57 GMT, Brent Christian wrote:
>> Certain specific types of tests involving GC and reference processing need
>> to account for the delay between a GC completing (during which the GC clears
>> a Reference), and the Reference being added to its associated queue. At
>> p
On Wed, 16 Apr 2025 12:07:45 GMT, Jan Lahoda wrote:
>> The `java.io.Console` has several backends: a simple on in `java.base`, a
>> more convenient one in `jdk.internal.le` (with line-reading based on JLine)
>> and one for JShell.
>>
>> The backend based on JLine is proving to be a somewhat pr
On Tue, 22 Apr 2025 03:35:03 GMT, Shaojin Wen wrote:
> This PR is to remove unused imports after PR #16425
This pull request has now been integrated.
Changeset: bc518a6c
Author:Shaojin Wen
URL:
https://git.openjdk.org/jdk/commit/bc518a6cbb9fadc47b00239b4d721c1c62dc5dad
Stats: 2
> Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest.
>
> If signing identity validation fails, jpackage outputs three messages
> constructed from the following string IDs: `error.cert.not.found`,
> `error.explicit-sign-no-cert`, and `error.explicit-sign-no-cert.advice`.
>
>
On Tue, 22 Apr 2025 21:48:16 GMT, Alexander Matveev
wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix whitespace
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java line 982:
>
>> 980:
On Thu, 17 Apr 2025 18:59:33 GMT, Stuart Marks wrote:
> * Windows and Unix: set sprops.stdin_encoding if connected to a console
> * Add specs for stdin.encoding
> * Adjust specs to change "undefined" to "unspecified"
> * Rewrite System.in spec to refer to new property and to clarify usage with
>
> As the title says, this is a simple refactoring that simplifies the code by
> using record.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
printStackTrace0
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24795/fi
> As the title says, this is a simple refactoring that simplifies the code by
> using record.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
bug fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24795/files
- n
On Tue, 22 Apr 2025 20:36:12 GMT, Jiangli Zhou wrote:
> I also added command line examples for building static-jdk and the current
> method for running jtreg tests on static-jdk.
Thank you, that will help me in future.
-
PR Comment: https://git.openjdk.org/jdk/pull/24704#issuecomm
On Wed, 16 Apr 2025 23:41:40 GMT, Jiangli Zhou wrote:
> Please review this simple test change that skips the test case loading using
> JDK `libzip.so` on static JDK in
> test/jdk/jdk/internal/loader/NativeLibraries/Main.java. AFAICT, the test case
> using `NativeLibrariesTest.LIB_NAME` (`libna
On Wed, 23 Apr 2025 00:58:08 GMT, Shaojin Wen wrote:
>> As the title says, this is a simple refactoring that simplifies the code by
>> using record.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> from @liach, Use static pi
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in
> JVM) to Java FFM API.
>
> Since FFM API doesn't support vector calling conventions yet, migration
> affects only symbol lookup for now. But it still enables significant
> simplifications on JVM side.
>
> The patc
> As the title says, this is a simple refactoring that simplifies the code by
> using record.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
from @liach, Use static pirntln method to replace WrappedStream and
WrappedPrintWriter
---
On Wed, 23 Apr 2025 00:24:55 GMT, Henry Jen wrote:
> Do we need this include? DEF_STATIC_JNI_OnLoad is defined by jni_util.h,
> which should include jni.h?
Removed, thanks!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24801#discussion_r2055090726
> Please review this PR that changes to use `NativeLibraries.loadLibrary()` for
> loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>
> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
> built-in library loading properly. On `static-jdk`, callin
On Fri, 18 Apr 2025 16:16:28 GMT, Jorn Vernee wrote:
>> Vladimir Ivanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 24 additional
>> commits
On Tue, 22 Apr 2025 14:46:21 GMT, Ludovic Henry wrote:
>> Vladimir Ivanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 24 additional
>> commi
On Tue, 22 Apr 2025 16:46:44 GMT, Hamlin Li wrote:
>> src/hotspot/share/runtime/abstract_vm_version.cpp line 349:
>>
>>> 347: assert(features_offset <= cpu_info_string_len, "");
>>> 348: if (features_offset < cpu_info_string_len) {
>>> 349: assert(cpu_info_string[features_offset + 0] ==
On Tue, 22 Apr 2025 13:45:26 GMT, Hamlin Li wrote:
>> Vladimir Ivanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 24 additional
>> commits s
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in
> JVM) to Java FFM API.
>
> Since FFM API doesn't support vector calling conventions yet, migration
> affects only symbol lookup for now. But it still enables significant
> simplifications on JVM side.
>
> The patc
On Tue, 22 Apr 2025 23:29:02 GMT, Jiangli Zhou wrote:
>> Please review this PR that changes to use `NativeLibraries.loadLibrary()`
>> for loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>>
>> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
> Certain specific types of tests involving GC and reference processing need to
> account for the delay between a GC completing (during which the GC clears a
> Reference), and the Reference being added to its associated queue. At
> present, ad hoc mechanisms (with delays/timeout) are used, but c
> The ClassFile API promotes usage of constant nominal descriptors over literal
> strings. However, for `class` file parsing, currently the efficient way to
> check if a constant pool entry matches a desired descriptor is via unrolling
> them back to strings. However, string unrolling is ugly, a
On Tue, 11 Feb 2025 02:26:57 GMT, Chen Liang wrote:
> The ClassFile API promotes usage of constant nominal descriptors over literal
> strings. However, for `class` file parsing, currently the efficient way to
> check if a constant pool entry matches a desired descriptor is via unrolling
> them
On Tue, 22 Apr 2025 23:55:54 GMT, Chen Liang wrote:
> In the future value objects JEP, class files must have one of ACC_IDENTITY
> (now ACC_SUPER), ACC_ABSTRACT, and ACC_FINAL bits set, otherwise they are
> rejected. The current default flag has none of these bits set, meaning that
> it will n
In the future value objects JEP, class files must have one of ACC_IDENTITY (now
ACC_SUPER), ACC_ABSTRACT, and ACC_FINAL bits set, otherwise they are rejected.
The current default flag has none of these bits set, meaning that it will not
be suitable in the future. Currently, most class file gener
On Tue, 22 Apr 2025 23:28:38 GMT, Chen Liang wrote:
> A few pattern matching switches exist in the core parts of ClassFile API
> responsible for transformations and parsing. They are likely to be used in
> early bootstrap, and pattern matching switches require bootstrap methods,
> which depend
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementall
A few pattern matching switches exist in the core parts of ClassFile API
responsible for transformations and parsing. They are likely to be used in
early bootstrap, and pattern matching switches require bootstrap methods, which
depend on core ClassFile API.
For example, currently BlockCodeBuild
On Tue, 22 Apr 2025 17:20:15 GMT, Chen Liang wrote:
>> The downcallHandle method in Linker has a complex implementation, and type
>> switches is triggered in multiple places in that handle.
>>
>> After bytestacks analysis of a simple program that links the native
>> implementation of Class::fo
On Tue, 22 Apr 2025 21:32:48 GMT, Chen Liang wrote:
> `sysLookup` does look much cleaner compared to `jdkLibraryPath`.
@liach Thanks for the quick review!
-
PR Comment: https://git.openjdk.org/jdk/pull/24801#issuecomment-2822696068
> Please review this PR that changes to use `NativeLibraries.loadLibrary()` for
> loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>
> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
> built-in library loading properly. On `static-jdk`, callin
On Mon, 14 Apr 2025 03:57:41 GMT, Kim Barrett wrote:
>> test/lib/jdk/test/whitebox/WhiteBox.java line 609:
>>
>>> 607: throw e;
>>> 608: } catch (Throwable t) {
>>> 609: throw new RuntimeException(t);
>>
>> The only checked exceptions that are thrown by the try-body are
>> `Inv
> Certain specific types of tests involving GC and reference processing need to
> account for the delay between a GC completing (during which the GC clears a
> Reference), and the Reference being added to its associated queue. At
> present, ad hoc mechanisms (with delays/timeout) are used, but c
* Windows and Unix: set sprops.stdin_encoding if connected to a console
* Add specs for stdin.encoding
* Adjust specs to change "undefined" to "unspecified"
* Rewrite System.in spec to refer to new property and to clarify usage with
classes that perform encoding
* Update property test
---
On Tue, 22 Apr 2025 17:12:52 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Add missing toList(), tweak verbiage; update
On Tue, 22 Apr 2025 16:53:30 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/Reader.java line 426:
>>
>>> 424: */
>>> 425: public List readAllLines() throws IOException {
>>> 426: return readAllChars().lines();
>>
>> I assume you are missing toList() here.
>
On Tue, 22 Apr 2025 00:43:24 GMT, Alexey Semenyuk wrote:
> Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest.
>
> If signing identity validation fails, jpackage outputs three messages
> constructed from the following string IDs: `error.cert.not.found`,
> `error.explicit-si
> In offline discussion, we noted that the documentation on this annotation
> does not recommend minimizing the intrinsified section and moving whatever
> can be done in Java to Java; thus I prepared this documentation update, to
> shrink a "TLDR" essay to something concise for readers, such as
On Tue, 22 Apr 2025 21:08:56 GMT, Jiangli Zhou wrote:
> Please review this PR that changes to use `NativeLibraries.loadLibrary()` for
> loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
>
> `NativeLibraries.loadLibrary()` handles both the shared library and (static)
> bu
On Tue, 22 Apr 2025 20:58:21 GMT, Chen Liang wrote:
>> In offline discussion, we noted that the documentation on this annotation
>> does not recommend minimizing the intrinsified section and moving whatever
>> can be done in Java to Java; thus I prepared this documentation update, to
>> shrink
On Tue, 22 Apr 2025 20:58:21 GMT, Chen Liang wrote:
>> In offline discussion, we noted that the documentation on this annotation
>> does not recommend minimizing the intrinsified section and moving whatever
>> can be done in Java to Java; thus I prepared this documentation update, to
>> shrink
On Tue, 22 Apr 2025 21:01:13 GMT, Chen Liang wrote:
>> In the new design, the above "footnotes" go at the bottom. They explain why
>> the rules prescribed at the top are important. In effect, inform aggressive
>> implementors how far they may bend those rules. Sometimes the rules do get
>>
Please review this PR that changes to use `NativeLibraries.loadLibrary()` for
loading the `libsyslookup` in `jdk.internal.foreign.SystemLookup` class.
`NativeLibraries.loadLibrary()` handles both the shared library and (static)
built-in library loading properly. On `static-jdk`, calling
`Native
On Tue, 22 Apr 2025 18:42:01 GMT, John R Rose wrote:
>> And for arrays, a footnote might be appropriate:
>>
>>
>>
>> For some highly optimized algorithms, it may be impractical to ensure that
>> array
>> data is read or written only once by the intrinsic. If the caller of the
>> intrinsic
>
On Mon, 21 Apr 2025 20:12:19 GMT, Chen Liang wrote:
>> In offline discussion, we noted that the documentation on this annotation
>> does not recommend minimizing the intrinsified section and moving whatever
>> can be done in Java to Java; thus I prepared this documentation update, to
>> shrink
> In offline discussion, we noted that the documentation on this annotation
> does not recommend minimizing the intrinsified section and moving whatever
> can be done in Java to Java; thus I prepared this documentation update, to
> shrink a "TLDR" essay to something concise for readers, such as
On Tue, 22 Apr 2025 07:37:45 GMT, Jaikiran Pai wrote:
> Hello Jiangli, can you add a few more details to the linked JBS issue? If I
> understand this change correctly, then what's being proposed in this PR seems
> to indicate that the `jdk.internal.loader.RawNativeLibraries` is unable to
> loa
On Thu, 17 Apr 2025 18:03:47 GMT, Vladimir Ivanov wrote:
>> Migrate Vector API math library (SVML and SLEEF) linkage from native code
>> (in JVM) to Java FFM API.
>>
>> Since FFM API doesn't support vector calling conventions yet, migration
>> affects only symbol lookup for now. But it still e
On Fri, 18 Apr 2025 13:05:24 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>
> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
> A
On Tue, 22 Apr 2025 16:34:21 GMT, Hamlin Li wrote:
>> Vladimir Ivanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 24 additional
>> commits s
Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest.
If signing identity validation fails, jpackage outputs three messages
constructed from the following string IDs: `error.cert.not.found`,
`error.explicit-sign-no-cert`, and `error.explicit-sign-no-cert.advice`.
`TKit.TextStr
On Tue, 22 Apr 2025 00:43:24 GMT, Alexey Semenyuk wrote:
> Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest.
>
> If signing identity validation fails, jpackage outputs three messages
> constructed from the following string IDs: `error.cert.not.found`,
> `error.explicit-si
On Tue, 22 Apr 2025 18:48:06 GMT, Chen Liang wrote:
>> PushId is an HTTP/3 concept. It would be strange to have a generic method
>> (sendAsync) that you could call with any requests, but with a parameter that
>> could only be used for HTTP/3. We don't have pushIds for HTTP/2. I don't
>> think
On Tue, 22 Apr 2025 11:06:17 GMT, Shaojin Wen wrote:
> As the title says, this is a simple refactoring that simplifies the code by
> using record.
Both the bug report and the PR description are inadequate.
They do not identity what code is simplified.
-
Changes requested by rrigg
On Tue, 22 Apr 2025 18:59:57 GMT, Artur Barashev wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Cli
On Fri, 18 Apr 2025 13:05:24 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>
> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
> A
On Fri, 18 Apr 2025 13:05:24 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>
> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
> A
On Tue, 22 Apr 2025 08:14:23 GMT, Alan Bateman wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add clause about handling of malformed/unmappable bytes.
>
> src/java.base/share/classes/java/lang/IO.java line 41:
>
>>
On Fri, 18 Apr 2025 13:05:24 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>
> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
> A
On Tue, 22 Apr 2025 18:18:51 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/java/net/http/HttpRequest.java line 357:
>>
>>> 355: * @since TBD
>>> 356: */
>>> 357: public default Builder setOption(HttpRequestOption
>>> option, T value) { return this; }
>>
On Tue, 22 Apr 2025 18:38:42 GMT, John R Rose wrote:
>> src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java
>> line 58:
>>
>>> 56: * The HotSpot VM checks, when loading a class, the consistency of
>>> recognized
>>> 57: * methods and {@code @IntrinsicCandidate} ann
On Tue, 22 Apr 2025 18:23:52 GMT, John R Rose wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refine validation and defensive copying
>
> src/java.base/share/classes/jdk/internal/vm/annotation/IntrinsicCandidate.java
On Mon, 21 Apr 2025 20:12:19 GMT, Chen Liang wrote:
>> In offline discussion, we noted that the documentation on this annotation
>> does not recommend minimizing the intrinsified section and moving whatever
>> can be done in Java to Java; thus I prepared this documentation update, to
>> shrink
On Fri, 18 Apr 2025 18:49:19 GMT, Chen Liang wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
On Tue, 22 Apr 2025 17:46:04 GMT, Brian Burkhalter wrote:
>> src/java.base/windows/classes/java/io/WinNTFileSystem.java line 376:
>>
>>> 374: return true;
>>> 375: theFile = theFile.getParentFile();
>>> 376: } while (theFile != null);
>>
>> The input has alre
On Tue, 22 Apr 2025 11:06:17 GMT, Shaojin Wen wrote:
> As the title says, this is a simple refactoring that simplifies the code by
> using record.
src/java.base/share/classes/java/lang/Throwable.java line 770:
> 768: * implementation of printStackTrace.
> 769: */
> 770: private i
On Tue, 22 Apr 2025 15:56:10 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354450: Account for spaces in directory elements; update test
>
> src/java.base/windows/classes/java/io/WinNTFileS
On Tue, 22 Apr 2025 17:20:15 GMT, Chen Liang wrote:
>> The downcallHandle method in Linker has a complex implementation, and type
>> switches is triggered in multiple places in that handle.
>>
>> After bytestacks analysis of a simple program that links the native
>> implementation of Class::fo
On Tue, 22 Apr 2025 12:39:05 GMT, Jan Lahoda wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
>>
> The downcallHandle method in Linker has a complex implementation, and type
> switches is triggered in multiple places in that handle.
>
> After bytestacks analysis of a simple program that links the native
> implementation of Class::forName0, it turns out that:
> 1. there are a few missed usag
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Add missing toList(), tweak verbiage; update test
-
Changes:
- all: https://git.openjdk.org/jdk/pul
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
On Tue, 22 Apr 2025 16:48:43 GMT, Alan Bateman wrote:
> I assume you are missing toList() here.
Yes, that was stupid. The `make jdk` caught it but I somehow missed the error
message.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2054494622
On Mon, 21 Apr 2025 23:15:56 GMT, Justin Lu wrote:
>> Please review this PR which improves future currency checking for ISO 4217
>> currencies.
>>
>> Checking for a currency that should not yet exist in the set of available
>> currencies is already done.
>> It should also be explicitly checked
On Tue, 22 Apr 2025 16:32:09 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Add Reader.readAllLines; test not yet updated
On Fri, 18 Apr 2025 13:05:24 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>
> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
> A
On Fri, 18 Apr 2025 13:05:24 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>
> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
> A
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Add Reader.readAllLines; test not yet updated
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24
On Fri, 18 Apr 2025 13:05:24 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>
> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
> A
On Fri, 18 Apr 2025 13:05:24 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>
> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
> A
On Fri, 18 Apr 2025 13:05:24 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>
> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client
> A
On Mon, 24 Mar 2025 11:02:15 GMT, Severin Gehwolf wrote:
> Please review this enhancement which adds a hidden `jlink` option
> `--sha-overrides` that can be used to provide alternative hash sums for files
> in an image. Please see the bug for use-cases as to why this is needed. This
> patch al
On Fri, 18 Apr 2025 18:44:58 GMT, Brian Burkhalter wrote:
>> In `java.io.WinNTFileSystem::isInvalid`, replace an insufficient test for
>> file path validity with a sufficient test for file path invalidity. Also,
>> add a new test.
>
> Brian Burkhalter has updated the pull request incrementally
On Tue, 22 Apr 2025 15:34:43 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/Reader.java line 401:
>>
>>> 399: * Reads all remaining characters into a string.
>>> 400: *
>>> 401: * This method reads all content including the line separators
>>> in
>>
>> Agai
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Add some more dangling "remaining"s
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24728/files
On Tue, 22 Apr 2025 10:16:48 GMT, Alan Bateman wrote:
> Again, just to say that it's all remaining rather than "all content" as some
> characters may have been consumed before this method is invoked.
Thanks, that was inadvertently overlooked. See 42e6f3b.
> Now that you have readAllChars, I th
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Add overlooked "remaining"s to Reader.readAllChars
-
Changes:
- all: https://git.openjdk.org/jdk/pu
On Tue, 22 Apr 2025 15:07:29 GMT, Shaojin Wen wrote:
>> As the title says, adding final to fields that do not change and BitSieve
>> that will not be inherited will make C2 optimization more friendly.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since
On Mon, 14 Apr 2025 14:47:59 GMT, Per Minborg wrote:
> This PR proposes to add the `@Stable` annotation to `j.l.String.hash` and
> `j.l.String.hashIsZero`. This means the VM can trust these fields to never
> change which enables constant folding optimizations.
>
> This PR is tested in tier1, t
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Reformat docs
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.openjdk.org/jd
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
On Tue, 22 Apr 2025 15:04:07 GMT, Shaojin Wen wrote:
>> As the title says, adding final to fields that do not change and BitSieve
>> that will not be inherited will make C2 optimization more friendly.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since
> As the title says, adding final to fields that do not change and BitSieve
> that will not be inherited will make C2 optimization more friendly.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/java/
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with three additional
commits since the last revision:
- Fix failing test (exception message)
- Rework relayed to rethrown
- Fix copyright related issues
-
Changes:
On Tue, 22 Apr 2025 08:26:17 GMT, Per Minborg wrote:
>> This PR proposes to add the `@Stable` annotation to `j.l.String.hash` and
>> `j.l.String.hashIsZero`. This means the VM can trust these fields to never
>> change which enables constant folding optimizations.
>>
>> This PR is tested in tie
1 - 100 of 163 matches
Mail list logo
