On Tue, 22 Apr 2025 14:46:21 GMT, Ludovic Henry <luhe...@openjdk.org> wrote:

>> Vladimir Ivanov has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains 24 additional 
>> commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into vector.math.01.java
>>  - RVV and SVE adjustments
>>  - fix broken merge
>>  - Merge branch 'master' into vector.math.01.java
>>  - Fix debugName handling
>>  - Merge branch 'master' into vector.math.01.java
>>  - RVV and SVE adjustments
>>  - Merge branch 'master' into vector.math.01.java
>>  - Fix windows-aarch64 build failure
>>  - features_string -> cpu_info_string
>>  - ... and 14 more: https://git.openjdk.org/jdk/compare/41f2363b...88eacc48
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMathLibrary.java
>  line 75:
> 
>> 73:             return switch (StaticProperty.osArch()) {
>> 74:                 case "amd64", "x86_64" -> SVML;
>> 75:                 case "aarch64" -> SLEEF;
> 
> We should be supporting SLEEF on `riscv64`. Was there a specific motivation 
> not to include it here?

Goot catch, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24462#discussion_r2055072456

Reply via email to