On Fri, 18 Apr 2025 13:05:24 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

> Hi,
> 
> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for 
> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
> 
> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client 
> API](https://bugs.openjdk.org/browse/JDK-8350588)
> 
> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
> It adds a non-exposed / non-exported internal implementation of the QUIC 
> protocol based on DatagramChannel and the SunJSSE SSLContext provider.

test/jdk/java/net/httpclient/http3/H3QuicTLSConnection.java line 86:

> 84:     public static void main(String[] args) throws Exception {
> 85:         // re-enable 3DES
> 86:         Security.setProperty("jdk.tls.disabledAlgorithms", "");

Use `SecurityUtils.removeFromDisabledAlgs` and only remove 3DES from this 
property.

test/jdk/java/net/httpclient/http3/H3QuicTLSConnection.java line 95:

> 93:         //System.setProperty("javax.net.ssl.keyStorePassword", PASSWORD);
> 94:         //System.setProperty("javax.net.ssl.trustStore", KEYSTORE);
> 95:         //System.setProperty("javax.net.ssl.trustStorePassword", 
> PASSWORD);

Why we don't delete this?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2054689179
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2054690345

Reply via email to