On Mon, 21 Apr 2025 22:54:37 GMT, Calvin Cheung wrote:
>> src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java line
>> 165:
>>
>>> 163: BootLoader.getUnnamedModule(); // trigger of
>>> BootLoader.
>>> 164:
>>> CDS.defineArchivedModules(ClassLoaders.pla
On Tue, 22 Apr 2025 05:31:01 GMT, Calvin Cheung wrote:
>> This RFE allows --add-opens to be specified for AOT cache creation. AOT
>> cache can be used during production run with --add-opens option as long as
>> the same set of options is used during assembly phase.
>>
>> Passed tiers 1 - 4 tes
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementall
This PR is to remove unused imports after PR #16425
-
Commit messages:
- remove unused import
Changes: https://git.openjdk.org/jdk/pull/24788/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24788&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8355240
Stats: 2 lines
On Fri, 11 Apr 2025 22:45:55 GMT, Chen Liang wrote:
> When jdeps was migrated from old classfile to ClassFile API, the parsing
> semantic changed - error checks are now made lazily, and nested crashes from
> malformed signature or other problems is now latent, after a `ClassModel`
> instance i
On Mon, 21 Apr 2025 17:42:33 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
On Mon, 21 Apr 2025 17:42:33 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
On Sun, 20 Apr 2025 03:28:48 GMT, SendaoYan wrote:
>> ### Summary:
>> [JDK-8318650](http://java-service.client.nvidia.com/?q=8318650) added the
>> hotspot intrinsifying of subword gather load APIs for X86 platforms [1].
>> This patch aims at implementing the equivalent functionality for AArch64
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
On Fri, 18 Apr 2025 21:11:35 GMT, Alexey Semenyuk wrote:
> Add tests for the following test cases:
> - Expired certificate specified for signing;
> - Multiple certificates with the same name in one keychain.
>
> Adding the new tests revealed an issue with MacCertificate -
> [JDK-8354989](http
On Tue, 22 Apr 2025 00:03:01 GMT, Alexey Semenyuk wrote:
>> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java line 410:
>>
>>> 408: continue;
>>> 409: }
>>> 410: certs.add(cert);
>>
>> Maybe:
>>
>>
On Tue, 22 Apr 2025 00:14:17 GMT, Alexey Semenyuk wrote:
>> Add tests for the following test cases:
>> - Expired certificate specified for signing;
>> - Multiple certificates with the same name in one keychain.
>>
>> Adding the new tests revealed an issue with MacCertificate -
>> [JDK-8354989
On Mon, 21 Apr 2025 23:02:33 GMT, Alexander Matveev
wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix compilation error
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java line 691:
>
>> 689:
> Add tests for the following test cases:
> - Expired certificate specified for signing;
> - Multiple certificates with the same name in one keychain.
>
> Adding the new tests revealed an issue with MacCertificate -
> [JDK-8354989](https://bugs.openjdk.org/browse/JDK-8354989). This issue is
>
On Mon, 21 Apr 2025 22:36:08 GMT, Alexander Matveev
wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix compilation error
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java line 410:
>
>> 408:
On Mon, 21 Apr 2025 21:34:59 GMT, Alexey Semenyuk wrote:
>> Add tests for the following test cases:
>> - Expired certificate specified for signing;
>> - Multiple certificates with the same name in one keychain.
>>
>> Adding the new tests revealed an issue with MacCertificate -
>> [JDK-8354989
On Mon, 21 Apr 2025 22:25:14 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move future currencies set up under setUpTestingData()
>
> test/jdk/java/util/Currency/ValidateISO4217.java line 183:
>
>>
> Please review this PR which improves future currency checking for ISO 4217
> currencies.
>
> Checking for a currency that should not yet exist in the set of available
> currencies is already done.
> It should also be explicitly checked that such a currency can not be
> instantiated as well vi
On Mon, 21 Apr 2025 18:39:39 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @iklam comment
>
> src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java line 165:
>
>> 163: Bo
> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache
> can be used during production run with --add-opens option as long as the same
> set of options is used during assembly phase.
>
> Passed tiers 1 - 4 testing.
Calvin Cheung has updated the pull request incrementall
On Mon, 21 Apr 2025 21:51:35 GMT, Justin Lu wrote:
> Please review this PR which improves future currency checking for ISO 4217
> currencies.
>
> Checking for a currency that should not yet exist in the set of available
> currencies is already done.
> It should also be explicitly checked that
Please review this PR which improves future currency checking for ISO 4217
currencies.
Checking for a currency that should not yet exist in the set of available
currencies is already done.
It should also be explicitly checked that such a currency can not be
instantiated as well via the String g
On Mon, 21 Apr 2025 20:11:47 GMT, Naoto Sato wrote:
> Adding @spec tags to Emoji related methods in the Character class. A CSR has
> also been drafted.
Marked as reviewed by jlu (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/24779#pullrequestreview-2782310737
On Fri, 18 Apr 2025 21:11:35 GMT, Alexey Semenyuk wrote:
> Add tests for the following test cases:
> - Expired certificate specified for signing;
> - Multiple certificates with the same name in one keychain.
>
> Adding the new tests revealed an issue with MacCertificate -
> [JDK-8354989](http
> Add tests for the following test cases:
> - Expired certificate specified for signing;
> - Multiple certificates with the same name in one keychain.
>
> Adding the new tests revealed an issue with MacCertificate -
> [JDK-8354989](https://bugs.openjdk.org/browse/JDK-8354989). This issue is
>
On Mon, 21 Apr 2025 20:11:47 GMT, Naoto Sato wrote:
> Adding @spec tags to Emoji related methods in the Character class. A CSR has
> also been drafted.
CSR also Reviewed.
-
Marked as reviewed by iris (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24779#pullrequestreview-
On Mon, 21 Apr 2025 20:11:47 GMT, Naoto Sato wrote:
> Adding @spec tags to Emoji related methods in the Character class. A CSR has
> also been drafted.
Marked as reviewed by joehw (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24779#pullrequestreview-2782236067
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Change "lines" to "characters" in spec of Reader.readAllChars, where
appropriate
-
Changes:
- all:
On Wed, 16 Apr 2025 23:06:19 GMT, Justin Lu wrote:
> Please review this PR which improves the _ValidateISO4217_ Currency test by
> adding testing of future currencies after the transition date.
>
> This is done by creating a patched version of Currency that replaces
> `System.currentTimeMillis
On Fri, 18 Apr 2025 15:10:02 GMT, Chen Liang wrote:
>> Maybe it can be implemented by referring to `InputStream::readNBytes(int)`
>> (The default implementation of `InputStream::readAllBytes()` is based on it):
>>
>> https://github.com/openjdk/jdk/blob/22e8a97a1ce4e1c781fbc6f1e271c477fe95f069/s
Adding @spec tags to Emoji related methods in the Character class. A CSR has
also been drafted.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/24779/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24779&range=00
Issue: https://bugs.openjdk.
> In offline discussion, we noted that the documentation on this annotation
> does not recommend minimizing the intrinsified section and moving whatever
> can be done in Java to Java; thus I prepared this documentation update, to
> shrink a "TLDR" essay to something concise for readers, such as
On Mon, 21 Apr 2025 08:17:30 GMT, Andrey Turbanov wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Remove unused import
>
> test/jdk/java/io/BufferedReader/ReadAll.java line 70:
>
>> 68: int si
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: readString -> readAllChars; update test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24728/fi
In offline discussion, we noted that the documentation on this annotation does
not recommend minimizing the intrinsified section and moving whatever can be
done in Java to Java; thus I prepared this documentation update, to shrink a
"TLDR" essay to something concise for readers, such as pointing
On Thu, 10 Apr 2025 01:03:01 GMT, Jan Lahoda wrote:
>> This is a PR that implements JEP: Compact Source Files and Instance Main
>> Methods. Changes include:
>> - `java.io.IO` moved to `java.lang.IO`, and no longer uses
>> `System.console()` to implement the methods (thanks to @stuart-marks)
>>
On Wed, 16 Apr 2025 17:37:07 GMT, David Beaumont wrote:
>> Increasing timeout for deadlock detection and adjusting for the timeout
>> factor in higher tiers.
>
> David Beaumont has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing test
On Mon, 21 Apr 2025 06:20:46 GMT, Calvin Cheung wrote:
>> This RFE allows --add-opens to be specified for AOT cache creation. AOT
>> cache can be used during production run with --add-opens option as long as
>> the same set of options is used during assembly phase.
>>
>> Passed tiers 1 - 4 tes
On Mon, 21 Apr 2025 06:20:46 GMT, Calvin Cheung wrote:
>> This RFE allows --add-opens to be specified for AOT cache creation. AOT
>> cache can be used during production run with --add-opens option as long as
>> the same set of options is used during assembly phase.
>>
>> Passed tiers 1 - 4 tes
On Thu, 17 Apr 2025 17:41:56 GMT, Joe Wang wrote:
> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug
> report.
>
> Also in this patch: consolidates get and set properties to use the same Util
> methods to reduce potential errors when code changes.
>
> Test:
> Ti
On Mon, 21 Apr 2025 17:42:33 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
> When jdeps was migrated from old classfile to ClassFile API, the parsing
> semantic changed - error checks are now made lazily, and nested crashes from
> malformed signature or other problems is now latent, after a `ClassModel`
> instance is available. (The old error check existed only for con
On Mon, 21 Apr 2025 16:19:30 GMT, Joe Wang wrote:
>> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug
>> report.
>>
>> Also in this patch: consolidates get and set properties to use the same Util
>> methods to reduce potential errors when code changes.
>>
>> Test:
>
On Mon, 21 Apr 2025 16:19:30 GMT, Joe Wang wrote:
>> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug
>> report.
>>
>> Also in this patch: consolidates get and set properties to use the same Util
>> methods to reduce potential errors when code changes.
>>
>> Test:
>
Following up on MemoryOutputStream, etc. – the conversation has considered a
few alternatives:
1. Hide the new class behind ByteArrayOutputStream.unsynchronized()
2. Create a new public class providing views to OutputStream, Channel,
InputStream
3. Something to do with an Object[] variant
I
On Mon, 21 Apr 2025 16:27:03 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
On Mon, 14 Apr 2025 16:14:03 GMT, Roger Riggs wrote:
>> The JavaIOFilePermissionAccess interface is removed from SharedSecrets and
>> its implementation (FilePermCompat.java) used by the test is moved to
>> java.io FilePermission where cross package access is not needed.
>> The test FilePermis
> When jdeps was migrated from old classfile to ClassFile API, the parsing
> semantic changed - error checks are now made lazily, and nested crashes from
> malformed signature or other problems is now latent, after a `ClassModel`
> instance is available. (The old error check existed only for con
On Mon, 21 Apr 2025 16:06:25 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
On Mon, 21 Apr 2025 16:06:25 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
On Mon, 21 Apr 2025 08:11:33 GMT, Andrey Turbanov wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unused variable pName; remove unused imports
>
> src/java.xml/share/classes/jdk/xml/internal/JdkXmlUtils.java lin
> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug
> report.
>
> Also in this patch: consolidates get and set properties to use the same Util
> methods to reduce potential errors when code changes.
>
> Test:
> Tier1 - 3 passed
> JCK test passed
Joe Wang has u
On Mon, 21 Apr 2025 07:00:36 GMT, Shaojin Wen wrote:
> In BufferedReader.readLine and other similar scenarios, we need to use
> StringBuilder.append(char[]) to build the string.
>
> For these scenarios, we can use the intrinsic method StringUTF16.compress and
> Unsafe.copyMemory instead of the
> When jdeps was migrated from old classfile to ClassFile API, the parsing
> semantic changed - error checks are now made lazily, and nested crashes from
> malformed signature or other problems is now latent, after a `ClassModel`
> instance is available. (The old error check existed only for con
On Mon, 21 Apr 2025 15:44:20 GMT, Jaikiran Pai wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add a test
>
> test/langtools/tools/jdeps/MalformedClassesTest.java line 28:
>
>> 26: * @bug 8341608
>> 27: * @summary
On Mon, 21 Apr 2025 15:25:34 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> putCharsUnchecked
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1773:
>
>> 1771:
> In BufferedReader.readLine and other similar scenarios, we need to use
> StringBuilder.append(char[]) to build the string.
>
> For these scenarios, we can use the intrinsic method StringUTF16.compress and
> Unsafe.copyMemory instead of the character copy of the char-by-char loop to
> improve
On Mon, 21 Apr 2025 14:59:59 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
On Mon, 21 Apr 2025 14:59:59 GMT, Chen Liang wrote:
>> When jdeps was migrated from old classfile to ClassFile API, the parsing
>> semantic changed - error checks are now made lazily, and nested crashes from
>> malformed signature or other problems is now latent, after a `ClassModel`
>> instan
On Mon, 21 Apr 2025 07:00:36 GMT, Shaojin Wen wrote:
> In BufferedReader.readLine and other similar scenarios, we need to use
> StringBuilder.append(char[]) to build the string.
>
> For these scenarios, we can use the intrinsic method StringUTF16.compress and
> Unsafe.copyMemory instead of the
> When jdeps was migrated from old classfile to ClassFile API, the parsing
> semantic changed - error checks are now made lazily, and nested crashes from
> malformed signature or other problems is now latent, after a `ClassModel`
> instance is available. (The old error check existed only for con
On Mon, 21 Apr 2025 05:10:48 GMT, Jaikiran Pai wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review remarks
>
> Hello Chen,
>
>> Unfortunately, I don't think there is a convenient way to make a jar with
>> jtreg
> This PR implements nth root computation for `BigInteger`s using Newton method
> and optimizes `BigInteger.pow(int)` method.
> [Here is a proof of convergence of the recurrence
> used.](https://github.com/user-attachments/files/19785045/nth_root_newton_proof_integers.pdf)
fabioromano1 has updat
On Sun, 23 Mar 2025 10:33:42 GMT, Markus KARG wrote:
>> src/java.base/share/classes/java/nio/X-Buffer.java.template line 2356:
>>
>>> 2354: #end[streamableType]
>>> 2355:
>>> 2356: #if[char]
>>
>> Can we merge this with `// -- Other char stuff --` on line 1895?
>>
>> On a side note, we can op
On Mon, 21 Apr 2025 10:14:05 GMT, Andrew Haley wrote:
> That's very nice. It would be even nicer if this was a permalink into the JDK
> repo, and a reference in the source code.
@theRealAph Ok. It would be useful to have a link to an explanation on how this
can be done, if there is one. Thanks
On Mon, 21 Apr 2025 10:05:21 GMT, Andrew Haley wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code simplification
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 1924:
>
>> 1922: * @imp
On Sun, 20 Apr 2025 16:07:56 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for `BigInteger`s using Newton
>> method and optimizes `BigInteger.pow(int)` method.
>> [Here is a proof of convergence of the recurrence
>> used.](https://github.com/user-attachments/files/19785045
On Mon, 21 Apr 2025 07:00:36 GMT, Shaojin Wen wrote:
> In BufferedReader.readLine and other similar scenarios, we need to use
> StringBuilder.append(char[]) to build the string.
>
> For these scenarios, we can use the intrinsic method StringUTF16.compress and
> Unsafe.copyMemory instead of the
In BufferedReader.readLine and other similar scenarios, we need to use
StringBuilder.append(char[]) to build the string.
For these scenarios, we can use the intrinsic method StringUTF16.compress and
Unsafe.copyMemory instead of the character copy of the char-by-char loop to
improve the speed.
On Sun, 20 Apr 2025 16:07:56 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for `BigInteger`s using Newton
>> method and optimizes `BigInteger.pow(int)` method.
>> [Here is a proof of convergence of the recurrence
>> used.](https://github.com/user-attachments/files/19785045
On Fri, 18 Apr 2025 21:26:23 GMT, Joe Wang wrote:
>> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug
>> report.
>>
>> Also in this patch: consolidates get and set properties to use the same Util
>> methods to reduce potential errors when code changes.
>>
>> Test:
>
On Sun, 20 Apr 2025 16:07:56 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for `BigInteger`s using Newton
>> method and optimizes `BigInteger.pow(int)` method.
>> [Here is a proof of convergence of the recurrence
>> used.](https://github.com/user-attachments/files/19785045
On Fri, 18 Apr 2025 20:10:32 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Remove unused import
test/jdk/java/io/Buffer
On Sun, 20 Apr 2025 05:12:19 GMT, Chen Liang wrote:
>> fabioromano1 has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 21 additional
>> commits sin
76 matches
Mail list logo
