On Sun, 23 Mar 2025 10:33:42 GMT, Markus KARG <d...@openjdk.org> wrote:
>> src/java.base/share/classes/java/nio/X-Buffer.java.template line 2356: >> >>> 2354: #end[streamableType] >>> 2355: >>> 2356: #if[char] >> >> Can we merge this with `// -- Other char stuff --` on line 1895? >> >> On a side note, we can optimize a lot of Appendable operations that transfer >> from CharSequence on CharBuffer; don't know if you wish to have it in this >> RFE or another. > > Fixed in a3c2add9c16e4c7331c5a7c2848f27b6c0330a17. > > Let's finish this PR first. After that I would be happy to author another PR > with all the optimizations you tell me. 😃 > On a side note, we can optimize a lot of Appendable operations that transfer > from CharSequence on CharBuffer; don't know if you wish to have it in this > RFE or another. @liach FYI, I have just startet work on an experimental impementation for `Appendable`s utilizing `CharSequence.getChars`. So far, it really looks rather primising, as it gets rid of lots of potental copies in favor of absolute bulk get. My target is to turn it into a separate RFE eventually, once 8343110 is finally merged. 😃 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21730#discussion_r2052366020
