On Mon, 21 Apr 2025 05:10:48 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review remarks > > Hello Chen, > >> Unfortunately, I don't think there is a convenient way to make a jar with >> jtreg tests. > > There are several tests in the JDK repo which create a JAR file of their > choice within the test code and then run some tests against the JAR file. In > fact, existing tests for `jdeps` tool already has similar tests. For example, > there's a `JdepsUtil` test library which has a `createJar(...)` utility > method which some of these tests use. This new test can use that utility if > necessary. > > In addition to testing this change against a JAR file, I think the test could > also include running `jdeps` against a directory which contains more than one > class file with one of the class file exhibiting the reported issue. That > will then be able to reproduce the issue and verify the fix when running > `jdeps` against a directory. @jaikiran Done. Please review again. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24604#issuecomment-2818674103
