On Fri, 11 Apr 2025 22:45:55 GMT, Chen Liang <li...@openjdk.org> wrote:
> When jdeps was migrated from old classfile to ClassFile API, the parsing > semantic changed - error checks are now made lazily, and nested crashes from > malformed signature or other problems is now latent, after a `ClassModel` > instance is available. (The old error check existed only for constructing a > `ClassModel`) > > To address this issue, I have updated the way of iterating class files to be > handler/consumer based like in the ClassFile API. This has the advantage that > when one invocation of the handler fails of a `ClassFileError`, other > invocations for other class files can proceed, and the exception handler has > sufficient information to report a useful message indicating the source of > error. > > For the particular example of examining a proguard processed > `dummy-scala.jar`, here is the new output of `jdeps dummy-scala.jar`: > > Warning: com.sun.tools.jdeps.Dependencies$ClassFileError: Unexpected > character ; at position 59, expected an identifier: > Lscala/collection/immutable/TreeMap$TreeMapBuilder<TA;TB;>.;: > scala/collection/immutable/TreeMap$TreeMapBuilder.class (dummy-scala.jar) > Warning: com.sun.tools.jdeps.Dependencies$ClassFileError: Unexpected > character ; at position 49, expected an identifier: > Lscala/collection/parallel/mutable/ParArray<TT;>.;: > scala/collection/parallel/mutable/ParArray.class (dummy-scala.jar) > > > Now, jdeps shows the bad class files. Inspection into the files reveal that > proguard incorrectly deleted the simple class names with trailing `$`, for > example, the original signature of the broken ParArray was > `Lscala/collection/parallel/mutable/ParArray<TT;>.ParArrayIterator$;`, so the > `ParArrayIterator$` part was incorrectly dropped by proguard. > > Testing: langtools/tools/jdeps. This pull request has now been integrated. Changeset: 0be3f163 Author: Chen Liang <li...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/0be3f163ed12db305673928d97f975d6f6bb6b1c Stats: 357 lines in 8 files changed: 201 ins; 116 del; 40 mod 8341608: jdeps in JDK 23 crashes when parsing signatures while jdeps in JDK 22 works fine Reviewed-by: jpai, henryjen ------------- PR: https://git.openjdk.org/jdk/pull/24604
