On Sun, 23 Mar 2025 12:38:04 GMT, Jason Zaugg wrote:
> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
> performance
The tier 1-3 tests submitted by jaikiran all pass. This should be good to go.
On Mon, 24 Mar 2025 20:22:55 GMT, Jiangli Zhou wrote:
>> Please review following changes, thanks.
>>
>> - Add `static` to the vm_info for static JDK. The `-version` output now
>> contains `static` on static JDK, e.g.:
>>
>>
>> $ static-jdk/bin/java -version
>> openjdk version "25-internal" 20
On Tue, 25 Mar 2025 03:19:39 GMT, Alexey Semenyuk wrote:
> Replace `error.invalid-value-for-package-name` and
> `error.invalid-value-for-package-name.advice` l10n keys with a pair for rpm
> packaging:
> - `error.rpm-invalid-value-for-package-name`
> - `error.rpm-invalid-value-for-package-name
On Thu, 20 Mar 2025 04:46:21 GMT, Ioi Lam wrote:
> `-XX:+AOTClassLinking` requires the CDS archived full module graph (FMG).
>
> - Before this PR, when `--add-export` is specified, FMG is disabled, so AOT
> caches created with `-XX:+AOTClassLinking` cannot be loaded.
> - After this PR, if the
Replace `error.invalid-value-for-package-name` and
`error.invalid-value-for-package-name.advice` l10n keys with a pair for rpm
packaging:
- `error.rpm-invalid-value-for-package-name`
- `error.rpm-invalid-value-for-package-name.advice`
and a pair for deb packaging:
- `error.deb-invalid-value-fo
On Mon, 24 Feb 2025 23:47:02 GMT, Chen Liang wrote:
> Use a thread-safe ReferencedKeySet instead of a WeakHashMap key set.
Keep alive...
-
PR Comment: https://git.openjdk.org/jdk/pull/23757#issuecomment-2749858919
On Mon, 24 Mar 2025 14:35:50 GMT, Alexey Semenyuk wrote:
> Follow-up for https://github.com/openjdk/jdk/pull/24087 PR.
> Revamp signing tests:
> - Run the tests only if `jpackage.test.MacSignTests` property is set to
> "run". This property also can be set to "setup" and "teardown" to set up an
On Sun, 23 Mar 2025 12:38:04 GMT, Jason Zaugg wrote:
> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
> performance
Looks good to me. Before integrating, you might want to wait for Jan to have a
cha
On Sun, 23 Mar 2025 12:38:04 GMT, Jason Zaugg wrote:
> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
> performance
Hello Jason, I was crafting some JAR files to compose a large classpath and
runnin
> Please review this specification update for `SimpleDateFormat` which
> explicitly specifies the behavior for 'reserved' pattern letters. This is a
> specification update and has the potential low risk of making an
> implementation non-compliant. Thus, an associated CSR is filed.
Justin Lu has
On Mon, 24 Mar 2025 19:19:01 GMT, Jan Lahoda wrote:
> There are some more new jar FileSystems created in Locations, but those only
> typically read one file, so probably not that big deal w.r.t. this flag.
Agreed. I initially changed those as well but when I realized they only read a
single fi
On Thu, 20 Mar 2025 23:39:24 GMT, Vladimir Ivanov wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
>> these tests using empty data set that looks bad.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last
Follow-up for https://github.com/openjdk/jdk/pull/24087 PR.
Revamp signing tests:
- Run the tests only if `jpackage.test.MacSignTests` property is set to "run".
This property also can be set to "setup" and "teardown" to set up and tear down
jpackage signing test environment. See
https://github
On Mon, 24 Mar 2025 21:21:20 GMT, Justin Lu wrote:
> Please review this specification update for `SimpleDateFormat` which
> explicitly specifies the behavior for 'reserved' pattern letters. This is a
> specification update and has the potential low risk of making an
> implementation non-compli
On Mon, 17 Mar 2025 19:51:36 GMT, Alexey Semenyuk wrote:
> Automate setting up an environment for mac signing tests: create keychain(s),
> self-signing certificates, and register them in the system.
>
> To set up the environment, run `make test-only
> TEST=test/jdk/tools/jpackage/macosx/base/S
On Mon, 24 Mar 2025 19:20:27 GMT, Jan Lahoda wrote:
> Ordinarily, I would say a test is required, but I can't think up a viable
> test to verify the effect of this change in a test, so we probably need to do
> it without a test.
I tested this change
[externally](https://github.com/retronym/ja
On Sun, 23 Mar 2025 12:38:04 GMT, Jason Zaugg wrote:
> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
> performance
Can any zip area developer leave an approval?
-
PR Comment: https://g
On Thu, 27 Feb 2025 17:41:48 GMT, Chen Liang wrote:
>> Core reflection's generic signature parsing system is used for many aspects,
>> including annotations and enclosing methods, yet it is under-tested. It is
>> better for us to set up tests to ensure that sensitive error behaviors of
>> core
On Thu, 27 Feb 2025 17:41:48 GMT, Chen Liang wrote:
>> Core reflection's generic signature parsing system is used for many aspects,
>> including annotations and enclosing methods, yet it is under-tested. It is
>> better for us to set up tests to ensure that sensitive error behaviors of
>> core
> Core reflection's generic signature parsing system is used for many aspects,
> including annotations and enclosing methods, yet it is under-tested. It is
> better for us to set up tests to ensure that sensitive error behaviors of
> core reflection remain the same across implementation updates,
Please review this specification update for `SimpleDateFormat` which explicitly
specifies the behavior for 'reserved' pattern letters. This is a specification
update and has the potential low risk of making an implementation
non-compliant. Thus, an associated CSR is filed.
-
Commit
On Sat, 22 Mar 2025 11:09:03 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
On Mon, 24 Mar 2025 07:02:33 GMT, David Holmes wrote:
> The way we construct the VM info string is rather clunky and does not scale
> when you want to add more information like this.
Agree.
> Short of rewriting it to dynamically create the final string from its
> constituent parts, couldn't
> Please review following changes, thanks.
>
> - Add `static` to the vm_info for static JDK. The `-version` output now
> contains `static` on static JDK, e.g.:
>
>
> $ static-jdk/bin/java -version
> openjdk version "25-internal" 2025-09-16
> OpenJDK Runtime Environment (fastdebug build
> 25-in
On Mon, 24 Mar 2025 19:34:55 GMT, Vladimir Ivanov wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
>> these tests using empty data set that looks bad.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last
On Thu, 20 Mar 2025 12:25:31 GMT, Hannes Greule wrote:
> To me, it seems odd to add only the `byte[]` variant but not other primitive
> type arrays (as with the `equals` methods). You also most likely need a
> [CSR](https://wiki.openjdk.org/display/csr).
The only use case presented was for byt
On Sun, 23 Mar 2025 12:38:04 GMT, Jason Zaugg wrote:
> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
> performance
Good catch, thanks! Ordinarily, I would say a test is required, but I can't
think
> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
> these tests using empty data set that looks bad.
Vladimir Ivanov has updated the pull request incrementally with one additional
commit since the last revision:
8351593: [JMH] test PhoneCode.Bulk reports NPE except
On Thu, 20 Mar 2025 23:39:24 GMT, Vladimir Ivanov wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
>> these tests using empty data set that looks bad.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last
On Sun, 23 Mar 2025 12:41:51 GMT, Jason Zaugg wrote:
>> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
>> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
>> performance
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java
On Tue, 18 Mar 2025 18:57:04 GMT, Jiangli Zhou wrote:
> Please review this PR that adds `@requires !jdk.static` to tests, thanks.
>
> - runtime/StackGap/TestStackGap.java
> - runtime/StackGuardPages/TestStackGuardPages.java
> - runtime/TLS/TestTLS.java
> - runtime/jni/daemonDestroy/TestDaemonDes
On Sun, 23 Mar 2025 12:38:04 GMT, Jason Zaugg wrote:
> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
> performance
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.ope
On Sun, 23 Mar 2025 09:28:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix an issue
>> `java.util.zip.ZipFile` which would cause failures when multiple instances
>> of `ZipFile` using non-UTF8 `Charset` were operating against the same
>> underlying
On Fri, 21 Mar 2025 20:17:31 GMT, Naoto Sato wrote:
> Refining regex tests for Grapheme break so that every test case will run even
> with some failing ones.
This pull request has now been integrated.
Changeset: ddc43180
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/ddc
On Fri, 21 Mar 2025 17:38:53 GMT, Ian Graves wrote:
> Adding ForceInline to helper methods.
This pull request has now been integrated.
Changeset: 7d1fe0e0
Author:Ian Graves
URL:
https://git.openjdk.org/jdk/commit/7d1fe0e03fbdc73920094ff7905208a57dc4ee65
Stats: 64 lines in 31 fil
On Fri, 21 Mar 2025 16:19:38 GMT, Joachim Kern wrote:
>> After "JDK-8339480: Build static-jdk image with a statically linked
>> launcher" AIX was not able to build the new target. Therefore with
>> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was
>> disabled again.
>>
>
On Sat, 22 Mar 2025 13:03:28 GMT, Alexey Semenyuk wrote:
>> Automate setting up an environment for mac signing tests: create
>> keychain(s), self-signing certificates, and register them in the system.
>>
>> To set up the environment, run `make test-only
>> TEST=test/jdk/tools/jpackage/macosx/b
On Fri, 21 Mar 2025 20:17:31 GMT, Naoto Sato wrote:
> Refining regex tests for Grapheme break so that every test case will run even
> with some failing ones.
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/24168#issuecomment-2748681002
On Fri, 14 Mar 2025 15:41:56 GMT, Joachim Kern wrote:
> After "JDK-8339480: Build static-jdk image with a statically linked launcher"
> AIX was not able to build the new target. Therefore with "JDK-8345590 AIX
> 'make all' fails after JDK-8339480" the new target was disabled again.
>
> Now wit
> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
Archie Cobbs has updated the pull request incrementally with one additional
commit since the last revision:
Revert accidental file change.
-
Changes:
- all: https://gi
On Sat, 22 Mar 2025 11:09:03 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
On Fri, 21 Mar 2025 16:19:38 GMT, Joachim Kern wrote:
>> After "JDK-8339480: Build static-jdk image with a statically linked
>> launcher" AIX was not able to build the new target. Therefore with
>> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was
>> disabled again.
>>
>
On Mon, 24 Mar 2025 08:47:29 GMT, Alan Bateman wrote:
> Is the motivation tests or code that is making use of JDK internals? No
> objection to the change of course, I'm curious why we are doing this.
The motivation is for both testing (e.g., expose the `
jdk.internal.test.cds.WhiteBox` package
On Mon, 24 Mar 2025 14:30:02 GMT, Matthias Baesken wrote:
> Regarding BitmapToYXBandedRectangles from splashscreen, couldn't we just
> rename it to avoid clashes/issues with the other one from awt with the same
> name but other signature?
But this can be done in another issue/PR not here.
Inde
On Thu, 20 Mar 2025 23:39:24 GMT, Vladimir Ivanov wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
>> these tests using empty data set that looks bad.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last
On Thu, 20 Mar 2025 23:39:24 GMT, Vladimir Ivanov wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
>> these tests using empty data set that looks bad.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last
On Mon, 24 Mar 2025 00:58:18 GMT, Chen Liang wrote:
>> Jaikiran Pai has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - improve code comment for ZipFile.zipCoder
>> - Alan's suggestion - change code comment about Source class being thre
On Fri, 21 Mar 2025 16:19:38 GMT, Joachim Kern wrote:
>> After "JDK-8339480: Build static-jdk image with a statically linked
>> launcher" AIX was not able to build the new target. Therefore with
>> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was
>> disabled again.
>>
>
On Fri, 21 Mar 2025 16:19:38 GMT, Joachim Kern wrote:
>> After "JDK-8339480: Build static-jdk image with a statically linked
>> launcher" AIX was not able to build the new target. Therefore with
>> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was
>> disabled again.
>>
>
On Mon, 24 Mar 2025 13:56:21 GMT, Chen Liang wrote:
>> Archie Cobbs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert accidental file change.
>
> Looks good, these locations in the JDK 24 docs indeed have extra braces
> (besides Ab
On Mon, 24 Mar 2025 13:29:24 GMT, Archie Cobbs wrote:
>> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
>> braces have been sneaking in.
>
> Archie Cobbs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert a
On Mon, 24 Mar 2025 05:23:58 GMT, Chen Liang wrote:
> Shouldn't this closing `)` be wrapped in `{@code}` like `{@code )}` to match
> with the code format in `{@code (getLocale()}`?
Yes it should - thanks. The two rows above also have the same problem, i.e., I
was just making this row consisten
On Mon, 24 Mar 2025 12:28:04 GMT, Jason Zaugg wrote:
> > but give it a more suitable name
>
> I'm assuming this would come in a followup change for the ZipFS maintainers,
> rather this in this PR.
Yes, that's correct.
-
PR Comment: https://git.openjdk.org/jdk/pull/24176#issuecomm
WhileOpTest.java is a TestNG test (`TestNG.dirs` is set in Find file:
`test/jdk/java/util/stream/test/TEST.properties`)
As such, the `@run main/timeout=240` annotation is ignored. If that was not the
case, it would complain about not specifying a main class.
-
Commit messages:
- 8
On Mon, 24 Mar 2025 07:47:29 GMT, Alan Bateman wrote:
> but give it a more suitable name
I'm assuming this would come in a followup change for the ZipFS maintainers,
rather this in this PR.
-
PR Comment: https://git.openjdk.org/jdk/pull/24176#issuecomment-2747962754
> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
Archie Cobbs has updated the pull request incrementally with one additional
commit since the last revision:
Apply font fixes per review suggestion.
-
Changes:
- all: h
On Mon, 24 Mar 2025 11:38:58 GMT, Markus KARG wrote:
>> src/java.base/share/classes/java/nio/X-Buffer.java.template line 1911:
>>
>>> 1909: * @implNote This method allows for superior performance over the
>>> default
>>> 1910: * implementation in {@code CharSequence}. It performs a di
> This Pull Request proposes an implementation for
> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new
> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int
> dstBegin)` to the `CharSequence` interface, providing a **bulk-read**
> facility including a
On Mon, 24 Mar 2025 02:50:04 GMT, Chen Liang wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Applied changes requested by Chen
>
> src/java.base/share/classes/java/nio/X-Buffer.java.template line 1911:
>
>> 1909:
On Fri, 21 Mar 2025 09:46:02 GMT, Joachim Kern wrote:
>> The test `testEcoFriendly()` checks if the launcher pollutes the
>> `LD_LIBRARY_PATH` environment variable.
>> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does
>> not make sense to make this test somehow passing w
On Mon, 24 Mar 2025 07:53:26 GMT, Robert Stupp wrote:
>> Concurent calls to `ClassLoader.definePackage()` can yield
>> `IllegalArgumentException`s if the package is already defined. Some built-in
>> class loaders, like `URLClassLoader`, already handle this case, but custom
>> class loaders (wo
Please review this enhancement which adds a hidden `jlink` option
`--sha-overrides` that can be used to provide alternative hash sums for files
in an image. Please see the bug for use-cases as to why this is needed. This
patch allows for the `--sha-overrides` option to be either specified multip
On Thu, 20 Mar 2025 04:46:21 GMT, Ioi Lam wrote:
> `-XX:+AOTClassLinking` requires the CDS archived full module graph (FMG).
>
> - Before this PR, when `--add-export` is specified, FMG is disabled, so AOT
> caches created with `-XX:+AOTClassLinking` cannot be loaded.
> - After this PR, if the
On Thu, 20 Mar 2025 23:39:24 GMT, Vladimir Ivanov wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently
>> these tests using empty data set that looks bad.
>
> Vladimir Ivanov has updated the pull request incrementally with one
> additional commit since the last
On Sun, 23 Mar 2025 12:38:04 GMT, Jason Zaugg wrote:
> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
> performance
I think this is okay. I was chatting with Jai and Lance about the undocumented
pro
On Mon, 24 Mar 2025 07:53:26 GMT, Robert Stupp wrote:
>> Concurent calls to `ClassLoader.definePackage()` can yield
>> `IllegalArgumentException`s if the package is already defined. Some built-in
>> class loaders, like `URLClassLoader`, already handle this case, but custom
>> class loaders (wo
> Concurent calls to `ClassLoader.definePackage()` can yield
> `IllegalArgumentException`s if the package is already defined. Some built-in
> class loaders, like `URLClassLoader`, already handle this case, but custom
> class loaders (would) have to handle this case.
>
> This change updates the
On Sat, 22 Mar 2025 03:46:38 GMT, Jiangli Zhou wrote:
> Please review following changes, thanks.
>
> - Add `static` to the vm_info for static JDK. The `-version` output now
> contains `static` on static JDK, e.g.:
>
>
> $ static-jdk/bin/java -version
> openjdk version "25-internal" 2025-09-16
68 matches
Mail list logo
