On Thu, 20 Mar 2025 23:39:24 GMT, Vladimir Ivanov <vaiva...@openjdk.org> wrote:
>> Tests that use data from the file 'cmudict-0.7b.txt' was deleted. Currently >> these tests using empty data set that looks bad. > > Vladimir Ivanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8351593: [JMH] test PhoneCode.Bulk reports NPE exception Thanks for this update which removes all benchmarks that rely on the absent cmudict-0.7b.txt dictionary. I think removing is less controversial than fixing in this case for a cleanup/bug fix PR. Fixed variants of these micros might be good to consider for a follow-up enhancement, with backing evidence that they are useful enough to motivate the extra luggage. ------------- Marked as reviewed by redestad (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24011#pullrequestreview-2709679106
