On Fri, 21 Mar 2025 09:46:02 GMT, Joachim Kern <jk...@openjdk.org> wrote:
>> The test `testEcoFriendly()` checks if the launcher pollutes the
>> `LD_LIBRARY_PATH` environment variable.
>> Because aix and musl intentionally pollute the `LD_LIBRARY_PATH`, it does
>> not make sense to make this test somehow passing with crude workarounds,
>> which even do not work in any case. So we skip this sub test for aix and
>> musl.
>
> @vidmik @axel7born Can please someone take a look at this PR, because I want
> to change something you implemented 5 years ago. Maybe @dholmes-ora @alanb
> @erikj who did the review may also take a look.
Hi @JoKern65, I just checked this PR but first of all I'm missing the
motivation here. What exactly is failing now and why, given that the test has
worked without error for years on all platforms?
E.g. is the assumption that in case of a pre-set LD_LIBRARY_PATH, the result
should be:
`String libPath = LD_LIBRARY_PATH + "=" + System.getenv(LD_LIBRARY_PATH) +
System.getProperty("path.separator") + LD_LIBRARY_PATH_VALUE;` not holding any
more?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24055#issuecomment-2742867252
