On Thu, 20 Mar 2025 04:46:21 GMT, Ioi Lam <ik...@openjdk.org> wrote: > `-XX:+AOTClassLinking` requires the CDS archived full module graph (FMG). > > - Before this PR, when `--add-export` is specified, FMG is disabled, so AOT > caches created with `-XX:+AOTClassLinking` cannot be loaded. > - After this PR, if the exact same `--add-export` flags as specified across > the training/assembly/production phases, the FMG can be used, so we can use > so AOT caches created with `-XX:+AOTClassLinking`. > > The change itself is straight-forward: just remember the `--add-export` flags > specified during AOT cache creation, and check the exact same ones are used > during the production run. > > I did a fair amount of refactoring to change the "exact options specified" > checks in modules.cpp, so more such options can be easily added in the future > (we need to handle `--add-reads` and `--add-opens` in future RFEs). > > (Note: this PR depends on #24122 )
Is the motivation tests or code that is making use of JDK internals? No objection to the change of course, I'm curious why we are doing this. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24124#issuecomment-2747329517
