On Tue, 25 Feb 2025 21:35:22 GMT, Vladimir Ivanov wrote:
> The 'size' parameters was used instead of hardcoded constant to improve
> support for different sizes.
LGTM. The results of the benchmarks would be comparable with older benchmarks.
-
Marked as reviewed by pminborg (Review
On Fri, 21 Feb 2025 07:01:42 GMT, Nicole Xu wrote:
>> The UnsafeOps JMH benchmark fails with the following error:
>>
>> ```
>> java.lang.IllegalAccessError: class
>> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot
>> access class jdk.internal.misc.Unsafe
On Wed, 26 Feb 2025 07:04:58 GMT, Nicole Xu wrote:
>> Suite `MaskedLogicOpts.maskedLogicOperationsLong512()` failed on both x86
>> and AArch64 with the following error:
>>
>>
>> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>>
>>
>> The variable `long256_arr_idx
On Thu, 20 Feb 2025 09:31:45 GMT, Jatin Bhateja wrote:
> > Sure. Since I am very new to openJDK, I asked my teammate for help to file
> > the follow-up RFE.
> > Here is the https://bugs.openjdk.org/browse/JDK-8350215 with description of
> > the discussed issues.
>
> Hi @xyyNicole ,
>
> I have
On Wed, 26 Feb 2025 06:59:27 GMT, Xiaohong Gong wrote:
> Hi @IvaVladimir , thank you for fixing this benchmark. Could you please tell
> more information about the IOOBE crash (e.g. `size`, `benchmark name`, `arch
> info`, .etc) ? I still cannot figure out why it can fail with IOOBE. Thanks
> s
> Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and
> AArch64 with the following error:
>
>
> java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249
>
>
> The variable `long256_arr_idx` is misused when indexing 'LongVector l2, l3,
> l4, l5' in f
On Tue, 25 Feb 2025 19:06:05 GMT, Vladimir Ivanov wrote:
> Array initialization by parameter was added. Extra constant was used to align
> cycle step with used arrays.
Hi @IvaVladimir , thank you for fixing this benchmark. Could you please tell
more information about the IOOBE crash (e.g. `siz
On Tue, 25 Feb 2025 09:51:08 GMT, Maurizio Cimadamore
wrote:
>> Benchmark results for the latest revision appears performance neutral.
>> bytestacks same as last revision. 11 jobs left in tier 1-3, no failure so
>> far. Also created CSR for this minor behavioral change.
>>
>> Benchmark
On Tue, 25 Feb 2025 23:11:30 GMT, Chen Liang wrote:
> Indeed, the byte access currently only supports read/write (automatically
> aligned). No CAS or bitwise for now in FFM.
Do you know why that is so?
-
PR Comment: https://git.openjdk.org/jdk/pull/23720#issuecomment-2683738533
On Tue, 11 Feb 2025 09:03:24 GMT, SendaoYan wrote:
>> H all,
>>
>> This PR add `/native` keyword in the test header for virtual thread tests.
>> The `/native` keyword will make run the related tests by jtreg standalone
>> more friendly.
>>
>> I runed all the tests without -nativepath argument
On Tue, 25 Feb 2025 17:11:30 GMT, Severin Gehwolf wrote:
>>> This needs to explain exactly what is happening when. The current comment
>>> isn't even remotely explaining in detail what it does. What does "...
>>> handles the case when a process is moved between cgroups" mean exactly?
>>
>> Eit
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Tue, 25 Feb 2025 23:58:21 GMT, Justin Lu wrote:
> Please review this PR which prevents an `AIOOBE` from leaking out when
> `java.util.Calendar.Builder` is used to build a Japanese calendar with an era
> value too large.
>
> Note that we don't check under `BEFORE_MEIJI`/0 as historically Jap
Please review this PR which prevents an `AIOOBE` from leaking out when
`java.util.Calendar.Builder` is used to build a Japanese calendar with an era
value too large.
Note that we don't check under `BEFORE_MEIJI`/0 as historically Japanese
calendar ignores negative values during normalization. S
Core reflection's generic signature parsing system is used for many aspects,
including annotations and enclosing methods, yet it is under-tested. It is
better for us to set up tests to ensure that sensitive error behaviors of core
reflection remain the same across implementation updates, such as
On Fri, 21 Feb 2025 20:14:19 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Mon, 24 Feb 2025 19:46:52 GMT, Naoto Sato wrote:
> Removing the support for /etc/timezone file that is Debian distro specific.
> The file is no longer considered authoritative
> (https://wiki.debian.org/TimeZoneChanges#Check_Configured_Timezone), and in
> fact, it is now out of sync as the
On Mon, 24 Feb 2025 19:46:52 GMT, Naoto Sato wrote:
> Removing the support for /etc/timezone file that is Debian distro specific.
> The file is no longer considered authoritative
> (https://wiki.debian.org/TimeZoneChanges#Check_Configured_Timezone), and in
> fact, it is now out of sync as the
On Fri, 21 Feb 2025 20:14:19 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Tue, 25 Feb 2025 19:42:01 GMT, Sunmisc Unsafe wrote:
>> Is it possible to use getAndSet instead of cas-loop on #pend?
>>
>> final Task t = tail.getAndSet(task);
>> t.next = task;
>>
>> but that would require a new head field to bypass, probably not worth the
>> gamble if the footprint incre
On Sat, 22 Feb 2025 00:20:29 GMT, Alexey Semenyuk wrote:
> Support the use of a custom msi wrapper executable when building an exe
> installer.
>
> Put `installer.exe` file in the resource directory and jpackage will use it
> instead of the default `msiwrapper.exe` resource for exe installer.
On Tue, 25 Feb 2025 21:38:58 GMT, Claes Redestad wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> We no longer load DelegateMH as we no longer rebind
>
> src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.j
On Tue, 25 Feb 2025 17:23:07 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Standardize parameter checking
>
> test/jdk/java/util/concurrent/tck/ForkJoinPool20Test.java line 649:
>
>> 647:
On Tue, 25 Feb 2025 22:21:46 GMT, Chen Liang wrote:
>> Core reflection's generic signature parsing uses an ancient library with
>> outdated visitor pattern on a tree model and contains unnecessary
>> boilerplates. This is a duplication of ClassFile API's signature model. We
>> should just move
On Tue, 25 Feb 2025 17:21:56 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Standardize parameter checking
>
> test/jdk/java/util/concurrent/tck/ForkJoinPool20Test.java line 630:
>
>> 628:
> Core reflection's generic signature parsing uses an ancient library with
> outdated visitor pattern on a tree model and contains unnecessary
> boilerplates. This is a duplication of ClassFile API's signature model. We
> should just move to ClassFile API, which is more throughoutly tested as we
On Wed, 5 Feb 2025 17:06:57 GMT, Shaojin Wen wrote:
>> This is an optimization for decimal Integer.parseInt and Long.parseLong,
>> which improves performance by about 10%. The optimization includes:
>> 1. Improve performance by parsing 2 numbers at a time, which has performance
>> improvements
On Tue, 25 Feb 2025 02:45:46 GMT, Chen Liang wrote:
> Remove the intrinsicData field. We can obtain this from the customized MH
> when we spin ultra-customized lambda forms. In the long run, we aim to remove
> this intrinsic if there is no regression for call site sharing.
>
> The existing tab
On Tue, 25 Feb 2025 17:06:31 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Standardize parameter checking
>
> test/jdk/java/util/concurrent/tck/ForkJoinPool20Test.java line 577:
>
>> 575:
On Tue, 25 Feb 2025 06:37:08 GMT, Hannes Greule wrote:
>> Remove the intrinsicData field. We can obtain this from the customized MH
>> when we spin ultra-customized lambda forms. In the long run, we aim to
>> remove this intrinsic if there is no regression for call site sharing.
>>
>> The exis
On Mon, 24 Feb 2025 19:18:27 GMT, Alexey Semenyuk wrote:
> - Unify TKit.createTempDirectory() and TKit.createTempFile() functions.
> Remove `throws IOexception` from their signatures. Add relevant tests.
> - JPackageCommand.java: remove try/catch(IOexception) around
> `TKit.createTempDirectory
On Mon, 24 Feb 2025 23:45:37 GMT, Chen Liang wrote:
>> LF editor spins classes, this avoids the spinning overhead and should speed
>> up non-capturing lambdas too.
>>
>> There may need to be additional intrinsic work for MH combinator lf bytecode
>> generation.
>
> Chen Liang has updated the p
Remove the intrinsicData field. We can obtain this from the customized MH when
we spin ultra-customized lambda forms. In the long run, we aim to remove this
intrinsic if there is no regression for call site sharing.
The existing tableSwitch combinator's LF is unnecessarily complex. This patch
a
On Tue, 25 Feb 2025 02:45:46 GMT, Chen Liang wrote:
> Remove the intrinsicData field. We can obtain this from the customized MH
> when we spin ultra-customized lambda forms. In the long run, we aim to remove
> this intrinsic if there is no regression for call site sharing.
>
> The existing tab
The 'size' parameters was used instead of hardcoded constant to improve support
for different sizes.
-
Commit messages:
- JDK-8350701 [JMH] test foreign.AllocFromSliceTest failed with Exception for
size>1024
Changes: https://git.openjdk.org/jdk/pull/23785/files
Webrev: https://w
On Tue, 25 Feb 2025 17:04:20 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Standardize parameter checking
>
> test/jdk/java/util/concurrent/tck/ForkJoinPool20Test.java line 523:
>
>> 521:
On Tue, 25 Feb 2025 15:48:29 GMT, Alexey Semenyuk wrote:
>> - Unify TKit.createTempDirectory() and TKit.createTempFile() functions.
>> Remove `throws IOexception` from their signatures. Add relevant tests.
>> - JPackageCommand.java: remove try/catch(IOexception) around
>> `TKit.createTempDirec
On Tue, 25 Feb 2025 14:51:29 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Standardize parameter checking
>
> src/java.base/share/classes/java/util/concurrent/DelayScheduler.java line 455:
>
>> 453
On Tue, 25 Feb 2025 14:46:07 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Standardize parameter checking
>
> src/java.base/share/classes/java/util/concurrent/DelayScheduler.java line 356:
>
>> 354
On Tue, 25 Feb 2025 20:50:46 GMT, Michael Hall wrote:
> It always packages a runtime for mine
Right. When jpackage is used to bundle an app (which is the most common use
case) it automatically adds Java runtime to the app image.
However, jpackage can be used to bundle standalone Java runtime w
> On Feb 25, 2025, at 1:41 PM, Alexey Semenyuk wrote:
>
> On Tue, 25 Feb 2025 19:24:46 GMT, Michael Hall wrote:
>
>> Again I?ve been assuming type dmg builds.
>
> Me too. jpackage can package Java runtime in a dmg.
>
> -
>
> PR Comment: https://git.openjdk.org/jdk/pull/23752#i
On Tue, 25 Feb 2025 17:15:43 GMT, Naoto Sato wrote:
> This seems to imply that as of 2016, /etc/timezone is a redundant file. Our
> supported Debian distros (as of JDK23) are Ubuntu 24.04LTS and 24.10, so I
> think we are OK just remove the support for /etc/timezone
Okay, although I expect the
On Mon, 24 Feb 2025 19:46:52 GMT, Naoto Sato wrote:
> Removing the support for /etc/timezone file that is Debian distro specific.
> The file is no longer considered authoritative
> (https://wiki.debian.org/TimeZoneChanges#Check_Configured_Timezone), and in
> fact, it is now out of sync as the
On Tue, 25 Feb 2025 14:37:49 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Standardize parameter checking
>
> src/java.base/share/classes/java/util/concurrent/DelayScheduler.java line 99:
>
>> 97:
On Thu, 20 Feb 2025 22:35:07 GMT, Sunmisc Unsafe wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottlen
On Tue, 25 Feb 2025 19:24:46 GMT, Michael Hall wrote:
> Again I?ve been assuming type dmg builds.
Me too. jpackage can package Java runtime in a dmg.
-
PR Comment: https://git.openjdk.org/jdk/pull/23752#issuecomment-2683097211
> On Feb 25, 2025, at 12:42 PM, Alexey Semenyuk wrote:
>
> On Tue, 25 Feb 2025 17:40:46 GMT, Michael Hall wrote:
>
>> Yes, actually I think they should always be warned the cli option is ignored
>> or has no effect.
>
> Even if the cli option has a value that is not ignored because it is e
Array initialization by parameter was added. Extra constant was used to align
cycle step with used arrays.
-
Commit messages:
- 8350682 [JMH] vector.IndexInRangeBenchmark failed with
IndexOutOfBoundsException for size=1024
Changes: https://git.openjdk.org/jdk/pull/23783/files
We
On Tue, 25 Feb 2025 17:40:46 GMT, Michael Hall wrote:
> Yes, actually I think they should always be warned the cli option is ignored
> or has no effect.
Even if the cli option has a value that is not ignored because it is equal to
the default one? Why issue a warning if the value of the option
On Wed, 5 Feb 2025 23:41:19 GMT, Chen Liang wrote:
> `MethodHandles.byteArrayViewVarHandle` exposes checked multi-byte access to
> byte arrays via VarHandle. This larger access speeds up many operations, yet
> it cannot be used in early bootstrap, and as a result, people tend to use
> `Unsafe`
On Sun, 23 Feb 2025 15:26:48 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
> On Feb 25, 2025, at 11:15 AM, Alexey Semenyuk wrote:
>
> On Tue, 25 Feb 2025 16:27:51 GMT, Michael Hall wrote:
>
>> ignore it silently
>
> I don't like it. If they pass a cli option ignored by jpackage, we should
> warn them.
>
>> But I still myself don?t see what any directory has to d
On Mon, 24 Feb 2025 23:33:01 GMT, Sergey Chernyshev
wrote:
>> `CgroupV1Controller::set_subsystem_path` needs high level comment update to
>> describe the logic happening.
>>
>> Testing:
And after the patch this would become this, right?
```
/sys/fs/cgroup/cpu,cpuacct/system.slice/g
On Tue, 25 Feb 2025 06:53:03 GMT, Jaikiran Pai wrote:
> Hello Naoto, this looks reasonable to me. Do you think we should add a
> release note for this change?
Good point. I will draft a release note for this change.
-
PR Comment: https://git.openjdk.org/jdk/pull/23755#issuecomment
On Tue, 25 Feb 2025 17:11:18 GMT, Naoto Sato wrote:
>> Hello Naoto, this looks reasonable to me. Do you think we should add a
>> release note for this change?
>
>> Hello Naoto, this looks reasonable to me. Do you think we should add a
>> release note for this change?
>
> Good point. I will dra
On Tue, 25 Feb 2025 16:27:51 GMT, Michael Hall wrote:
> ignore it silently
I don't like it. If they pass a cli option ignored by jpackage, we should warn
them.
> But I still myself don?t see what any directory has to do with a dmg
We need to put a directory on the right side from the copy arr
On Tue, 25 Feb 2025 16:31:05 GMT, Sergey Chernyshev
wrote:
>> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 42:
>>
>>> 40: * When runs in a container, the method handles the case
>>> 41: * when a process is moved between cgroups.
>>> 42: */
>>
>> This needs to explain exactly what i
On Sun, 23 Feb 2025 15:26:48 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
On Tue, 25 Feb 2025 01:14:05 GMT, Alexander Matveev
wrote:
>>> This one is confusing. It will evaluate to true if both != null
>>
>> Correct. They both shouldn't be `true`. One of them must be `true`, and
>> another one must be `false`.
>>
>>> Did you mean "&&" instead of "=="?
>>
>> No. I m
On Tue, 25 Feb 2025 14:06:03 GMT, Severin Gehwolf wrote:
> This needs to explain exactly what is happening when. The current comment
> isn't even remotely explaining in detail what it does. What does "... handles
> the case when a process is moved between cgroups" mean exactly?
Either it shall
> - Fix the warning message about the custom installation directory location
> jpackage issues for DMG runtime packaging.
> - Don't issue the warning when the `-install-dir` value equals the default
> installation directory location.
> - Add relevant tests.
Alexey Semenyuk has updated the pull
> On Feb 25, 2025, at 10:20 AM, Alexey Semenyuk wrote:
>
> On Tue, 25 Feb 2025 03:28:46 GMT, Michael Hall wrote:
>
>> I would think a warning should just indicate that ?install-dir is always
>> ignored for dmg builds.
>
> Do you suggest bringing back the behavior of jpackage that always is
On Tue, 25 Feb 2025 03:28:46 GMT, Michael Hall wrote:
> I would think a warning should just indicate that ?install-dir is always
> ignored for dmg builds.
Do you suggest bringing back the behavior of jpackage that always issued the
warning when the `--install-dir` option is used with DMG packa
On Fri, 21 Feb 2025 20:14:19 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
> - Unify TKit.createTempDirectory() and TKit.createTempFile() functions.
> Remove `throws IOexception` from their signatures. Add relevant tests.
> - JPackageCommand.java: remove try/catch(IOexception) around
> `TKit.createTempDirectory()` call.
> - AppImagePackageTest.java: replace `TKit.crea
On Wed, 12 Feb 2025 19:55:29 GMT, Stuart Marks wrote:
> A couple adjustments to the specs for four methods of StringBuilder and
> StringBuffer so that they no longer require new Strings to be created, just a
> String with the right contents. No implementation changes. Note that the
> actual sp
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Sun, 23 Feb 2025 18:53:33 GMT, Thomas Schatzl wrote:
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
On Sun, 23 Feb 2025 18:53:33 GMT, Thomas Schatzl wrote:
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
On Sun, 23 Feb 2025 18:53:33 GMT, Thomas Schatzl wrote:
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
Hi all,
please review this change that implements (currently Draft) JEP: G1: Improve
Application Throughput with a More Efficient Write-Barrier.
The reason for posting this early is that this is a large change, and the JEP
process is already taking very long with no end in sight but we would
On Fri, 7 Feb 2025 12:39:24 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of t
On Sun, 23 Feb 2025 15:26:48 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
On Sun, 23 Feb 2025 15:26:48 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
On Fri, 21 Feb 2025 20:17:09 GMT, Chen Liang wrote:
>>> I have disabled them with #, and the status is confirmed by test for access
>>> modes. I kept the infra to make future reenabling easy.
>>
>> Doh - I missed the `#` -- maybe add few more to make that more explicit? (I
>> agree with the ap
On Sun, 23 Feb 2025 15:26:48 GMT, Doug Lea wrote:
>> (Copied from https://bugs.openjdk.org/browse/JDK-8319447)
>>
>> The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
>> both ill-suited for many (if not most) of its applications, and is a
>> performance bottleneck (a
On Mon, 24 Feb 2025 21:20:49 GMT, Sergey Chernyshev
wrote:
>> Cgroup V1 subsustem fails to initialize mounted controllers properly in
>> certain cases, that may lead to controllers left undetected/inactive. We
>> observed the behavior in CloudFoundry deployments, it affects also host
>> syste
On Mon, 24 Feb 2025 23:33:01 GMT, Sergey Chernyshev
wrote:
>> `CgroupV1Controller::set_subsystem_path` needs high level comment update to
>> describe the logic happening.
>>
>> Testing:
And after the patch this would become this, right?
```
/sys/fs/cgroup/cpu,cpuacct/system.slice/g
On Tue, 25 Feb 2025 07:21:31 GMT, Tagir F. Valeev wrote:
>> It appears that the benchmark was erroneous. The combination of "tailMap"
>> mode and comparator = true didn't work correctly, as the comparator is
>> descending. This PR changes the benchmark to use headMap instead of tailMap
>> in c
On Tue, 25 Feb 2025 07:21:31 GMT, Tagir F. Valeev wrote:
>> It appears that the benchmark was erroneous. The combination of "tailMap"
>> mode and comparator = true didn't work correctly, as the comparator is
>> descending. This PR changes the benchmark to use headMap instead of tailMap
>> in c
On Tue, 25 Feb 2025 10:02:51 GMT, Per Minborg wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review remarks, dates, some more simplifications
>
> src/java.base/share/classes/java/lang/invoke/SegmentVarHandle.java li
On Tue, 11 Feb 2025 20:56:39 GMT, Coleen Phillimore wrote:
> Class.isInterface() can check modifier flags, Class.isArray() can check
> whether component mirror is non-null and Class.isPrimitive() needs a new
> final transient boolean in java.lang.Class that the JVM code initializes.
> Tested wi
On Mon, 24 Feb 2025 19:30:41 GMT, Coleen Phillimore wrote:
>> Class.isInterface() can check modifier flags, Class.isArray() can check
>> whether component mirror is non-null and Class.isPrimitive() needs a new
>> final transient boolean in java.lang.Class that the JVM code initializes.
>> Teste
On Tue, 25 Feb 2025 01:27:04 GMT, Stuart Marks wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tweaking @implNote for better rendering.
>
> src/java.logging/share/classes/java/util/logging/Formatter.java line 94:
On Tue, 25 Feb 2025 01:18:35 GMT, Stuart Marks wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tweaking @implNote for better rendering.
>
> src/java.logging/share/classes/java/util/logging/Handler.java line 163:
On Tue, 25 Feb 2025 01:17:21 GMT, Stuart Marks wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tweaking @implNote for better rendering.
>
> src/java.logging/share/classes/java/util/logging/Handler.java line 80:
>
On Tue, 25 Feb 2025 01:12:55 GMT, Stuart Marks wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tweaking @implNote for better rendering.
>
> src/java.logging/share/classes/java/util/logging/Handler.java line 62:
>
On Fri, 21 Feb 2025 20:14:19 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Mon, 24 Feb 2025 17:53:36 GMT, Chen Liang wrote:
>> Maybe let's leave it, at least in this round
>
> Done in latest update.
Thanks! I think it looks very good!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/23720#discussion_r1969396191
On Mon, 24 Feb 2025 19:11:23 GMT, Chen Liang wrote:
> I think direct var handles are quite cheap already and don't really need
> caching. What really worth caching should be the combinators and the VH
> derived from those combinators.
Right -- and one big advantage of this PR, if I'm correct,
On Fri, 21 Feb 2025 22:19:08 GMT, Chen Liang wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review remarks, dates, some more simplifications
>
> Benchmark results for the latest revision appears performance neutral.
On Fri, 21 Feb 2025 20:14:19 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Tue, 25 Feb 2025 00:54:24 GMT, Stuart Marks wrote:
>> A couple adjustments to the specs for four methods of StringBuilder and
>> StringBuffer so that they no longer require new Strings to be created, just
>> a String with the right contents. No implementation changes. Note that the
>> actua
On Thu, 31 Oct 2024 05:43:11 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Mon, 24 Feb 2025 08:09:00 GMT, Adam Sotona wrote:
> j.l.classfile package-summary contains many code snippets.
> Some of the shorter snippets are embedded in the javadoc and therefore are
> not validated by the tests.
> One embedded code snippet contains a typo, and two snippets do not reflec
On Mon, 24 Feb 2025 08:09:00 GMT, Adam Sotona wrote:
> j.l.classfile package-summary contains many code snippets.
> Some of the shorter snippets are embedded in the javadoc and therefore are
> not validated by the tests.
> One embedded code snippet contains a typo, and two snippets do not reflec
96 matches
Mail list logo
