On Tue, 25 Feb 2025 14:06:03 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:

> This needs to explain exactly what is happening when. The current comment 
> isn't even remotely explaining in detail what it does. What does "... handles 
> the case when a process is moved between cgroups" mean exactly?

Either it shall be a high level comment such as in your suggestion 
[here](https://github.com/openjdk/jdk/pull/21808#pullrequestreview-2620718790), 
or a deeper description in detail what happens where. Could you please be more 
specific on what kind of description is required and where? Please note the 
method has inline comments that are fairly self describing. In the meanwhile 
I'll try to add a description of what "a process is moved between cgroups" 
exactly means.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21808#discussion_r1970137041

Reply via email to