Integrated: 8350041: Skip test/jdk/java/lang/String/nativeEncoding/StringPlatformChars.java on static JDK

On Fri, 14 Feb 2025 18:31:52 GMT, Jiangli Zhou wrote: > Please review the fix to make > `java/lang/String/nativeEncoding/StringPlatformChars.java` jtreg test: > > - Lookup `JNU_GetStringPlatformChars`, `JNU_ClassString` and > `JNU_NewStringPlatform` dynamically > - Remove `#include "jni_util.

Re: RFR: 8349860: Make Class.isArray(), Class.isInterface() and Class.isPrimitive() non-native [v7]

> Class.isInterface() can check modifier flags, Class.isArray() can check > whether component mirror is non-null and Class.isPrimitive() needs a new > final transient boolean in java.lang.Class that the JVM code initializes. > Tested with tier1-4 and performance tests. Coleen Phillimore has upda

Re: RFR: 8349860: Make Class.isArray(), Class.isInterface() and Class.isPrimitive() non-native [v5]

On Fri, 21 Feb 2025 21:08:33 GMT, Dean Long wrote: >> Indeed, even though this checks for the specific bit so widening has no >> effect, it is better to be cautious here. > >> I don't use the field directly because the field is a short and getModifiers >> makes it into Modifier. > > But getMod

Re: RFR: 8326447: jpackage creates Windows installers that cannot be signed [v3]

> Support the use of a custom msi wrapper executable when building an exe > installer. > > Put `installer.exe` file in the resource directory and jpackage will use it > instead of the default `msiwrapper.exe` resource for exe installer. > > To test this feature created a test that builds exe in

Re: RFR: 8319447: Improve performance of delayed task handling [v3]

> (Copied from https://bugs.openjdk.org/browse/JDK-8319447) > > The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is > both ill-suited for many (if not most) of its applications, and is a > performance bottleneck (as seen especially in Loom and CompletableFuture > usages

Re: RFR: 8024695: new File("").exists() returns false whereas it is the current working directory [v9]

On Fri, 21 Feb 2025 19:00:32 GMT, Brian Burkhalter wrote: >> Modify the implementation of `java.io.File` so that it correctly handles the >> empty path `""`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8024695: Add

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

On Fri, 21 Feb 2025 17:10:24 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 146: > >> 144: * and invoke

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

On Fri, 21 Feb 2025 17:16:55 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 187: > >> 185: * are used. I

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

On Fri, 21 Feb 2025 17:38:00 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 3526: > >> 3524: if (

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

On Fri, 21 Feb 2025 17:23:23 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2585: > >> 2583: * throw

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

On Fri, 21 Feb 2025 17:11:31 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 160: > >> 158: * do not incl

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

On Fri, 21 Feb 2025 16:52:41 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/ForkJoinTask.java line 1668: > >> 1666:

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

On Fri, 21 Feb 2025 16:34:32 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java line > 2947: > >> 2945:

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

On Fri, 21 Feb 2025 16:28:15 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback > > src/java.base/share/classes/java/util/concurrent/CompletableFuture.java line > 2840: > >> 2838:

Re: RFR: 8319447: Improve performance of delayed task handling [v2]

On Fri, 21 Feb 2025 17:30:46 GMT, Alan Bateman wrote: >> Added: >> Delayed actions become enabled and behave as ordinary submitted >> tasks when their delays elapse. > > Thanks. Also here we have ".. after the given delay, At which" so need to > smooth that out. OK. I also renamed executeRea