On Thu, 20 Feb 2025 03:15:39 GMT, Brian Burkhalter wrote:
>> Update the specification of `java.io.File.exists()` to match its behavior,
>> which seems correct in the context of how the empty abstract pathname is
>> documented elsewhere in the class.
>
> Brian Burkhalter has updated the pull req
On Fri, 14 Feb 2025 02:23:40 GMT, SendaoYan wrote:
> Hi all,
>
> The newly added JMH tests
> 'org.openjdk.bench.jdk.incubator.vector.VectorMultiplyOptBenchmark' fails
> "java.lang.NoClassDefFoundError: jdk/incubator/vector/Float16" by below test
> command:
>
>
> make test MICRO="FORK=1;WARM
On Tue, 18 Feb 2025 09:58:50 GMT, SendaoYan wrote:
>> Hi all,
>>
>> The newly added JMH tests
>> 'org.openjdk.bench.jdk.incubator.vector.VectorMultiplyOptBenchmark' fails
>> "java.lang.NoClassDefFoundError: jdk/incubator/vector/Float16" by below test
>> command:
>>
>>
>> make test MICRO="FO
On Tue, 18 Feb 2025 09:58:50 GMT, SendaoYan wrote:
>> Hi all,
>>
>> The newly added JMH tests
>> 'org.openjdk.bench.jdk.incubator.vector.VectorMultiplyOptBenchmark' fails
>> "java.lang.NoClassDefFoundError: jdk/incubator/vector/Float16" by below test
>> command:
>>
>>
>> make test MICRO="FO
On Wed, 19 Feb 2025 21:05:47 GMT, Jiangli Zhou wrote:
> * No `jlink` tool in `static-jdk` when running on static JDK. This is
> currently observable using the `static-jdk`.
> * No separate `lib/modules` file (and other JDK resource files) if we build a
> single hermetic Java image for the test.
On Fri, 7 Feb 2025 12:39:24 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of t
On Wed, 19 Feb 2025 19:50:50 GMT, Evgeny Astigeevich
wrote:
>> I will run a comparison next with the same batch of tests but looking at
>> `int` and see if there are any differences compared with `long` or not.
>
> Hi @galderz,
> Results from Graviton 3(Neoverse-V1).
> Without the patch:
>
> B
On Tue, 18 Feb 2025 09:24:38 GMT, Prajwal Kumaraswamy
wrote:
> Document supported usage of jlink with JDK jmod's
> The document will reflect the future work from JDK-8347831
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/23672
On Tue, 18 Feb 2025 09:24:38 GMT, Prajwal Kumaraswamy
wrote:
> Document supported usage of jlink with JDK jmod's
> The document will reflect the future work from JDK-8347831
Closing out this PR, since it will be taken care in JDK-8347831
-
PR Comment: https://git.openjdk.org/jdk/p
On Thu, 20 Feb 2025 02:50:17 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename isPrimitiveType field to primitive.
>
> src/java.base/share/classes/java/lang/Class.java line 1297:
>
>> 1
On Wed, 19 Feb 2025 20:04:33 GMT, Joe Wang wrote:
> The schema file is integral to the test, so we assume it will be present. A
> minor improvement would be to remove the conditional check that verifies its
> existence. This would allow the test to fail if it can't load the schema file.
Do you
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revi
On Wed, 19 Feb 2025 08:02:07 GMT, Claes Redestad wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use SetupCopyFiles macro to copy the dependency files
>
> If you have manually verified that the build fails if any of t
On Fri, 14 Feb 2025 07:21:27 GMT, SendaoYan wrote:
> Hi all,
>
> Several JMH tests fails 'Cannot invoke "java.io.InputStream.available()"
> because "is" is null', because the file
> 'build/linux-x86_64-server-release/images/test/micro/benchmarks.jar' missing
> the required xml input file defi
On Wed, 19 Feb 2025 20:30:34 GMT, Coleen Phillimore wrote:
>> Class.isInterface() can check modifier flags, Class.isArray() can check
>> whether component mirror is non-null and Class.isPrimitive() needs a new
>> final transient boolean in java.lang.Class that the JVM code initializes.
>> Teste
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote:
> As is suggested in
> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
> be used consistently in microbenchmarks to 'align with the intuition that
> when you use jvmArgsAppend/-Prepend intent is to add to a set of
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote:
> As is suggested in
> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
> be used consistently in microbenchmarks to 'align with the intuition that
> when you use jvmArgsAppend/-Prepend intent is to add to a set of
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote:
> As is suggested in
> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
> be used consistently in microbenchmarks to 'align with the intuition that
> when you use jvmArgsAppend/-Prepend intent is to add to a set of
On Thu, 13 Feb 2025 20:04:05 GMT, Chen Liang wrote:
>> As is suggested in
>> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
>> be used consistently in microbenchmarks to 'align with the intuition that
>> when you use jvmArgsAppend/-Prepend intent is to add to a se
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote:
> As is suggested in
> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
> be used consistently in microbenchmarks to 'align with the intuition that
> when you use jvmArgsAppend/-Prepend intent is to add to a set of
On Thu, 13 Feb 2025 08:35:47 GMT, Nicole Xu wrote:
> As is suggested in
> [JDK-8342958](https://bugs.openjdk.org/browse/JDK-8342958), `jvmArgs` should
> be used consistently in microbenchmarks to 'align with the intuition that
> when you use jvmArgsAppend/-Prepend intent is to add to a set of
> This fix makes some minor changes to the internals of the
> `CertificateBuilder` and `SimpleOCSPServer` test classes. They would break
> when ML-DSA was selected as key and signing algorithms. Also RSASSA-PSS
> works better now with these changes. I've also taken this opportunity to do
> s
On Tue, 11 Feb 2025 20:56:39 GMT, Coleen Phillimore wrote:
> Class.isInterface() can check modifier flags, Class.isArray() can check
> whether component mirror is non-null and Class.isPrimitive() needs a new
> final transient boolean in java.lang.Class that the JVM code initializes.
> Tested wi
On Tue, 18 Feb 2025 02:36:13 GMT, Julian Waters wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolutions
>
> Is anyone else getting compile failures after this was integrated? This
> weirdly se
On Thu, 13 Feb 2025 22:29:46 GMT, Jamil Nimeh wrote:
>> Also, should it be moved to somewhere else like
>> jdk/test/sun/security/provider/certpath?
>
>> Also, should it be moved to somewhere else like
>> jdk/test/sun/security/provider/certpath?
>
> Hmmm...not sure about that, but maybe an exp
> Class.isInterface() can check modifier flags, Class.isArray() can check
> whether component mirror is non-null and Class.isPrimitive() needs a new
> final transient boolean in java.lang.Class that the JVM code initializes.
> Tested with tier1-4 and performance tests.
Coleen Phillimore has upda
On Wed, 19 Feb 2025 14:19:58 GMT, Coleen Phillimore wrote:
> ... but not in the return since the caller likely will fetch the klass
> pointer next.
I notice that too. Callers are using is_primitive() to short-circuit calls to
as_Klass(), which means they seem to be aware of this implementatio
On Wed, 19 Feb 2025 07:33:02 GMT, Alan Bateman wrote:
> > This part however feels odd. Updating this (and other tests in future) to
> > use the `@requires !jdk.static` to identify the presence or absence of a
> > specific tool in the JDK installation doesn't seem right. Perhaps they
> > should
On Wed, 19 Feb 2025 19:36:59 GMT, Roger Riggs wrote:
>> Ough, this test puzzled me. It fails with --enable-preview. However, I think
>> I need more time to investigate the issue. So I update PR to exclude test
>> that explicitly says that it shouldn't be executed with --enable-preview.
>
> It r
On Fri, 14 Feb 2025 07:44:26 GMT, SendaoYan wrote:
> Hi all,
>
> Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes
> unexpectedly when missing the depentdent file
> test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a
> NULL check after call `get
On Wed, 19 Feb 2025 05:01:53 GMT, David Holmes wrote:
>> Class.isInterface() can check modifier flags, Class.isArray() can check
>> whether component mirror is non-null and Class.isPrimitive() needs a new
>> final transient boolean in java.lang.Class that the JVM code initializes.
>> Tested wit
On Wed, 19 Feb 2025 17:43:54 GMT, Galder Zamarreño wrote:
>> Galder Zamarreño has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 44 additional
>> c
On Wed, 19 Feb 2025 17:49:57 GMT, Leonid Mesnik wrote:
>> It might be useful to be able to run testing with --enable-preview for
>> feature development. The tests incompatible with this mode must be filtered
>> out.
>>
>> I chose name 'java.enablePreview' , because it is more java property tha
On Wed, 19 Feb 2025 17:43:10 GMT, Leonid Mesnik wrote:
>> test/jdk/java/lang/System/SecurityManagerWarnings.java line 28:
>>
>>> 26: * @bug 8266459 8268349 8269543 8270380
>>> 27: * @summary check various warnings
>>> 28: * @requires !java.enablePreview
>>
>> What is the reason that this tes
On Fri, 14 Feb 2025 00:56:03 GMT, Joe Wang wrote:
> Fix an edge case in the patch for JDK-8207760.
This pull request has now been integrated.
Changeset: 4e60c2d9
Author:Joe Wang
URL:
https://git.openjdk.org/jdk/commit/4e60c2d937fca8170b356f36e72b271104130c40
Stats: 127 lines in
> Class.isInterface() can check modifier flags, Class.isArray() can check
> whether component mirror is non-null and Class.isPrimitive() needs a new
> final transient boolean in java.lang.Class that the JVM code initializes.
> Tested with tier1-4 and performance tests.
Coleen Phillimore has upda
On Wed, 19 Feb 2025 06:54:50 GMT, Jaikiran Pai wrote:
> On a more general note, is it a goal to have the static JDK build run against
> all these tests that are part of the JDK repo? Would that mean that a lot of
> these will have to start using `@requires` to accomodate this?
Running static J
On Wed, 19 Feb 2025 03:21:37 GMT, SendaoYan wrote:
>> Hi all,
>>
>> Several JMH tests fails 'Cannot invoke "java.io.InputStream.available()"
>> because "is" is null', because the file
>> 'build/linux-x86_64-server-release/images/test/micro/benchmarks.jar' missing
>> the required xml input fil
On Wed, 19 Feb 2025 15:42:54 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/Class.java line 1009:
>>
>>> 1007: private transient Object classData; // Set by VM
>>> 1008: private transient Object[] signers; // Read by VM, mutable
>>> 1009: private final transient char
On Wed, 19 Feb 2025 06:54:50 GMT, Jaikiran Pai wrote:
>> Jiangli Zhou has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase.
>
> On a more general note, is it a goal to have the
On Wed, 19 Feb 2025 17:10:09 GMT, Coleen Phillimore wrote:
>> It was. Before the componentType field was reused for the class
>> initialization monitor int array, and it caused problems with core
>> reflection if a program reflectively accesses this field after a few hundred
>> times. See [JDK
On Wed, 19 Feb 2025 15:07:57 GMT, Roger Riggs wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code review comments.
>
> src/hotspot/share/prims/jvm.cpp line 2284:
>
>> 2282: // Please, refer to the descriptio
On Mon, 17 Feb 2025 08:28:05 GMT, Alan Bateman wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> change other test to exclude
>
> test/jdk/java/lang/System/SecurityManagerWarnings.java line 28:
>
>> 26: * @bug 826
> It might be useful to be able to run testing with --enable-preview for
> feature development. The tests incompatible with this mode must be filtered
> out.
>
> I chose name 'java.enablePreview' , because it is more java property than vm
> or jdk. And 'enablePreview' to be similar with jtreg t
On Fri, 7 Feb 2025 12:39:24 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of t
On Fri, 7 Feb 2025 12:39:24 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of t
On Wed, 19 Feb 2025 00:16:13 GMT, Joe Wang wrote:
>> Fix an edge case in the patch for JDK-8207760.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add tests verifying invalid sequence; also add tests to verify cases where
> t
On Wed, 19 Feb 2025 16:19:22 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/Class.java line 1287:
>>
>>> 1285: */
>>> 1286: public Class getComponentType() {
>>> 1287: // Only return for array types. Storage may be reused for
>>> Class for instance types.
>>
>
On Wed, 19 Feb 2025 02:54:05 GMT, Dean Long wrote:
>> Class.isInterface() can check modifier flags, Class.isArray() can check
>> whether component mirror is non-null and Class.isPrimitive() needs a new
>> final transient boolean in java.lang.Class that the JVM code initializes.
>> Tested with t
On Tue, 11 Feb 2025 20:56:39 GMT, Coleen Phillimore wrote:
> Class.isInterface() can check modifier flags, Class.isArray() can check
> whether component mirror is non-null and Class.isPrimitive() needs a new
> final transient boolean in java.lang.Class that the JVM code initializes.
> Tested wi
On Fri, 14 Feb 2025 14:52:38 GMT, Alexey Semenyuk wrote:
> 8350102: Decouple jpackage test-lib Executor.Result and Executor classes
This pull request has now been integrated.
Changeset: 3487f8cb
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/3487f8cbd55b06d332d897a01
On Tue, 18 Feb 2025 09:56:21 GMT, David Beaumont wrote:
>I'm afraid I don't see how the double-check idea would work...
Yep. I missed that case.
>The other option is to just allow the lock to be dropped.
The other options are many. Leader-follower pattern would allow FileHandler to
not hold
(Copied from https://bugs.openjdk.org/browse/JDK-8319447)
The problems addressed by this CR/PR are that ScheduledThreadPoolExecutor is
both ill-suited for many (if not most) of its applications, and is a
performance bottleneck (as seen especially in Loom and CompletableFuture
usages). After con
On Tue, 11 Feb 2025 20:56:39 GMT, Coleen Phillimore wrote:
> Class.isInterface() can check modifier flags, Class.isArray() can check
> whether component mirror is non-null and Class.isPrimitive() needs a new
> final transient boolean in java.lang.Class that the JVM code initializes.
> Tested wi
On Wed, 19 Feb 2025 03:30:04 GMT, Dean Long wrote:
>> Class.isInterface() can check modifier flags, Class.isArray() can check
>> whether component mirror is non-null and Class.isPrimitive() needs a new
>> final transient boolean in java.lang.Class that the JVM code initializes.
>> Tested with t
On Wed, 19 Feb 2025 07:53:15 GMT, Nicole Xu wrote:
> The UnsafeOps JMH benchmark fails with the following error:
>
> java.lang.IllegalAccessError: class
> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot
> access class jdk.internal.misc.Unsafe (in module java.b
On Wed, 19 Feb 2025 14:23:04 GMT, Per Minborg wrote:
> This PR proposes to add the `final` keyword to some classes and methods in
> order to assist compiler devirtualization (e.g. in Graal native image).
>
> Passes `make test TEST=jdk_foreign`
Looks simple and trivial.
-
Marked a
This PR proposes to add the `final` keyword to some classes and methods in
order to simplify compiler devirtualization (e.g. in Graal native image).
Passes `make test TEST=jdk_foreign`
-
Commit messages:
- Make methods and classes final
Changes: https://git.openjdk.org/jdk/pull/23
On Wed, 19 Feb 2025 05:08:36 GMT, David Holmes wrote:
>> Class.isInterface() can check modifier flags, Class.isArray() can check
>> whether component mirror is non-null and Class.isPrimitive() needs a new
>> final transient boolean in java.lang.Class that the JVM code initializes.
>> Tested wit
On Tue, 11 Feb 2025 20:56:39 GMT, Coleen Phillimore wrote:
> Class.isInterface() can check modifier flags, Class.isArray() can check
> whether component mirror is non-null and Class.isPrimitive() needs a new
> final transient boolean in java.lang.Class that the JVM code initializes.
> Tested wi
On Tue, 11 Feb 2025 20:56:39 GMT, Coleen Phillimore wrote:
> Class.isInterface() can check modifier flags, Class.isArray() can check
> whether component mirror is non-null and Class.isPrimitive() needs a new
> final transient boolean in java.lang.Class that the JVM code initializes.
> Tested wi
On Wed, 19 Feb 2025 13:35:16 GMT, Jorn Vernee wrote:
>> This PR proposes to clarify the documentation for two of the
>> `MemorySegment::reinterpret` overloads.
>
> Marked as reviewed by jvernee (Reviewer).
Thanks for the review @JornVernee! I am going to let this PR sit for an extra
day in cas
On Wed, 19 Feb 2025 02:54:36 GMT, Chen Liang wrote:
>> I don't know if we have a style guide that covers this, but I believe the
>> method and field could both be named `isPrimitive`.
>
> I would personally name such a boolean field `primitive`, but I don't have a
> strong preference on the fie
On Wed, 19 Feb 2025 03:21:37 GMT, SendaoYan wrote:
>> Hi all,
>>
>> Several JMH tests fails 'Cannot invoke "java.io.InputStream.available()"
>> because "is" is null', because the file
>> 'build/linux-x86_64-server-release/images/test/micro/benchmarks.jar' missing
>> the required xml input fil
On Wed, 19 Feb 2025 09:14:03 GMT, Per Minborg wrote:
> This PR proposes to clarify the documentation for two of the
> `MemorySegment::reinterpret` overloads.
Marked as reviewed by jvernee (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23688#pullrequestreview-2626820343
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote:
> This change adds an API note to these methods recommending that the caller
> should perform further validation steps on the code signers that signed the
> JAR file, such as validating the code signer's certificate chain, and
> determining
On Tue, 18 Feb 2025 23:06:42 GMT, Ian Myers wrote:
>> make/common/Modules.gmk line 95:
>>
>>> 93: SPEC_SUBDIRS += share/specs
>>> 94:
>>> 95: MAN_SUBDIRS += share/man windows/man
>>
>> Hm, normally I'd say you should use `$(TARGET_OS)/man`, but we typically
>> generate docs for all platforms
On Wed, 19 Feb 2025 10:43:06 GMT, Marcono1234 wrote:
>> This change adds an API note to these methods recommending that the caller
>> should perform further validation steps on the code signers that signed the
>> JAR file, such as validating the code signer's certificate chain, and
>> determin
> From: "Viktor Klang"
> To: "Remi Forax" , "Fabian Meumertzheim"
>
> Cc: "Paul Sandoz" , "core-libs-dev"
>
> Sent: Wednesday, February 19, 2025 11:43:33 AM
> Subject: Re: [External] : Re: JDK-8072840: Presizing for Stream Collectors
> Might be possible to extract the "descriptive" accessors to
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote:
> This change adds an API note to these methods recommending that the caller
> should perform further validation steps on the code signers that signed the
> JAR file, such as validating the code signer's certificate chain, and
> determining
Might be possible to extract the "descriptive" accessors to a superinterface of
Spliterator.
And Gatherer could either transform an incoming such instance to an estimated
outbound instance, plus an overload of initializer, and Collector would likely
only need the supplier overload.
Cheers,
√
On Wed, 19 Feb 2025 07:53:15 GMT, Nicole Xu wrote:
> The UnsafeOps JMH benchmark fails with the following error:
>
> java.lang.IllegalAccessError: class
> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot
> access class jdk.internal.misc.Unsafe (in module java.b
On Wed, 19 Feb 2025 07:53:15 GMT, Nicole Xu wrote:
> The UnsafeOps JMH benchmark fails with the following error:
>
> java.lang.IllegalAccessError: class
> org.openjdk.bench.sun.misc.UnsafeOps (in unnamed module @0x520a3426) cannot
> access class jdk.internal.misc.Unsafe (in module java.b
The UnsafeOps JMH benchmark fails with the following error:
java.lang.IllegalAccessError: class org.openjdk.bench.sun.misc.UnsafeOps
(in unnamed module @0x520a3426) cannot access class jdk.internal.misc.Unsafe
(in module java.base) because module java.base does not export
jdk.internal.mis
This PR proposes to make all imports consistent in the FFM API tests and
benchmarks.
This is a follow-up PR from https://github.com/openjdk/jdk/pull/22827
Passes tier1-3
-
Commit messages:
- Merge branch 'master' into fix-imports-tests
- Fix copyright year
- Fix imports
Changes
This PR proposes to clarify the documentation for two of the
`MemorySegment::reinterpret` overloads.
-
Commit messages:
- Revise MemorySegment::reinterpret docs
Changes: https://git.openjdk.org/jdk/pull/23688/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23688&range=00
On Wed, 19 Feb 2025 08:02:07 GMT, Claes Redestad wrote:
> have manually verified that the build fails if any of these files are removed.
Yes. I have verified that. If I remove the dependency XML file, then `make
test-image CONF=release JOBS=1` will report below failure.
gmake[3]: *** No rule
On Wed, 19 Feb 2025 03:21:37 GMT, SendaoYan wrote:
>> Hi all,
>>
>> Several JMH tests fails 'Cannot invoke "java.io.InputStream.available()"
>> because "is" is null', because the file
>> 'build/linux-x86_64-server-release/images/test/micro/benchmarks.jar' missing
>> the required xml input fil
On Tue, 18 Feb 2025 09:24:38 GMT, Prajwal Kumaraswamy
wrote:
> Document supported usage of jlink with JDK jmod's
> The document will reflect the future work from JDK-8347831
There are several issues with the proposed update. I think it would be better
to close this PR and we'll update the jlin
79 matches
Mail list logo
