On Tue, 18 Feb 2025 23:06:42 GMT, Ian Myers <imy...@openjdk.org> wrote:

>> make/common/Modules.gmk line 95:
>> 
>>> 93: SPEC_SUBDIRS += share/specs
>>> 94: 
>>> 95: MAN_SUBDIRS += share/man windows/man
>> 
>> Hm, normally I'd say you should use `$(TARGET_OS)/man`, but we typically 
>> generate docs for all platforms at the same time. So I guess this is okay.
>
> Hi @magicus we are seeing build failures because linux builds contain man 
> pages for windows-only tools as reported by 
> https://bugs.openjdk.org/browse/JDK-8350137. Would replacing `windows/man` 
> with `$(TARGET_OS)/man` prevent windows-only tools man pages being generated 
> for linux builds?

I think it will prevent windows-only tools man pages from being generated in 
linux builds, but it would prevent the man pages from appearing in the 
generated documentation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23351#discussion_r1961472101

Reply via email to