On Tue, 18 Feb 2025 02:36:13 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments resolutions > > Is anyone else getting compile failures after this was integrated? This > weirdly seems to only happen on Linux > > * For target hotspot_variant-server_libjvm_objs_mulnode.o: > /home/runner/work/jdk/jdk/src/hotspot/share/opto/mulnode.cpp: In member > function ‘virtual const Type* FmaHFNode::Value(PhaseGVN*) const’: > /home/runner/work/jdk/jdk/src/hotspot/share/opto/mulnode.cpp:1944:37: error: > call of overloaded ‘make(double)’ is ambiguous > 1944 | return TypeH::make(fma(f1, f2, f3)); > | ^ > In file included from > /home/runner/work/jdk/jdk/src/hotspot/share/opto/node.hpp:31, > from > /home/runner/work/jdk/jdk/src/hotspot/share/opto/addnode.hpp:28, > from > /home/runner/work/jdk/jdk/src/hotspot/share/opto/mulnode.cpp:26: > /home/runner/work/jdk/jdk/src/hotspot/share/opto/type.hpp:544:23: note: > candidate: ‘static const TypeH* TypeH::make(float)’ > 544 | static const TypeH* make(float f); > | ^~~~ > /home/runner/work/jdk/jdk/src/hotspot/share/opto/type.hpp:545:23: note: > candidate: ‘static const TypeH* TypeH::make(short int)’ > 545 | static const TypeH* make(short f); > | ^~~~ @TheShermanTanker I don't see any compile failures on Linux. Both the fastdebug and release build successfully. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22754#issuecomment-2669979058
