On Wed, 19 Feb 2025 03:21:37 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Hi all, >> >> Several JMH tests fails 'Cannot invoke "java.io.InputStream.available()" >> because "is" is null', because the file >> 'build/linux-x86_64-server-release/images/test/micro/benchmarks.jar' missing >> the required xml input file defined by >> test/micro/org/openjdk/bench/javax/xml/AbstractXMLMicro.java. This PR copy >> the required xml file to benchmarks.jar, and remove two unexist xml input >> file. >> >> After this PR, below JMH tests will run passes. >> >> >> org.openjdk.bench.javax.xml.DOM.testBuild >> org.openjdk.bench.javax.xml.DOM.testModify >> org.openjdk.bench.javax.xml.DOM.testWalk >> org.openjdk.bench.javax.xml.SAXUsingJDK.testParse >> org.openjdk.bench.javax.xml.STAX.testParse >> >> >> Test command: >> >> >> rm -rf build/jmh-result/ ; mkdir -p build/jmh-result/ ; time for test in >> `cat list.txt` ; do time make test TEST="micro:$test" >> MICRO="FORK=1;WARMUP_ITER=2" CONF=release &> build/jmh-result/$test.log ; >> done >> >> >> Change has been verified locally, no risk. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > Use SetupCopyFiles macro to copy the dependency files If you have manually verified that the build fails if any of these files are removed then I'm happy. No new tests or documentation needed, really. I could cast my vote towards removing these particular micros. But as the work is done I say let's accept your change, (re-)evaluate their usefulness, and file a RFE to have them removed if they aren't. We have been building out the set of micros we regularly test in nightly / promotion testing, but due to resource constraints only a fraction is run on a regular basis - and javax.xml has not been a priority. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23625#issuecomment-2667842084
