Re: RFR: 8342869: Errors related to unused code on Windows after 8339120 in awt

2024-12-10 Thread Julian Waters
On Fri, 25 Oct 2024 10:11:57 GMT, Magnus Ihse Bursie wrote: >> It's a checkout error from the original gigantic Pull Request, sorry. I >> don't plan to raise the JDK to C++17 in this one. But I'm not sure what to >> do with this now, since maybe_unused is C++17. I don't think anyone is going >

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v7]

2024-12-10 Thread Julian Waters
On Mon, 11 Nov 2024 09:51:35 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u

Withdrawn: 8341944: The zlib library no longer requires dummy byte for raw inflate

2024-12-10 Thread duke
On Fri, 11 Oct 2024 08:11:37 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes overrides of > `InflaterInputStream.fill` in `ZipFileInflaterInputStream` and > `ZipFileSystem::getInputStream`. Associated boolean fields used to track > `eof` are also removed. > > These ov

Re: RFR: 8345805: Update copyright year to 2024 for other files where it was missed [v2]

2024-12-10 Thread David Holmes
On Mon, 9 Dec 2024 21:02:03 GMT, Magnus Ihse Bursie wrote: >> Some files have been modified in 2024, but the copyright year has not been >> properly updated. This should be fixed. >> >> I have located these modified files using: >> >> git log --since="Jan 1" --name-only --pretty=format: | sor

Re: RFR: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image [v11]

2024-12-10 Thread Chen Liang
On Fri, 15 Nov 2024 17:36:46 GMT, Henry Jen wrote: >> This PR split out large array/set construction into separate factory methods >> to avoid oversized method trying to construct several of those. >> >> In order to do that, we will need to generate those help methods on demand >> in the class

RFR: 8344802: Crash in StubRoutines::verify_mxcsr with -XX:+EnableX86ECoreOpts and -Xcheck:jni

2024-12-10 Thread Volodymyr Paprotski
@TobiHartmann There are still some unanswered questions I have, but committing this since we need to work around vacation schedules. **This in fact happens on both Windows _AND_ Linux.** However, _only_ on Windows there is a crash. This fix fixes the crash but I don't understand entirely why t

Re: RFC: Untangle native libraries and the JVM: SVML, SLEEF, and libsimdsort

2024-12-10 Thread Vladimir Ivanov
Thanks, Maurizio. On 12/9/24 03:42, Maurizio Cimadamore wrote: Great work Vlad! The simdsort part seems a more "classic" FFM binding - where you have a method handle per entry point. That seems to fit the design of FFM rather well. In the second case (SVML/SLEEF) usage of FFM is limited to b

Re: RFC: Untangle native libraries and the JVM: SVML, SLEEF, and libsimdsort

2024-12-10 Thread Vladimir Ivanov
On 12/9/24 07:55, Paul Sandoz wrote: Some further observations. - This arguably makes it harder for the auto-vectorize to access the SVML/SLEEF functionality. However, in comes cases, we cannot guarantee the same guarantees (IIRC mainly around monotonicity) as the scalar operations in Math.

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v5]

2024-12-10 Thread Mandy Chung
On Tue, 10 Dec 2024 12:06:19 GMT, Severin Gehwolf wrote: >> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` >> without explicit `--module-path` option or a non-existent module path. In >> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and >>

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v5]

2024-12-10 Thread Mandy Chung
On Tue, 10 Dec 2024 23:33:08 GMT, Mandy Chung wrote: >> Severin Gehwolf has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Handle non-existent module-path with ALL-MODULE-PATH >> - Move test, more test fixes for JEP 493 enabled builds >

Re: RFR: 8310996: Add JFR event for connect operations [v8]

2024-12-10 Thread Tim Prinzing
> Adds a JFR event for socket connect operations. > > Existing tests TestSocketEvents and TestSocketChannelEvents modified to also > check for connect events. Tim Prinzing has updated the pull request incrementally with one additional commit since the last revision: requests fixes - Use

Re: RFR: 8345799: Update copyright year to 2024 for core-libs in files where it was missed [v3]

2024-12-10 Thread Phil Race
On Tue, 10 Dec 2024 09:31:21 GMT, Prasanta Sadhukhan wrote: > not sure why client label is added, no java.desktop/accessibility files are > in there I was puzzling over that too. - PR Comment: https://git.openjdk.org/jdk/pull/22640#issuecomment-2532895836

[jdk24] RFR: 8342469: Improve API documentation for java.lang.classfile.instruction

2024-12-10 Thread Chen Liang
Hi all, This pull request contains a backport of commit [0f035545](https://github.com/openjdk/jdk/commit/0f035545e5c0cd02d11ab8edd5786c1f1f6043a7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This is a noreg-doc backport - these additions are clarifications to the ClassFile

Integrated: 8342469: Improve API documentation for java.lang.classfile.instruction

2024-12-10 Thread Chen Liang
On Mon, 21 Oct 2024 22:43:42 GMT, Chen Liang wrote: > Improve the documentation for classfile instructions. Includes links to all > opcodes, usage notes for instructions, and other various fixes. > > API Diff: > https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html > Jav

Re: RFR: 8345773: Class-File API debug printing capability [v4]

2024-12-10 Thread Chen Liang
On Mon, 9 Dec 2024 18:09:21 GMT, Adam Sotona wrote: >> Class-File API lost debug printing capability with removal of the >> `j.l.classfile.components.ClassPrinter` in JDK-8345343. >> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to >> restore the capability. >> >> Please r

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v6]

2024-12-10 Thread Chen Liang
On Wed, 4 Dec 2024 18:41:53 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html >

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update [v2]

2024-12-10 Thread Justin Lu
On Tue, 10 Dec 2024 09:27:42 GMT, Severin Gehwolf wrote: >> Justin Lu has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - implement Severin's review >> >>Co-authored-by: Severin Gehwolf >> - implement Jan's review >> - implemen

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update [v2]

2024-12-10 Thread Justin Lu
On Tue, 10 Dec 2024 09:31:57 GMT, Jan Lahoda wrote: >> Justin Lu has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - implement Severin's review >> >>Co-authored-by: Severin Gehwolf >> - implement Jan's review >> - implement Hen

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update [v2]

2024-12-10 Thread Severin Gehwolf
On Tue, 10 Dec 2024 19:35:21 GMT, Justin Lu wrote: >> Please review this PR which contains the open L10n drop changes for RDP1. >> >> I recommend viewing the improved diffs which are built out by Jon's tool >> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the >> corr

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update [v2]

2024-12-10 Thread Justin Lu
On Tue, 10 Dec 2024 00:40:23 GMT, Henry Jen wrote: >> Justin Lu has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - implement Severin's review >> >>Co-authored-by: Severin Gehwolf >> - implement Jan's review >> - implement Henr

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update [v2]

2024-12-10 Thread Justin Lu
On Tue, 10 Dec 2024 18:04:30 GMT, Weijun Wang wrote: >> Justin Lu has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - implement Severin's review >> >>Co-authored-by: Severin Gehwolf >> - implement Jan's review >> - implement He

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update [v2]

2024-12-10 Thread Justin Lu
> Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctness on the quality of the translations themselves. >

Re: RFR: 8345335: Add excluded jdk_foreign tests to manual group [v3]

2024-12-10 Thread Jorn Vernee
On Tue, 10 Dec 2024 16:12:55 GMT, Ivan Šipka wrote: >> @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore >> @JornVernee >> >> adding as manual tests > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > both t

Re: RFR: 8345883: Relax system property "stackwalk.debug" in StackStreamFactory to be case insensitive

2024-12-10 Thread Mandy Chung
On Tue, 10 Dec 2024 11:16:55 GMT, Eirik Bjørsnøs wrote: > Please review this PR which relaxes the interpretation of the system property > `stackwalk.debug` in `java.lang.StackStreamFactory` to be case insensitive. > > Motivation: > Only 5 of 83 boolean system properties in `java.base` have a ca

Re: RFR: 8345185: Some tests in test/jdk/tools/jpackage fail with a JDK without JMODs

2024-12-10 Thread Alexey Semenyuk
On Tue, 10 Dec 2024 16:20:42 GMT, Alan Bateman wrote: > That would only make sense if jpackage can work without jlink It can. It invokes the jlink only if external runtime is not supplied, which is likely the default setup in most cases. jlink dependency is optional but required in common use

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-10 Thread Weijun Wang
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v10]

2024-12-10 Thread Paul Sandoz
On Tue, 10 Dec 2024 16:10:09 GMT, Quan Anh Mai wrote: >> Hi, >> >> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly >> just the revert of the backout. >> >> Regarding the related issues: >> >> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and >> [JDK-83

Re: RFR: 8345185: Some tests in test/jdk/tools/jpackage fail with a JDK without JMODs

2024-12-10 Thread Mandy Chung
On Mon, 9 Dec 2024 12:57:22 GMT, Severin Gehwolf wrote: > Please review these changes to jpackage in light of [JEP > 493](https://openjdk.org/jeps/493). When this feature is enabled, then some > of the `jpackage` tests fail. The failures fall into the following categories: > > - `ALL-DEFAULT`

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v9]

2024-12-10 Thread Jatin Bhateja
On Tue, 10 Dec 2024 08:34:30 GMT, Jatin Bhateja wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change wording on VectorLoadShuffleNode >> >> Co-authored-by: Jatin Bhateja > > I am observing some performance

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v10]

2024-12-10 Thread Jatin Bhateja
On Tue, 10 Dec 2024 16:10:09 GMT, Quan Anh Mai wrote: >> Hi, >> >> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly >> just the revert of the backout. >> >> Regarding the related issues: >> >> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and >> [JDK-83

Re: RFR: 8345883: Relax system property "stackwalk.debug" in StackStreamFactory to be case insensitive

2024-12-10 Thread Eirik Bjørsnøs
On Tue, 10 Dec 2024 16:01:13 GMT, Roger Riggs wrote: > But there is no need for boolean properties to be case insensitive. Indeed. Seems like a matter of style choice, or perhaps often just determined a bit by chance or by the APIs picked to perform the evaluation. Some like their tabs, other

Re: RFR: 8345335: Add excluded jdk_foreign tests to manual group [v3]

2024-12-10 Thread Ivan Šipka
> @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore > @JornVernee > > adding as manual tests Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision: both tests declared automatic, labeled as jdk_foreign_stress and that gro

Re: RFR: 8345185: Some tests in test/jdk/tools/jpackage fail with a JDK without JMODs

2024-12-10 Thread Alexey Semenyuk
On Mon, 9 Dec 2024 12:57:22 GMT, Severin Gehwolf wrote: > Please review these changes to jpackage in light of [JEP > 493](https://openjdk.org/jeps/493). When this feature is enabled, then some > of the `jpackage` tests fail. The failures fall into the following categories: > > - `ALL-DEFAULT`

Re: RFR: 8345185: Some tests in test/jdk/tools/jpackage fail with a JDK without JMODs

2024-12-10 Thread Alan Bateman
On Tue, 10 Dec 2024 16:07:00 GMT, Alexey Semenyuk wrote: > Will changing `requires jdk.jlink;` to `requires static jdk.jlink;` let > include `jdk.jpackage` without `jdk.jlink`? That would only make sense if jpackage can work without jlink, meaning all the options for creating a run-time image

Re: RFR: 8345883: Relax system property "stackwalk.debug" in StackStreamFactory to be case insensitive

2024-12-10 Thread Roger Riggs
On Tue, 10 Dec 2024 11:16:55 GMT, Eirik Bjørsnøs wrote: > Please review this PR which relaxes the interpretation of the system property > `stackwalk.debug` in `java.lang.StackStreamFactory` to be case insensitive. > > Motivation: > Only 5 of 83 boolean system properties in `java.base` have a ca

Re: RFR: 8345335: Add excluded jdk_foreign tests to manual group [v3]

2024-12-10 Thread Ivan Šipka
On Tue, 10 Dec 2024 16:12:55 GMT, Ivan Šipka wrote: >> @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore >> @JornVernee >> >> adding as manual tests > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > both t

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-10 Thread Alexey Semenyuk
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v8]

2024-12-10 Thread Quan Anh Mai
On Tue, 10 Dec 2024 09:02:40 GMT, Jatin Bhateja wrote: >> This is called in an `assert` so I think throwing `AssertionError` seems >> more reasonable, the original implementation also throws `AssertionError` > > I see, you want to throw an error here and not just use an assert statement > that

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v9]

2024-12-10 Thread Quan Anh Mai
On Tue, 10 Dec 2024 08:34:30 GMT, Jatin Bhateja wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change wording on VectorLoadShuffleNode >> >> Co-authored-by: Jatin Bhateja > > I am observing some performance

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v10]

2024-12-10 Thread Quan Anh Mai
> Hi, > > This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly just > the revert of the backout. > > Regarding the related issues: > > - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and > [JDK-8309531](https://bugs.openjdk.org/browse/JDK-8309531) have been fix

Re: Copyright update tedium

2024-12-10 Thread Archie Cobbs
Hi Thomas, On Tue, Dec 10, 2024 at 4:45 AM Thomas Stüfe wrote: > Note that we have a script for that; see > make/scripts/update_copyright_year.sh . I use it a lot. Sonia recently > enhanced it. It even has an option to update copyrights for foreign > companies. > Awesome - thanks for the pointe

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-10 Thread Pavel Rappo
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

RFR: 8345883: Relax system property "stackwalk.debug" in StackStreamFactory to be case insensitive

2024-12-10 Thread Eirik Bjørsnøs
Please review this PR which relaxes the interpretation of the system property `stackwalk.debug` in `java.lang.StackStreamFactory` to be case insensitive. Motivation: Only 5 of 83 boolean system properties in `java.base` have a case sensitive interpretation. Relaxing these to be case insensitive

[jdk24] RFR: 8345818: Fix SM cleanup of parsing of System property resource.bundle.debug

2024-12-10 Thread Roger Riggs
Backport this trivial fix to parsing of the system property "resource.bundle.debug" to jdk24. - Commit messages: - Backport 4f855d1342d55aeee93b7d0c5796fbfd4994c856 Changes: https://git.openjdk.org/jdk/pull/22664/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22664&range=

Integrated: 8345818: Fix SM cleanup of parsing of System property resource.bundle.debug

2024-12-10 Thread Roger Riggs
On Mon, 9 Dec 2024 17:22:14 GMT, Roger Riggs wrote: > Replace broken getProperty with Boolean.getBoolean. > > Manual testing confirms trace messages are enabled with > `-Dresource.bundle.debug=true` This pull request has now been integrated. Changeset: 4f855d13 Author:Roger Riggs URL:

Re: RFR: 8343962: [REDO] Move getChars to DecimalDigits [v4]

2024-12-10 Thread Shaojin Wen
On Tue, 10 Dec 2024 12:24:34 GMT, Claes Redestad wrote: >> Shaojin Wen has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 17 additional >> commits

Re: RFR: 8343962: [REDO] Move getChars to DecimalDigits [v5]

2024-12-10 Thread Shaojin Wen
> This PR is a resubmission after PR #21593 was rolled back, and the unsafe > offset overflow issue has been fixed. > > 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to > reduce duplication. > > 2) HexDigits and OctalDigits also include getCharsLatin1 and getCharsUTF

Re: RFR: 8345573: Module dependencies not resolved from run-time image when --limit-module is being used

2024-12-10 Thread Severin Gehwolf
On Mon, 9 Dec 2024 17:34:25 GMT, Severin Gehwolf wrote: > I'll merge master later today/tomorrow which might fix this. And it did indeed fix it. - PR Comment: https://git.openjdk.org/jdk/pull/22609#issuecomment-2531793418

[jdk24] Integrated: 8345465: Fix performance regression on x64 after JDK-8345120

2024-12-10 Thread Per Minborg
On Tue, 10 Dec 2024 12:38:57 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit > [06c44dd5](https://github.com/openjdk/jdk/commit/06c44dd568d91e1bd68f60fd3e57abcbe97e5dca) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bein

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-10 Thread Weijun Wang
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: [jdk24] RFR: 8345465: Fix performance regression on x64 after JDK-8345120

2024-12-10 Thread Jorn Vernee
On Tue, 10 Dec 2024 12:38:57 GMT, Per Minborg wrote: > Hi all, > > This pull request contains a backport of commit > [06c44dd5](https://github.com/openjdk/jdk/commit/06c44dd568d91e1bd68f60fd3e57abcbe97e5dca) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bein

[jdk24] RFR: 8345465: Fix performance regression on x64 after JDK-8345120

2024-12-10 Thread Per Minborg
Hi all, This pull request contains a backport of commit [06c44dd5](https://github.com/openjdk/jdk/commit/06c44dd568d91e1bd68f60fd3e57abcbe97e5dca) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Per Minborg on 10 Dec 2024 and was revi

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v6]

2024-12-10 Thread Adam Sotona
On Wed, 4 Dec 2024 18:41:53 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html >

Re: RFR: 8343962: [REDO] Move getChars to DecimalDigits [v4]

2024-12-10 Thread Claes Redestad
On Mon, 9 Dec 2024 06:24:21 GMT, Shaojin Wen wrote: >> This PR is a resubmission after PR #21593 was rolled back, and the unsafe >> offset overflow issue has been fixed. >> >> 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to >> reduce duplication. >> >> 2) HexDigit

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path [v5]

2024-12-10 Thread Severin Gehwolf
> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` > without explicit `--module-path` option or a non-existent module path. In > addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and > `--limit-modules` are used in combination. It failed earlier an

Re: RFR: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path

2024-12-10 Thread Severin Gehwolf
On Fri, 6 Dec 2024 18:33:06 GMT, Mandy Chung wrote: > Such behavioral change is a good change as jlink from the default and > --generate-linkable-runtime build would have the consistent behavior. If a > module path is given with no root module (empty path), it throws the > following error. I t

Re: RFR: 8196106: Support nested infinite or recursive flat mapped streams [v8]

2024-12-10 Thread Viktor Klang
On Wed, 27 Nov 2024 16:01:53 GMT, Michel Charpentier wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing review feedback > > I just noticed this improved performance in Java 23. However, it still > doesn't

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-10 Thread Jan Lahoda
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-10 Thread Jan Lahoda
On Tue, 10 Dec 2024 00:05:45 GMT, Henry Jen wrote: >> Oh you're right. That's odd though. But the translations aren't wrong then. > > `每个 是\n限定的程序包名称.` > We use here, but the args format is using Chinese translation,`= > [-]<程序包>(,[-]<程序包>)*` > > Should that be consistent? Regarding `''` - p

Re: Copyright update tedium

2024-12-10 Thread Thomas Stüfe
Hi Archie, Note that we have a script for that; see make/scripts/update_copyright_year.sh . I use it a lot. Sonia recently enhanced it. It even has an option to update copyrights for foreign companies. Calling it from the source root usually works well, it only still struggles with large merge co

Integrated: 8345465: Fix performance regression on x64 after JDK-8345120

2024-12-10 Thread Per Minborg
On Wed, 4 Dec 2024 08:40:31 GMT, Per Minborg wrote: > This PR proposes to fix a performance regression (on x64 platforms) for > 32-bit strings introduced by > [JDK-8345120](https://bugs.openjdk.org/browse/JDK-8345120). > > The PR also fixes a performance regression in the benchmarks caused by

Re: RFR: 8345465: Fix performance regression on x64 after JDK-8345120 [v4]

2024-12-10 Thread Maurizio Cimadamore
On Tue, 10 Dec 2024 07:30:19 GMT, Per Minborg wrote: >> This PR proposes to fix a performance regression (on x64 platforms) for >> 32-bit strings introduced by >> [JDK-8345120](https://bugs.openjdk.org/browse/JDK-8345120). >> >> The PR also fixes a performance regression in the benchmarks caus

Re: RFR: 8345185: Some tests in test/jdk/tools/jpackage fail with a JDK without JMODs

2024-12-10 Thread Severin Gehwolf
On Mon, 9 Dec 2024 22:04:38 GMT, Alexey Semenyuk wrote: > I don't think it is necessary to exclude jdk.jpackage from the `ALL-DEFAULT` > though if jdk.jlink module should be excluded. As I commented earlier, > jdk.jpackage is functional without the jdk.jlink. You cannot include `jdk.jpackage`

Re: RFR: 8345799: Update copyright year to 2024 for core-libs in files where it was missed [v3]

2024-12-10 Thread Prasanta Sadhukhan
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote: >> Some files have been modified in 2024, but the copyright year has not been >> properly updated. This should be fixed. >> >> I have located these modified files using: >> >> git log --since="Jan 1" --name-only --pretty=format: | sor

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-10 Thread Severin Gehwolf
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v4]

2024-12-10 Thread Galder Zamarreño
On Fri, 29 Nov 2024 11:27:01 GMT, Emanuel Peter wrote: >> Galder Zamarreño has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 30 additional >> comm

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long)

2024-12-10 Thread Galder Zamarreño
On Thu, 7 Nov 2024 10:18:14 GMT, Galder Zamarreño wrote: >> Overall, looks fine. >> >> So, there will be `inline_min_max`, `inline_fp_min_max`, and >> `inline_long_min_max` which slightly vary. I'd prefer to see them unified. >> (Or, at least, enhance `inline_min_max` to cover `minL`/maxL` cas

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v8]

2024-12-10 Thread Jatin Bhateja
On Tue, 10 Dec 2024 08:18:36 GMT, Quan Anh Mai wrote: >> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte512Vector.java >> line 1046: >> >>> 1044: String msg = ("index "+si+"out of range >>> ["+length+"] in "+ >>> 1045: java

Re: RFR: 8331467: ImageReaderFactory can cause a ClassNotFoundException if the default FileSystemProvider is not the system-default provider [v6]

2024-12-10 Thread liyazzi
> For two cases: > > 1. When the ImageReaderFactory was loaded by local jdk,that means the > ImageReaderFactory was loaded by boot class loader,then init the `Path > BOOT_MODULES_JIMAGE` by using `sun.nio.fs.DefaultFileSystemProvider` which is > obtained through reflection,due to it is in jdk i

Re: Copyright update tedium

2024-12-10 Thread Magnus Ihse Bursie
On 2024-12-09 21:39, Joseph D. Darcy wrote: FWIW, when I've thought about the topic of copyright and licenses before, I think there are several aspects that can be separated. One is a syntactic-only check, as the in-flight Skara PR may provide. I think having a syntactic-only check is Skara i

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v9]

2024-12-10 Thread Jatin Bhateja
On Tue, 10 Dec 2024 08:16:19 GMT, Quan Anh Mai wrote: >> Hi, >> >> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly >> just the revert of the backout. >> >> Regarding the related issues: >> >> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and >> [JDK-83

Re: RFR: 8345465: Fix performance regression on x64 after JDK-8345120 [v4]

2024-12-10 Thread Per Minborg
> This PR proposes to fix a performance regression (on x64 platforms) for > 32-bit strings introduced by > [JDK-8345120](https://bugs.openjdk.org/browse/JDK-8345120). > > The PR also fixes a performance regression in the benchmarks caused by using > the wrong type for `MemorySegment`. > > Regr

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v8]

2024-12-10 Thread Jatin Bhateja
On Tue, 10 Dec 2024 08:17:22 GMT, Quan Anh Mai wrote: >> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Double128Vector.java >> line 859: >> >>> 857: .reinterpretAsInts() >>> 858: .intoArray(a, offset); >>> 859: defaul

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v2]

2024-12-10 Thread Quan Anh Mai
On Mon, 9 Dec 2024 13:40:16 GMT, Jatin Bhateja wrote: >> @merykitty do you want me to initiate tier 1 to 3 tests? > >> @PaulSandoz @sviswa7 Thanks for your advice, I have made the PR ready for >> review >> >> @iwanowww Could you take another look at this, please? >> >> @jatin-bhateja Could you

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v8]

2024-12-10 Thread Quan Anh Mai
On Tue, 10 Dec 2024 07:01:27 GMT, Jatin Bhateja wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> adverb order > > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte512Vector.java > line 1046: > >> 10

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-10 Thread Jonathan Lampérth
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v9]

2024-12-10 Thread Quan Anh Mai
On Tue, 10 Dec 2024 07:44:57 GMT, Jatin Bhateja wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change wording on VectorLoadShuffleNode >> >> Co-authored-by: Jatin Bhateja > > src/hotspot/share/opto/library_c

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v9]

2024-12-10 Thread Quan Anh Mai
> Hi, > > This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly just > the revert of the backout. > > Regarding the related issues: > > - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and > [JDK-8309531](https://bugs.openjdk.org/browse/JDK-8309531) have been fix

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v8]

2024-12-10 Thread Quan Anh Mai
On Tue, 10 Dec 2024 07:54:55 GMT, Jatin Bhateja wrote: >> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte128Vector.java >> line 822: >> >>> 820: static final Class ETYPE = byte.class; // used by the JVM >>> 821: >>> 822: Byte128Shuffle(byte[] indices) { >> >>