On Fri, 25 Oct 2024 10:11:57 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> It's a checkout error from the original gigantic Pull Request, sorry. I >> don't plan to raise the JDK to C++17 in this one. But I'm not sure what to >> do with this now, since maybe_unused is C++17. I don't think anyone is going >> to appreciate [[gnu::unused]] inside Windows code > > Then you'll have to create a macro for disabling the unused warnings > (however, I'm not sure how well that would be received). Or fix the bug if it > is actually unused. Or wait until we go to 17. @magicus Sorry for the ping, but I'm a bit confused. Do you know what bug report site Phil is referring to when he says to submit a bug to AWT instead? Is it just the JBS? (There's a little bit of a problem if it is, it is extremely inconvenient to review what to do with the problem areas in the JBS as opposed to a Pull Request, that and no one actually checks the JBS for new issues, so a bug submitted there is doomed to be ignored until the end of time) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21655#discussion_r1879413329
