On Wed, 4 Dec 2024 18:41:53 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html >> Javadoc: >> https://cr.openjdk.org/~liach/javadoc/cf-instr/java.base/java/lang/classfile/instruction/package-summary.html >> >> Please review the associated CSR as well. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 14 commits: > > - Avoid using "record", other cleans > - Merge branch 'master' of https://github.com/openjdk/jdk into > docs/cf-instruction > - Merge branch 'master' of https://github.com/openjdk/jdk into > docs/cf-instruction > - Leftover problems > - typo > - More cleanup > - Remove a few confusions around bad modeling, some missing exceptions, also > the labelless info models > - Non-int constant values > - Further facelift > - Merge branch 'master' of https://github.com/openjdk/jdk into > docs/cf-instruction > - ... and 4 more: https://git.openjdk.org/jdk/compare/79eb77b7...c1517921 Looks good to me, thanks. ------------- Marked as reviewed by asotona (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21625#pullrequestreview-2492182388
