On Wed, 23 Oct 2024 00:09:25 GMT, Brian Burkhalter wrote:
>> Add `isOther` and `available` methods to `FileChannelImpl` and the
>> interfaces to native code and use these in `ChannelInputStream` to work
>> around cases where a wrapped `FileChannelImpl` is not really seekable.
>
> Brian Burkhalt
On Wed, 23 Oct 2024 00:35:19 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/runtime/objectMonitor.hpp line 292:
>>
>>> 290:
>>> 291: static int64_t owner_for(JavaThread* thread);
>>> 292: static int64_t owner_for_oop(oop vthread);
>>
>> Some comments describing this API would be
On Wed, 23 Oct 2024 00:35:06 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
On Wed, 23 Oct 2024 04:20:49 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Tue, 22 Oct 2024 11:52:46 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/lang/VirtualThread.java line 115:
>>
>>> 113: * RUNNING -> WAITING// transitional state during wait
>>> on monitor
>>> 114: * WAITING -> WAITED // waiting on monitor
>>> 115:
On Wed, 23 Oct 2024 00:08:54 GMT, Coleen Phillimore wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5341:
>>
>>> 5339:
>>> 5340: void MacroAssembler::inc_held_monitor_count() {
>>> 5341: Address dst = Address(rthread,
>>> JavaThread::held_monitor_count_offset());
>>
>> Sug
On Wed, 23 Oct 2024 00:35:06 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Wed, 23 Oct 2024 02:06:20 GMT, Joe Darcy wrote:
> Noticed this refactoring opportunity while doing some other work in the area.
src/java.base/share/classes/java/lang/Boolean.java line 259:
> 257: public boolean equals(Object obj) {
> 258: if (obj instanceof Boolean b) {
> 259:
On Tue, 22 Oct 2024 19:04:16 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 2234:
>>
>>> 2232: retry_fast_path = true;
>>> 2233: } else {
>>> 2234: relativize_chunk_concurrently(chunk);
>>
>> Is the `relativize_chunk_concurrently` solu
On Tue, 22 Oct 2024 18:03:12 GMT, Chris Plummer wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Tue, 22 Oct 2024 12:31:24 GMT, Alan Bateman wrote:
>> Okay but
>> 1. We have the current virtual thread
>> 2. We have the current carrier for that virtual thread (which is iotself a
>> java.alng.Thread object
>> 3. We have Thread.setCurrentLockId which ... ? which thread does it update?
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
After 8339120, gcc began catching many different instances of unused code in
the Windows specific codebase. Some of these seem to be bugs. I've taken the
effort to mark out all the relevant globals and locals that trigger the unused
warnings and addressed all of them by commenting out the code a
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
After 8339120, gcc began catching many different instances of unused code in
the Windows specific codebase. Some of these seem to be bugs. I've taken the
effort to mark out all the relevant globals and locals that trigger the unused
warnings and addressed all of them by commenting out the code a
On Tue, 8 Oct 2024 01:24:07 GMT, Chen Liang wrote:
>> That said, can you leave a quick review on CSR
>> https://bugs.openjdk.org/browse/JDK-8340963 too?
>
> I think I will do this in another patch that adds it to `ConstantDescs` -
> there's a place in `ConstantDescs` that could have used it, bu
On Wed, 23 Oct 2024 04:09:37 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Relax displayName spec
>
> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 278:
>
>> 276:
>> 277:
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
On Tue, 22 Oct 2024 04:50:29 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Tue, 22 Oct 2024 16:46:53 GMT, Phil Race wrote:
>> Not specific to JEP 486, this should be done as part of a different issue.
>
> agreed
there were many tests modified in javax_swing in this PR where the author tag
is removed, only this is missed so I pointed it out...
-
PR Rev
Discovered this small cleanup while looking at wrapper class code.
-
Commit messages:
- 8342865: Use type parameter for Class::getPrimitiveClass
Changes: https://git.openjdk.org/jdk/pull/21653/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21653&range=00
Issue: https://b
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 22 Oct 2024 16:44:59 GMT, Phil Race wrote:
>> This should be addressed in a more general separate task, and not part of
>> this PR since it does not have anything to do with the changes in this JEP.
>
> Agreed. This is not a "clean up / update tests" task.
> If it is a change on some lin
On Wed, 23 Oct 2024 02:06:20 GMT, Joe Darcy wrote:
> Noticed this refactoring opportunity while doing some other work in the area.
src/java.base/share/classes/java/lang/Long.java line 1249:
> 1247: public boolean equals(Object obj) {
> 1248: if (obj instanceof Long ell) {
> 1249:
Noticed this refactoring opportunity while doing some other work in the area.
-
Commit messages:
- JDK-8342863: Use pattern matching for instanceof in equals methods of
wrapper classes
Changes: https://git.openjdk.org/jdk/pull/21652/files
Webrev: https://webrevs.openjdk.org/?repo
On Mon, 21 Oct 2024 13:17:27 GMT, Magnus Ihse Bursie wrote:
> When trying to sort out the LDFLAGS issues, it turned out that I could not
> run the linux launcher at all, not even when checking out older commits of
> this PR. I am almost at a loss here; I assume that this worked when I created
On Wed, 23 Oct 2024 00:37:25 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/runtime/objectMonitor.hpp line 315:
>>
>>> 313: void set_succesor(oop vthread);
>>> 314: void clear_succesor();
>>> 315: bool has_succesor();
>>
>> Sorry but `successor` has two `s` before
On Wed, 23 Oct 2024 00:35:06 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 22 Oct 2024 15:49:32 GMT, Andrew Haley wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - Fix comments in objectMonitor.hpp
>> - Move frame::saved_thread_address() to platform dependent files
>>
On Tue, 22 Oct 2024 02:09:33 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 380:
>>
>>> 378: lea(t2_owner_addr, owner_address);
>>> 379:
>>> 380: // CAS owner (null => current thread id).
>>
>> I think we should be more careful when an
On Tue, 22 Oct 2024 19:01:02 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 22 Oct 2024 23:48:34 GMT, Mandy Chung wrote:
>> I believe the specification for class or interface display name is too
>> tight: if we have `java.awt.List` versus `java.util.List`, our current
>> implementation prints `List` for both cases. It makes sense for an
>> implementation to pr
On Tue, 22 Oct 2024 23:47:33 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add equals/hashCode implementation; te
On Tue, 22 Oct 2024 06:31:47 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - Fix comments in objectMonitor.hpp
>> - Move frame::saved_thread_address() to platform dependent files
>>
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Tue, 22 Oct 2024 06:27:26 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - Fix comments in objectMonitor.hpp
>> - Move frame::saved_thread_address() to platform dependent files
>>
On Tue, 22 Oct 2024 23:13:26 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 690:
>>
>>> 688: // public int hashCode()
>>> 689: // public static int hashCode(Float16 value)
>>> 690: // public boolean equals(Object obj)
>>
>>
> Add `isOther` and `available` methods to `FileChannelImpl` and the interfaces
> to native code and use these in `ChannelInputStream` to work around cases
> where a wrapped `FileChannelImpl` is not really seekable.
Brian Burkhalter has updated the pull request incrementally with one additional
On Tue, 22 Oct 2024 19:01:02 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 22 Oct 2024 23:29:29 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 278:
>>
>>> 276:
>>> 277: /**
>>> 278: * {@return a human-readable name for this {@code ClassDesc}}
>>
>> I don't see the merit of making the string representation
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Add equals/hashCode implementation; tests to follow.
-
Changes:
- all: https://git.ope
On Tue, 22 Oct 2024 20:35:38 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Tue, 22 Oct 2024 20:53:14 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Relax displayName spec
>
> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 278:
>
>> 276:
>> 277:
On Tue, 22 Oct 2024 22:58:10 GMT, ExE Boss wrote:
> I think it might be a good idea to also have `equalsSymbol(…)` methods for
> the other pool entries.
Indeed, this can avoid promotion to String state for all applicable symbols. I
decide to start with the ClassEntry as this is the most error-
On Tue, 22 Oct 2024 20:01:45 GMT, Paul Sandoz wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains seven additional commits
>> si
On Tue, 22 Oct 2024 14:43:14 GMT, Chen Liang wrote:
>> Currently, to efficiently check if a `ClassEntry`, such as one from an
>> `InvokeInstruction`, is of a particular class, we use such a pattern (as
>> seen in JEP 486 [Appendix](https://openjdk.org/jeps/486#Appendix)):
>>
>> inst.owner().na
On Tue, 22 Oct 2024 22:17:11 GMT, Naoto Sato wrote:
>> This is a regression caused by the fix to
>> [JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the
>> default locale with `user.region` creation is inadvertently broken. Fix is
>> to restore the user.region override within
On Tue, 22 Oct 2024 22:17:11 GMT, Naoto Sato wrote:
>> This is a regression caused by the fix to
>> [JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the
>> default locale with `user.region` creation is inadvertently broken. Fix is
>> to restore the user.region override within
On Tue, 22 Oct 2024 22:17:56 GMT, Alexander Matveev
wrote:
>> - Removed hard check for "Xcode with command line developer tools" when
>> `--mac-sign` is specified and instead we will show information message if
>> `codesign` fails for any reason that possible root cause of failure is
>> missi
On Tue, 22 Oct 2024 01:46:45 GMT, Alexander Matveev
wrote:
> - Removed hard check for "Xcode with command line developer tools" when
> `--mac-sign` is specified and instead we will show information message if
> `codesign` fails for any reason that possible root cause of failure is
> missing X
On Tue, 22 Oct 2024 19:35:55 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8341939: SigningOptionsTest fails without Xcode with command line
>> developer tools after JDK-8341443 [v2]
>
> - Removed hard check for "Xcode with command line developer tools" when
> `--mac-sign` is specified and instead we will show information message if
> `codesign` fails for any reason that possible root cause of failure is
> missing Xcode with command line developer tools.
> - Reason for this is
> This is a regression caused by the fix to
> [JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the default
> locale with `user.region` creation is inadvertently broken. Fix is to restore
> the user.region override within StaticProperty initialization.
Naoto Sato has updated the
> This is a regression caused by the fix to
> [JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the default
> locale with `user.region` creation is inadvertently broken. Fix is to restore
> the user.region override within StaticProperty initialization.
Naoto Sato has updated the
On Tue, 22 Oct 2024 21:28:27 GMT, Roger Riggs wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/jdk/internal/util/StaticProperty.java line 104:
>
>> 102:
On Tue, 22 Oct 2024 21:21:48 GMT, Justin Lu wrote:
> I think ideally the logic could stay in `Locale`, but since the fallback of
> _country/variant_format/display_ `StaticProperty` is based on user.region, it
> makes sense to move the logic to when the fallback is set.
Since `*_DISPLAY/FORMAT`
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 22 Oct 2024 16:22:26 GMT, Brian Burkhalter wrote:
> I assume you'll run the test many tests on all platforms to ensure its
> stability before integrating.
I ran the version of commit f4ab451 30 times on all platforms without failures.
>> test/jdk/java/nio/file/Files/InputStreamTest.jav
> Add `isOther` and `available` methods to `FileChannelImpl` and the interfaces
> to native code and use these in `ChannelInputStream` to work around cases
> where a wrapped `FileChannelImpl` is not really seekable.
Brian Burkhalter has updated the pull request incrementally with one additional
On Tue, 22 Oct 2024 18:09:57 GMT, Naoto Sato wrote:
> This is a regression caused by the fix to
> [JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the default
> locale with `user.region` creation is inadvertently broken. Fix is to restore
> the user.region override within Stat
On Tue, 22 Oct 2024 18:09:57 GMT, Naoto Sato wrote:
> This is a regression caused by the fix to
> [JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the default
> locale with `user.region` creation is inadvertently broken. Fix is to restore
> the user.region override within Stat
On Tue, 22 Oct 2024 19:41:57 GMT, Paul Sandoz wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains seven additional commits
>> si
On Tue, 22 Oct 2024 09:29:38 GMT, Prasanta Sadhukhan
wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNo
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21574/f
On Tue, 22 Oct 2024 08:16:38 GMT, Prasanta Sadhukhan
wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNo
On Tue, 22 Oct 2024 04:50:29 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
On Mon, 21 Oct 2024 17:07:35 GMT, Joe Darcy wrote:
>> Port of Float16 from java.lang in the lworld+fp16 branch to
>> jdk.incubabor.vector.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brough
On Tue, 22 Oct 2024 14:18:33 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains seven additional commi
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21574/f
On Tue, 22 Oct 2024 01:46:45 GMT, Alexander Matveev
wrote:
> - Removed hard check for "Xcode with command line developer tools" when
> `--mac-sign` is specified and instead we will show information message if
> `codesign` fails for any reason that possible root cause of failure is
> missing X
On Tue, 22 Oct 2024 18:22:58 GMT, Daniel Fuchs wrote:
> For PortConfig.java - it would be good to have someone involved in the AIX
> port comment on the proposed changes. Removing the obsolete link altogether
> is also a possibility.
The context for the link in PortConfig.java is:
// The ep
On Tue, 22 Oct 2024 01:46:45 GMT, Alexander Matveev
wrote:
> - Removed hard check for "Xcode with command line developer tools" when
> `--mac-sign` is specified and instead we will show information message if
> `codesign` fails for any reason that possible root cause of failure is
> missing X
On Tue, 22 Oct 2024 11:51:47 GMT, Alan Bateman wrote:
>> src/hotspot/share/runtime/javaThread.cpp line 1545:
>>
>>> 1543: if (is_vthread_mounted()) {
>>> 1544: // _lock_id is the thread ID of the mounted virtual thread
>>> 1545: st->print_cr(" Carrying virtual thread #" INT64_F
On Tue, 22 Oct 2024 17:40:10 GMT, Justin Lu wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove accidental "'"
>
> src/java.base/unix/native/libjava/ProcessImpl_md.c line 109:
>
>> 107: * the jspawnhelper, t
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from this PR.
>
> This is a documentaton-only cleanup. No tests
On Tue, 22 Oct 2024 02:14:23 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/cpu/x86/assembler_x86.cpp line 2866:
>>
>>> 2864: emit_int32(0);
>>> 2865: }
>>> 2866: }
>>
>> Is it possible to make this more general and explicit instead of a sequence
>> of bytes?
>>
>> Something along t
On Tue, 22 Oct 2024 13:51:26 GMT, Axel Boldt-Christmas
wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - Fix comments in objectMonitor.hpp
>> - Move frame::saved_thread_address() to platform dependent f
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
> Changing the charset initialization of `java.io.Console` class, which is the
> basis of `java.io.IO`, so that it would behave the same way as `System.out`
> wrt encoding. This change will also have the capability to override the
> default charset used in `IO` methods with `stdout.encoding` sys
On Thu, 15 Aug 2024 16:23:18 GMT, Dhamoder Nalla wrote:
> Use the GetTempPath2 APIs instead of the GetTempPath APIs in native code
> across the OpenJDK repository to retrieve the temporary directory path, as
> GetTempPath2 provides enhanced security. While GetTempPath may still function
> with
On Thu, 17 Oct 2024 20:45:53 GMT, Mandy Chung wrote:
> The old core reflection implementation generates dynamic classes that are
> special cases in the VM to bypass bytecode verification to workaround various
> issues [1] [2] [3].
>
> The old core reflection implementation was [removed in JDK
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from t
This is a regression caused by the fix to
[JDK-8321206](https://bugs.openjdk.org/browse/JDK-8321206), where the default
locale with `user.region` creation is inadvertently broken. Fix is to restore
the user.region override within StaticProperty initialization.
-
Commit messages:
-
On Tue, 22 Oct 2024 02:40:44 GMT, Brian Burkhalter wrote:
>> Add `isOther` and `available` methods to `FileChannelImpl` and the
>> interfaces to native code and use these in `ChannelInputStream` to work
>> around cases where a wrapped `FileChannelImpl` is not really seekable.
>
> Brian Burkhalt
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from t
On Tue, 22 Oct 2024 10:19:23 GMT, Eirik Bjørsnøs wrote:
> Please review this cleanup PR which updates a total of 12 links to external
> documentation or references in `java.base` to use https instead of plain text
> http.
>
> Links in `java.security` and `share/data/tzdata` are excluded from t
On Wed, 2 Oct 2024 23:16:32 GMT, Justin Lu wrote:
> Please review this PR which improves the safety of equality checking for
> DecimalFormatSymbols. As certain setters did not throw NPE, this allowed for
> NPE in the equality method. This PR now updates the setters to throw NPE.
>
> In additio
On Tue, 22 Oct 2024 16:19:48 GMT, Ioi Lam wrote:
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://gith
On Tue, 22 Oct 2024 16:53:45 GMT, Naoto Sato wrote:
>> Hello Chen, the `{@systemProperty}` tag is expected to be used where the
>> system property is being defined (the "Where should the tag be used?"
>> section in
>> https://mail.openjdk.org/pipermail/core-libs-dev/2018-November/056653.html).
On Tue, 22 Oct 2024 16:26:29 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/lang/System.java line 150:
>>
>>> 148: * specified by the host environment or user. The encoding used
>>> 149: * in the conversion from characters to bytes is equivalent to
>>> 150: * stdout.
> Changing the charset initialization of `java.io.Console` class, which is the
> basis of `java.io.IO`, so that it would behave the same way as `System.out`
> wrt encoding. This change will also have the capability to override the
> default charset used in `IO` methods with `stdout.encoding` sys
On Mon, 21 Oct 2024 15:44:58 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Tue, 22 Oct 2024 15:22:08 GMT, Sean Mullan wrote:
>> test/jdk/javax/swing/JComboBox/8080972/TestBasicComboBoxEditor.java line 26:
>>
>>> 24: import javax.swing.SwingUtilities;
>>> 25: import javax.swing.plaf.basic.BasicComboBoxEditor;
>>> 26: /*
>>
>> I think we have finally decided that jtr
1 - 100 of 173 matches
Mail list logo
