On Wed, 2 Oct 2024 23:16:32 GMT, Justin Lu <j...@openjdk.org> wrote: > Please review this PR which improves the safety of equality checking for > DecimalFormatSymbols. As certain setters did not throw NPE, this allowed for > NPE in the equality method. This PR now updates the setters to throw NPE. > > In addition to the NPEs, there is also a behavioral change that > `setInternationalCurrencySymbol` no longer sets currency to null if the > `currencyCode` is invalid. Instead, it simply does not update `currency`. > This must be done, because we do not want to allow nullable instance > variables post `initalizeCurrency`.
This pull request has now been integrated. Changeset: c61d2c5a Author: Justin Lu <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/c61d2c5a3403ad5f48daad22bdfb031f42bc3dd5 Stats: 152 lines in 2 files changed: 122 ins; 15 del; 15 mod 8341445: DecimalFormatSymbols setters should throw NPE Reviewed-by: naoto ------------- PR: https://git.openjdk.org/jdk/pull/21315
