On Tue, 22 Oct 2024 17:40:10 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove accidental "'" > > src/java.base/unix/native/libjava/ProcessImpl_md.c line 109: > >> 107: * the jspawnhelper, then in the jspawnhelper we do the pre-exec work >> and exec a >> 108: * second time, this time the target binary (similar to the >> "exec-twice-technique" >> 109: * described in >> 'https://mail.openjdk.org/pipermail/core-libs-dev/2018-September/055333.html). > > Unintentional `'` was added. Thanks, good catch! > src/java.base/unix/native/libjava/ProcessImpl_md.c line 204: > >> 202: * References: >> 203: * https://pubs.opengroup.org/onlinepubs/7908799/xsh/exec.html >> 204: * >> https://web.archive.org/web/20090106162458/http://www.pasc.org/interps/unofficial/db/p1003.1/pasc-1003.1-132.html > > The new Wayback link does not resolve for me. It seems the Wayback Machine is suffering a DDOS attack again.. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21633#discussion_r1811254236 PR Review Comment: https://git.openjdk.org/jdk/pull/21633#discussion_r1811254815
