On Tue, 22 Oct 2024 20:53:14 GMT, Mandy Chung <mch...@openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Relax displayName spec
>
> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 278:
> 
>> 276: 
>> 277:     /**
>> 278:      * {@return a human-readable name for this {@code ClassDesc}}
> 
> I don't see the merit of making the string representation unspecified.   The 
> implSpec already specifies the string representation for the display name.   
> Why not just promoting it to normal spec text?

I believe the specification for class or interface display name is too tight: 
if we have `java.awt.List` versus `java.util.List`, our current implementation 
prints `List` for both cases. It makes sense for an implementation to print 
something like `j.a.List` versus `j.u.List`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20665#discussion_r1811560821

Reply via email to