> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> This PR implements the AOT-linking of invokedynamic callsites:
> - We only link lambda expressions (`LambdaMetafactory::metafactory`) and
> string concat (`Stri
> This is the 6th PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> The implementation of java.lang.invoke uses SoftReferences so that unused
> MethodHandles, LambdaForms, etc, can be garbage collected.
>
> However, if we want to store j
On Mon, 21 Oct 2024 17:49:33 GMT, Naoto Sato wrote:
>> Changing the charset initialization of `java.io.Console` class, which is the
>> basis of `java.io.IO`, so that it would behave the same way as `System.out`
>> wrt encoding. This change will also have the capability to override the
>> defau
> Using SharedSecrets, I attempted to expose FileInputStream::path information.
> After implementing the fix, I validated the startup performance tests.
> Observed no consistent pattern of performance drops or gains, can disregard
> the occasional performance drop observed in 1 or 2 runs.
Prasa
On Wed, 16 Oct 2024 22:56:06 GMT, Ashutosh Mehra wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo in last commit; fixed header inclusion order
>
> src/hotspot/share/cds/heapShared.cpp line 675:
>
>> 673:
On Tue, 15 Oct 2024 15:12:44 GMT, Dan Heidinga wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 29 commits:
>>
>> - @DanHeidinga comments -- added ConcurrentHashMap::runtimeSetup() to init
>> NCPU to runtime val
On Mon, 14 Oct 2024 15:54:15 GMT, Dan Heidinga wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed JDK-8341988: jstack launched with AOT cache created with
>> -XX:+AOTClassLinking crashes
>
> src/hotspot/share/cds/ar
> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> This PR implements the AOT-linking of invokedynamic callsites:
> - We only link lambda expressions (`LambdaMetafactory::metafactory`) and
> string concat (`Stri
Thanks Viktor, this was what I was looking for.
Ok, so due to existing difficulties in translating push to pull, it makes
sense why this wouldn't work.
I really look forward to upgrading my codebase soon. Gatherers fixed window
completely negates this problem. At least, it appears to.
On Mon, Oc
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
On 15 Oct 2024, at 12:35, Ioi Lam wrote:
> On Tue, 15 Oct 2024 19:08:20 GMT, Dan Heidinga wrote:
>
>>> 597:
>>> 598: /** Number of CPUS, to place bounds on some sizings */
>>> 599: static @Stable int NCPU;
>>
>> I would prefer to not mark this `@Stable` at this time as it would have
>> d
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
On Mon, 21 Oct 2024 22:43:42 GMT, Chen Liang wrote:
> Improve the documentation for classfile instructions. Includes links to all
> opcodes, usage notes for instructions, and other various fixes.
Proofread a little bit. Since this is huge and there may be mistakes, I will
only create a CSR aft
Improve the documentation for classfile instructions. Includes links to all
opcodes, usage notes for instructions, and other various fixes.
-
Commit messages:
- Typos, long lines
- Labels
- Wip instr
Changes: https://git.openjdk.org/jdk/pull/21625/files
Webrev: https://webrevs.
On Sat, 19 Oct 2024 11:56:32 GMT, Shaojin Wen wrote:
>> Cache commonly used classDesc to avoid creating ReferenceClassDescImpl every
>> time
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add LFI/NFI
Would it make sense f
> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> This PR implements the AOT-linking of invokedynamic callsites:
> - We only link lambda expressions (`LambdaMetafactory::metafactory`) and
> string concat (`Stri
> Add `isOther` and `available` methods to `FileChannelImpl` and the interfaces
> to native code and use these in `ChannelInputStream` to work around cases
> where a wrapped `FileChannelImpl` is not really seekable.
Brian Burkhalter has updated the pull request incrementally with one additional
On Mon, 21 Oct 2024 07:57:31 GMT, Axel Boldt-Christmas
wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - Fix comments in objectMonitor.hpp
>> - Move frame::saved_thread_address() to platform dependent f
On Mon, 21 Oct 2024 06:38:28 GMT, Axel Boldt-Christmas
wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - Fix comments in objectMonitor.hpp
>> - Move frame::saved_thread_address() to platform dependent f
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
- Removed hard check for "Xcode with command line developer tools" when
`--mac-sign` is specified and instead we will show information message if
`codesign` fails for any reason that possible root cause of failure is missing
Xcode with command line developer tools.
- Reason for this is that `cod
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote:
> and whatever team is responsible for HotSpot debugging.
I don't see anything hotspot related here.
I think you would be better off splitting this up into distinct issues and PRs
for different areas. I expect the client team in particular
On Tue, 22 Oct 2024 01:40:11 GMT, David Holmes wrote:
> > and whatever team is responsible for HotSpot debugging.
>
> I don't see anything hotspot related here.
>
> I think you would be better off splitting this up into distinct issues and
> PRs for different areas. I expect the client team in
On Wed, 16 Oct 2024 23:16:00 GMT, Ashutosh Mehra wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo in last commit; fixed header inclusion order
>
> src/hotspot/share/cds/dumpTimeClassInfo.hpp line 45:
>
>> 43:
On Fri, 18 Oct 2024 05:39:32 GMT, Chen Liang wrote:
>> `Class::reflectionFactory` is a large table that must be cleared, or else we
>> will bring unwanted (unsupported) objects into the cache.
>>
>> During runtime, `reflectionFactory` will be initialized on demand, so
>> there's no need to exp
> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> This PR implements the AOT-linking of invokedynamic callsites:
> - We only link lambda expressions (`LambdaMetafactory::metafactory`) and
> string concat (`Stri
> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> This PR implements the AOT-linking of invokedynamic callsites:
> - We only link lambda expressions (`LambdaMetafactory::metafactory`) and
> string concat (`Stri
On Fri, 18 Oct 2024 13:45:00 GMT, Alexey Semenyuk wrote:
> `Files.walk(root, 0)` returns the `root` itself and not the contents of the
> `root`.
> Replaced `Files.walk(root, 0)` with `Files.list(root)` to get a non-recursive
> listing of the `root` directory.
This pull request has now been int
On Mon, 21 Oct 2024 21:56:11 GMT, Ioi Lam wrote:
>>> I read through it fairly thoroughly. I made a lot of suggestions. Rather
>>> than edit comments into lots of spots in this PR, I made the following
>>> patch file.
>>> [aot-indy-21143-commentary.diff.txt](https://github.com/user-attachments/
On Fri, 18 Oct 2024 13:45:00 GMT, Alexey Semenyuk wrote:
> `Files.walk(root, 0)` returns the `root` itself and not the contents of the
> `root`.
> Replaced `Files.walk(root, 0)` with `Files.list(root)` to get a non-recursive
> listing of the `root` directory.
Marked as reviewed by almatvee (Re
On Fri, 18 Oct 2024 02:19:31 GMT, David Holmes wrote:
> ```
> +bool InstanceKlass::is_enum_subclass(bool direct_only) const {
> + InstanceKlass* s = java_super();
> + return (s == vmClasses::Enum_klass() ||
> + (s != null && s->java_super() == vmClasses::Enum_klass()));
> +}
> ```
>
>
> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> This PR implements the AOT-linking of invokedynamic callsites:
> - We only link lambda expressions (`LambdaMetafactory::metafactory`) and
> string concat (`Stri
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
> This is the 6th PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> The implementation of java.lang.invoke uses SoftReferences so that unused
> MethodHandles, LambdaForms, etc, can be garbage collected.
>
> However, if we want to store j
On Mon, 21 Oct 2024 14:49:34 GMT, Aggelos Biboudis
wrote:
>> After doing a build + bootcycle build confirms that these constants can be
>> removed.
>
> Aggelos Biboudis has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update src/java.base/
On Mon, 21 Oct 2024 07:03:59 GMT, Stefan Karlsson wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added
>> ClaimMetadataVisitingOopIterateClosure::assert_is_pending_aot_linked_class()
>
> src/hotspot/share/memory/itera
> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> This PR implements the AOT-linking of invokedynamic callsites:
> - We only link lambda expressions (`LambdaMetafactory::metafactory`) and
> string concat (`Stri
On Fri, 18 Oct 2024 14:42:39 GMT, Alexey Semenyuk wrote:
>> Make jpackage correctly handle the output directory (`--dest`) that is:
>> - a subdirectory of the input directory;
>> - the same as the input directory.
>>
>> Make jpackage correctly handle temp directory (`--temp`) that is:
>> - a
> This addresses tendencies in previous update to increase fencing, scanning,
> and signalling that can increase contention, and slow down performance
> especially on ARM platforms. It also uses more ARM-friendly constructions to
> reduce overhead (leading to several changes that all of the same
On Mon, 25 Mar 2024 21:37:03 GMT, Liam Miller-Cushon wrote:
> This change fixes a zip64 bug in the launcher that is prevent it from reading
> the manifest of jars where the 'relative offset of local header' field in the
> central directory entry is >4GB. As described in APPNOTE.TXT 4.5.3, the
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
On Mon, 21 Oct 2024 17:49:33 GMT, Naoto Sato wrote:
>> Changing the charset initialization of `java.io.Console` class, which is the
>> basis of `java.io.IO`, so that it would behave the same way as `System.out`
>> wrt encoding. This change will also have the capability to override the
>> defau
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
On Fri, 4 Oct 2024 00:02:52 GMT, Liam Miller-Cushon wrote:
>> This change fixes a bug preventing javac from emitting
>> 'compiler.warn.sun.proprietary' diagnostics if `--system` is set to a
>> non-default value. The diagnostics are currently emitted for values of
>> `--release`, and for the de
On Sat, 19 Oct 2024 07:10:02 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Explicitly refer to `stdout.encoding`
>
> src/java.base/share/classes/java/io/Console.java line 584:
>
>> 582: * Th
> Changing the charset initialization of `java.io.Console` class, which is the
> basis of `java.io.IO`, so that it would behave the same way as `System.out`
> wrt encoding. This change will also have the capability to override the
> default charset used in `IO` methods with `stdout.encoding` sys
On Mon, 14 Oct 2024 20:31:51 GMT, Kevin Bourrillion wrote:
> 8342566: Improve javadoc of java.lang.annotation.ElementType
With an update in this spirit, some mention of
`Constructror.getAnnotatedReceiverType()` would be helpful too.
-
PR Comment: https://git.openjdk.org/jdk/pull/2
On Mon, 14 Oct 2024 20:31:51 GMT, Kevin Bourrillion wrote:
> 8342566: Improve javadoc of java.lang.annotation.ElementType
src/java.base/share/classes/java/lang/annotation/ElementType.java line 118:
> 116: * on the declaration of a record component, and is automatically
> 117: * copied
On Mon, 14 Oct 2024 20:31:51 GMT, Kevin Bourrillion wrote:
> 8342566: Improve javadoc of java.lang.annotation.ElementType
src/java.base/share/classes/java/lang/annotation/ElementType.java line 63:
> 61: * Ambiguous contexts
> 62: *
> 63: * For six kinds of declarations, type-use annotations
On Mon, 21 Oct 2024 17:32:33 GMT, fabioromano1 wrote:
>> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
>> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>>
>> The main steps of the algorithm are as follows:
>> first argument reduce the value to an i
> After changing `BigInteger.sqrt()` algorithm, this can be also used to speed
> up `BigDecimal.sqrt()` implementation. Here is how I made it.
>
> The main steps of the algorithm are as follows:
> first argument reduce the value to an integer using the following relations:
>
> x = y * 10 ^ exp
>
On Wed, 16 Oct 2024 17:46:20 GMT, Naoto Sato wrote:
> Removing the old compatibility behavior switch for JDK1.1. With the
> integration of tzdata2024b, definitions of those three (deprecated) IDs
> changed again, so maintaining the JDK11 compatibility got less useful.
> Removing the compatibil
On Sat, 19 Oct 2024 07:54:07 GMT, Alan Bateman wrote:
> There are a couple of micro benchmarks in test/micro that fork with
> `jvmArgsPrepend={"-Djava.security.manager=allow"})`, they will need to be
> examined.
Fixed, will be in next drop. There are a couple of other micro tests that test
th
On Wed, 16 Oct 2024 19:59:44 GMT, Naoto Sato wrote:
>> Removing the old compatibility behavior switch for JDK1.1. With the
>> integration of tzdata2024b, definitions of those three (deprecated) IDs
>> changed again, so maintaining the JDK11 compatibility got less useful.
>> Removing the compat
On Mon, 21 Oct 2024 13:45:47 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to fix the order of javadoc `@param` tags in
> module java.base.
>
> We are working on a javadoc feature to add an opt-in doclint warning for
> `@param` tags that don't match the order of parameters in
On Mon, 21 Oct 2024 13:45:47 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to fix the order of javadoc `@param` tags in
> module java.base.
>
> We are working on a javadoc feature to add an opt-in doclint warning for
> `@param` tags that don't match the order of parameters in
On Mon, 14 Oct 2024 20:31:51 GMT, Kevin Bourrillion wrote:
> 8342566: Improve javadoc of java.lang.annotation.ElementType
src/java.base/share/classes/java/lang/annotation/ElementType.java line 42:
> 40: * }
> 41: *
> 42: * Declaration annotations and type-use annotations
Meta: if we add an
On Tue, 15 Oct 2024 16:35:19 GMT, Kevin Bourrillion wrote:
> answer ~all "where will I be able to put this annotation?" questions
I think you've done a great job: the notes on type-use annotations are clear.
The only potentially confusing thing left is record component annotations'
propagation
On Tue, 15 Oct 2024 19:54:08 GMT, Chen Liang wrote:
>> Well, this is one of the ambiguous contexts listed above. Not sure if I'm
>> reading this right. What's the "inconsistency" you mean?
>
> Say you have a record component like:
> `record Sample(@Anno int val)`
> Where `@Anno` applies to `RECO
On Tue, 15 Oct 2024 16:22:36 GMT, Kevin Bourrillion wrote:
>> src/java.base/share/classes/java/lang/annotation/ElementType.java line 46:
>>
>>> 44: * Most annotations in Java code are declaration
>>> 45: * annotations, which act like modifiers of declarations (such as
>>> 46: * a field declar
On Mon, 14 Oct 2024 20:31:51 GMT, Kevin Bourrillion wrote:
> 8342566: Improve javadoc of java.lang.annotation.ElementType
Thanks so much Chen! I'm interested in your general thoughts: does it make
sense where I have currently "drawn the line", as far as what information
belongs in here and wha
On Tue, 15 Oct 2024 02:10:30 GMT, Chen Liang wrote:
>> 8342566: Improve javadoc of java.lang.annotation.ElementType
>
> src/java.base/share/classes/java/lang/annotation/ElementType.java line 42:
>
>> 40: * }
>> 41: *
>> 42: * Declaration annotations and type-use annotations
>
> Meta: if we a
8342566: Improve javadoc of java.lang.annotation.ElementType
-
Commit messages:
- Merge branch 'openjdk:master' into element-type-javadoc
- Merge branch 'openjdk:master' into element-type-javadoc
- handle review comments from Chen
- maybe ready for review now
- Merge branch 'open
On Fri, 18 Oct 2024 21:05:18 GMT, Justin Lu wrote:
>> Please review this PR which specifies the _j.text.MessageFormat_
>> ArgumentIndex limit. A corresponding CSR is drafted.
>>
>> Both the existence of the limit (and behavior if violated), as well as this
>> implementation's limit are added t
On Wed, 16 Oct 2024 22:48:58 GMT, Justin Lu wrote:
> Please review this PR which specifies the _j.text.MessageFormat_
> ArgumentIndex limit. A corresponding CSR is drafted.
>
> Both the existence of the limit (and behavior if violated), as well as this
> implementation's limit are added to the
On Mon, 21 Oct 2024 17:00:55 GMT, Jason Mehrens wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed wording according to CSR discussion: ' The reader is initially
>> open and reading starts at the first character
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains seven a
On Mon, 21 Oct 2024 16:47:36 GMT, Raffaello Giulietti
wrote:
> Since there's an invocation of `stripTrailingZeros()` anyway, what's the
> reason to _not_ "optimize" for other round modes as well, like in the current
> implementation?
Because it is not necessary to strip zeros when an exact re
On Mon, 21 Oct 2024 15:44:58 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Mon, 21 Oct 2024 06:21:06 GMT, Jatin Bhateja wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove comments for intrinsics per review feedback.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float
On Wed, 2 Oct 2024 16:43:11 GMT, fabioromano1 wrote:
> > Curiously, this one runs in a fraction of a second on the current
> > implementation, but not on the proposed one:
> > `BigDecimal.valueOf(100).sqrt(new MathContext(1_000_000,
> > RoundingMode.HALF_EVEN)).shortValue()`
>
> @rgiulietti T
On Mon, 21 Oct 2024 15:44:58 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
On Mon, 21 Oct 2024 13:17:10 GMT, Alan Bateman wrote:
>> Hi Alan,
>> I tried your suggestion but it can't handle the `ALL-SYSTEM` case.
>> I made some slight adjustments to your patch as follows:
>>
>>
>> /**
>> * Returns true if all modules named in the given set are in the
>> Config
> Summary of changes:
>
> Before dumping info the archive, all the module names from `--add-modules`
> will be sorted and then concatenated into one string with comma as the
> separator between module names.
>
> During runtime, same function will be used to obtain the string in the same
> form
On Mon, 21 Oct 2024 15:45:21 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
When GH output is too large, we do not actually truncate it after
[JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424). The error log would
be:
Run bash ./.github/scripts/gen-test-results.sh "$GITHUB_STEP_SUMMARY"
./.github/scripts/gen-test-results.sh: line 28: report-utils.sh: No such fi
On Mon, 21 Oct 2024 13:45:47 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to fix the order of javadoc `@param` tags in
> module java.base.
>
> We are working on a javadoc feature to add an opt-in doclint warning for
> `@param` tags that don't match the order of parameters in
https://openjdk.org/jeps/493
Summary: Reduce the size of the JDK by approximately 25% by enabling
the jlink tool to create custom run-time images without using the JDK's
JMOD files. This feature must be enabled when the JDK is built; it
will not be enabled by default, and some JDK vendors
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Mon, 21 Oct 2024 09:41:50 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
On Mon, 21 Oct 2024 06:34:03 GMT, Adam Sotona wrote:
>> Class-File API is leaving preview.
>> This is a removal of all `@PreviewFeature` annotations from Class-File API.
>> It also bumps all `@since` tags and removes
>> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>>
>> Please rev
After 8339120, gcc began catching many different instances of unused code in
the Windows specific codebase. Some of these seem to be bugs. I've taken the
effort to mark out all the relevant globals and locals that trigger the unused
warnings and addressed all of them by commenting out the code a
On Thu, 3 Oct 2024 00:47:23 GMT, Joe Darcy wrote:
> My initial question is what additional regression test cases should be added
> to probe the new code.
@rgiulietti @jddarcy This should be the path tree for the test cases of the
algorithm, whether `signum == 1`:
If `mc.roundingMode == Roundi
On Mon, 21 Oct 2024 08:01:09 GMT, Andrey Turbanov wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Adjust spacing in test JfrEvents.java
>> - Adjust comment in JavaThread.hpp
>> - RISC-V: Avoid retur
On Fri, 18 Oct 2024 04:21:57 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/runtime/javaThread.hpp line 165:
>>
>>> 163: // ID used as owner for inflated monitors. Same as the
>>> j.l.Thread.tid of the
>>> 164: // current _vthread object, except during creation of the primordial
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
> This Pull Requests proposes an implementation for
> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
> method `public static Reader Reader.of(CharSequence)` will return an
> anonymous, non-synchronized implementation of a `Reader` for each kind of
> `CharSequence` im
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 16 Oct 2024 17:40:36 GMT, Lance Andersen wrote:
> Please review the changes for
> [JDK-8340553](https://bugs.openjdk.org/browse/JDK-8340553), which is a
> follow-on to [JDK-8336025](https://bugs.openjdk.org/browse/JDK-8336025) which
> addresses that
>
> - ZipEntry(String)
> - ZipEntry
On Sun, 20 Oct 2024 22:17:38 GMT, Joe Darcy wrote:
> Fix typo and remove redundant `@since` tags.
This pull request has now been integrated.
Changeset: 18b55cea
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/18b55ceaa44baabdfce8dcfa1cd6b3e3bdc9df1a
Stats: 5 lines in 1
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
> After doing a build + bootcycle build confirms that these constants can be
> removed.
Aggelos Biboudis has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java
Co-authored-by
On Mon, 21 Oct 2024 14:49:34 GMT, Aggelos Biboudis
wrote:
>> After doing a build + bootcycle build confirms that these constants can be
>> removed.
>
> Aggelos Biboudis has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update src/java.base/
> Set the default value of DirectCodeBuilder::handlers to Null to reduce
> overhead in scenarios where there is no handler.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
List.of
-
Changes:
- all: https://git.openjdk.
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
This helps in reducing memory consumption, especially for long inputs.
-
Commit messages:
- Adjusted test to make use of byte[].
- 8342693: Use byte[] as parameter in a FDBigInteger constructor and as field
Changes: https://git.openjdk.org/jdk/pull/21614/files
Webrev: https://web
On Mon, 21 Oct 2024 14:25:06 GMT, Raffaello Giulietti
wrote:
> This helps in reducing memory consumption, especially for long inputs.
This is the first PR of a series aimed at reducing overall CPU and memory
consumption in string->floating-point conversions.
-
PR Comment: https:/
On Mon, 21 Oct 2024 14:22:39 GMT, Aggelos Biboudis
wrote:
>> After doing a build + bootcycle build confirms that these constants can be
>> removed.
>
> Aggelos Biboudis has refreshed the contents of this pull request, and
> previous commits have been removed. The incremental views will show
>
On Sun, 20 Oct 2024 23:15:44 GMT, Shaojin Wen wrote:
> Set the default value of DirectCodeBuilder::handlers to Null to reduce
> overhead in scenarios where there is no handler.
src/java.base/share/classes/jdk/internal/classfile/impl/DirectCodeBuilder.java
line 805:
> 803: public List
> g
1 - 100 of 150 matches
Mail list logo
