On Mon, 21 Oct 2024 07:03:59 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added
>> ClaimMetadataVisitingOopIterateClosure::assert_is_pending_aot_linked_class()
>
> src/hotspot/share/memory/iterator.inline.hpp line 57:
>
>> 55: ClaimMetadataVisitingOopIterateClosure::do_cld(cld);
>> 56: } else {
>> 57: assert_is_pending_aot_linked_class(k);
>
> Would there be a drawback to just adding
> `assert(AOTLinkedClassBulkLoader::is_pending_aot_linked_class(k), "sanity");`
> here and skip the changes the both .hpp and .cpp files?
I changed the code to `assert(is_pending_aot_linked_class(k), "sanity")`. Since
iterator.hpp is widely used, I avoid including aotLinkedClassBulkLoader.hpp in
this header, and route the call through iterator.cpp.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21143#discussion_r1809487525
