On Mon, 27 Nov 2023 16:58:29 GMT, Alan Bateman wrote:
> ThreadGroup.stop was deprecated since JDK 1.2, deprecated for removal in Java
> 18, and re-specified/degraded to throw UnsupportedOperationException
> unconditionally in Java 20. Early in Java 23 seems a fine time to finally
> remove this
On Mon, 27 Nov 2023 16:58:29 GMT, Alan Bateman wrote:
> ThreadGroup.stop was deprecated since JDK 1.2, deprecated for removal in Java
> 18, and re-specified/degraded to throw UnsupportedOperationException
> unconditionally in Java 20. Early in Java 23 seems a fine time to finally
> remove this
On Tue, 21 Nov 2023 15:14:28 GMT, Dalibor Topic wrote:
>> src/java.base/linux/native/libsimdsort/avx2-32bit-qsort.hpp line 3:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2021, 2023, Intel Corporation. All rights reserved.
>>> 3: * Copyright (c) 2021 Serge Sans Paille. All rights reserved.
>>
>> Is th
On Wed, 29 Nov 2023 05:48:58 GMT, Vladimir Sitnikov
wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alternative C + Arrays.copyOfRange()
>
> src/java.base/share/classes/java/io/BufferedInputStream.java line 612:
>
On Mon, 31 Oct 2022 13:30:13 GMT, Markus KARG wrote:
>> This PR implements JDK-8294696.
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Alternative C + Arrays.copyOfRange()
src/java.base/share/classes/java/io/BufferedInputS
On Tue, 28 Nov 2023 20:11:42 GMT, Joe Wang wrote:
> Fix errors in the built-in Catalog implementation, specifically:
> -- incorrect case in the property name as defined in the CSR
> (https://bugs.openjdk.org/browse/JDK-8306056)
> -- tests needed to be updated accordingly
> -- jaxp.pr
On Wed, 29 Nov 2023 02:00:14 GMT, Joe Darcy wrote:
> Typo fix to to the new text added in JDK-8295391.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16872#pullrequestreview-1754401831
On Sat, 18 Nov 2023 01:55:00 GMT, Mandy Chung wrote:
>> Perhaps it's sufficient to say simply that, _"the garbage collector will no
>> longer enqueue this object."_
>
> Is this sentence needed? Excluding the race scenario as described in the
> javadoc, it would be equivalent as if the Referen
On Wed, 29 Nov 2023 02:00:14 GMT, Joe Darcy wrote:
> Typo fix to to the new text added in JDK-8295391.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16872#pullrequestreview-1754293335
On Tue, 21 Nov 2023 09:08:06 GMT, Viktor Klang wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
>>
Typo fix to to the new text added in JDK-8295391.
-
Commit messages:
- JDK-8320940: Fix typo in java.lang.Double
Changes: https://git.openjdk.org/jdk/pull/16872/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16872&range=00
Issue: https://bugs.openjdk.org/browse/JDK-832094
On Tue, 28 Nov 2023 02:24:20 GMT, Alexander Matveev
wrote:
> Looks like the test timed out due to slow/loaded host. Failure log similar to
> [JDK-8296489](https://bugs.openjdk.org/browse/JDK-8296489) and
> [JDK-8298735](https://bugs.openjdk.org/browse/JDK-8298735). Fixed by
> increasing test
On Wed, 15 Nov 2023 18:30:27 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 498:
>>
>>> 496: */
>>> 497: @Override
>>> 498: public String toString() {
>>
>> I don't think the file name on its own is very helpful as it may not be
>> unique or t
Re-write the IndexOf code without the use of the pcmpestri instruction, only
using AVX2 instructions. This change accelerates String.IndexOf on average
1.3x for AVX2. The benchmark numbers:
Benchmark Score
Latest
Strin
On Tue, 21 Nov 2023 00:06:19 GMT, Scott Gibbons wrote:
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> Benchmark
On Tue, 28 Nov 2023 02:24:20 GMT, Alexander Matveev
wrote:
> Looks like the test timed out due to slow/loaded host. Failure log similar to
> [JDK-8296489](https://bugs.openjdk.org/browse/JDK-8296489) and
> [JDK-8298735](https://bugs.openjdk.org/browse/JDK-8298735). Fixed by
> increasing test
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For serial sort on random data, this PR shows upto ~7.5x improvement
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> This change is primarily to provide a more informative String representati
On Fri, 24 Nov 2023 13:25:35 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a "jmodless" jlink mode to the JDK.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> install might not come with the packaged modules (directory `jmods`). This
>> is
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote:
> Time to start making preparations for JDK 23.
Build changes look good.
-
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1754115586
On Tue, 28 Nov 2023 21:36:20 GMT, Joe Wang wrote:
>> Fix errors in the built-in Catalog implementation, specifically:
>> -- incorrect case in the property name as defined in the CSR
>> (https://bugs.openjdk.org/browse/JDK-8306056)
>> -- tests needed to be updated accordingly
>> -- ja
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of this enhancement. These notes are organized by feature,
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.
On Tue, 28 Nov 2023 19:31:14 GMT, Brian Burkhalter wrote:
>> Do you have any actual benchmark measurements that you could share?
>
>> @bplb I have not yet made benchmark measurements, but I can produce them.
>
> @fabioromano1 I think it would be good to measure and report the benefit, if
> you
On Tue, 28 Nov 2023 19:31:14 GMT, Brian Burkhalter wrote:
>> Do you have any actual benchmark measurements that you could share?
>
>> @bplb I have not yet made benchmark measurements, but I can produce them.
>
> @fabioromano1 I think it would be good to measure and report the benefit, if
> you
On Tue, 28 Nov 2023 19:57:03 GMT, Severin Gehwolf wrote:
> --verbose should tell you exactly which command line options would need to be
> added to arrive at the same end-result image, but with packaged modules? I.e.
> do some tracking of cli options when jlink runs?
Yes that's the idea. It
On Tue, 28 Nov 2023 21:36:20 GMT, Joe Wang wrote:
>> Fix errors in the built-in Catalog implementation, specifically:
>> -- incorrect case in the property name as defined in the CSR
>> (https://bugs.openjdk.org/browse/JDK-8306056)
>> -- tests needed to be updated accordingly
>> -- ja
> Fix errors in the built-in Catalog implementation, specifically:
> -- incorrect case in the property name as defined in the CSR
> (https://bugs.openjdk.org/browse/JDK-8306056)
> -- tests needed to be updated accordingly
> -- jaxp.properties updated with documentation for the new prop
On Tue, 28 Nov 2023 00:35:48 GMT, Srinivas Vamsi Parasa
wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add @SuppressWarnings (serial)
>
> xmlns:o="urn:schemas-microsoft-com:office:office"
> xmlns:x="urn:schem
On Tue, 28 Nov 2023 08:51:17 GMT, Alan Bateman wrote:
> Update the jtreg test group configuration in the jdk test tree so that the
> jpackage tests run in tier3 rather than tier2.
>
> At this time, the jpackage tests run in jdk:tier2, more specifically
> jdk:tier2_part2 as part of the core_too
On Tue, 28 Nov 2023 12:25:57 GMT, Jatin Bhateja wrote:
>> src/hotspot/share/opto/library_call.cpp line 5448:
>>
>>> 5446: BasicType bt = elem_type->basic_type();
>>> 5447: // Disable the intrinsic for 64-bit types with AVX2
>>> 5448: if ((bt == T_LONG || bt == T_DOUBLE) && UseAVX == 2) {
>
On Tue, 28 Nov 2023 00:08:00 GMT, Srinivas Vamsi Parasa
wrote:
>> src/hotspot/share/opto/library_call.cpp line 5391:
>>
>>> 5389: BasicType bt = elem_type->basic_type();
>>> 5390: // Disable the intrinsic for 64-bit types with AVX2
>>> 5391: if ((bt == T_LONG || bt == T_DOUBLE) && U
On Tue, 28 Nov 2023 20:41:21 GMT, Alan Bateman wrote:
> Doing it early in JDK 23 to allow time for course correction if needed seems
> a good plan.
Another benefit is that if we should decide to validate LOC headers similarly
in `ZipInputStream`, delaying until 23 will allow us to introduce th
> Please review this PR which converts the shell test,
> _java/util/currency/PropertiesTest.sh_ to a normal java test.
>
> This test is a test runner that launches test methods from
> _PropertiesTest.java_. It tests both the ways to supersede the default
> currencies, that is, either using a cu
On Tue, 28 Nov 2023 20:49:38 GMT, Justin Lu wrote:
>> Please review this PR which converts the shell test,
>> _java/util/currency/PropertiesTest.sh_ to a normal java test.
>>
>> This test is a test runner that launches test methods from
>> _PropertiesTest.java_. It tests both the ways to super
On Tue, 28 Nov 2023 12:23:00 GMT, Jatin Bhateja wrote:
>> Srinivas Vamsi Parasa has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 11
>> additional
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX2 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> For serial sort on random data, this PR shows upto ~7.5x improvement
On Tue, 28 Nov 2023 20:27:32 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix typo in the comments
>
> src/java.xml/share/conf/jaxp.properties line 52:
>
>> 50: # For example, the FILES property in
On Tue, 28 Nov 2023 20:34:34 GMT, Markus Grönlund wrote:
> Isn't this a replacement for the existing instrumentation? If these are new
> events I am sorry.
It's a new event.
> What is keeping us from removing ASM in that case?
I think file I/O, there is still instrumentation used for FileInpu
> Fix errors in the built-in Catalog implementation, specifically:
> -- incorrect case in the property name as defined in the CSR
> (https://bugs.openjdk.org/browse/JDK-8306056)
> -- tests needed to be updated accordingly
> -- jaxp.properties updated with documentation for the new prop
On Tue, 28 Nov 2023 19:27:45 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/sun/nio/cs/StreamDecoder.java line 294:
>>
>>> 292: private void lockedFillZeroToPosition() throws IOException {
>>> 293: ensureOpen();
>>> 294: Arrays.fill(bb.array(), 0, bb.arrayOffset() + bb
On Tue, 28 Nov 2023 20:06:25 GMT, Lance Andersen wrote:
> Given where we are in the JDK 22 cycle, going to hold off on finalizing the
> PR until we fork for JDK 23 and look to move this forward early on allowing
> for additional time to bake
Tightening validation always comes with risk. Doing
On Tue, 28 Nov 2023 18:28:37 GMT, Justin Lu wrote:
>> Please review this PR which converts the shell test,
>> _java/util/currency/PropertiesTest.sh_ to a normal java test.
>>
>> This test is a test runner that launches test methods from
>> _PropertiesTest.java_. It tests both the ways to super
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Marked as reviewed by alanb (Reviewe
On Tue, 28 Nov 2023 18:26:37 GMT, Ivan Šipka wrote:
>> @bwhuang-us @mahendrachhipa
>
> Ivan Šipka has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added jdk_core_no_security as additional group defintion, reverting old
> base definition
te
On Tue, 28 Nov 2023 20:30:52 GMT, Alan Bateman wrote:
> > It would be good to integrate this quite soon because it would release the
> > reliance on ASM and let us only use the new ClassFile API. Now, we need to
> > load both implementations, leading to startup regression.
>
> This is a new ev
On Tue, 28 Nov 2023 18:21:33 GMT, Markus Grönlund wrote:
> It would be good to integrate this quite soon because it would release the
> reliance on ASM and let us only use the new ClassFile API. Now, we need to
> load both implementations, leading to startup regression.
This is a new event so
On Tue, 28 Nov 2023 20:11:42 GMT, Joe Wang wrote:
> Fix errors in the built-in Catalog implementation, specifically:
> -- incorrect case in the property name as defined in the CSR
> (https://bugs.openjdk.org/browse/JDK-8306056)
> -- tests needed to be updated accordingly
> -- jaxp.pr
On Mon, 27 Nov 2023 23:44:25 GMT, Sandhya Viswanathan
wrote:
>> Not listed here: https://oca.opensource.oracle.com/?ojr=contributors
>
> Yes, Vamsi is part of Intel Java team. He also has the author status
> (https://openjdk.org/census#sparasa).
> @sviswa7 I am asking about the copyright holde
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Marked as reviewed by joehw (Reviewe
On Tue, 28 Nov 2023 20:11:42 GMT, Joe Wang wrote:
> Fix errors in the built-in Catalog implementation, specifically:
> -- incorrect case in the property name as defined in the CSR
> (https://bugs.openjdk.org/browse/JDK-8306056)
> -- tests needed to be updated accordingly
> -- jaxp.pr
Fix errors in the built-in Catalog implementation, specifically:
-- incorrect case in the property name as defined in the CSR
(https://bugs.openjdk.org/browse/JDK-8306056)
-- tests needed to be updated accordingly
-- jaxp.properties updated with documentation for the new properties
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull re
On Tue, 28 Nov 2023 15:51:37 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 40 commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into 8315458
>> - Requested changes
>> - Rem
On Thu, 16 Nov 2023 20:52:08 GMT, Eirik Bjorsnos wrote:
> > Regarding you comment about checking whether or not to check if the
> > combined length of the CEN header + name length + comment length + extra
> > length > 65K bytes, I chose to add this given the strong wording given this
> > is a
On Tue, 28 Nov 2023 14:43:36 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 40 commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into 8315458
>> - Requested changes
>> - Rem
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull re
On Tue, 28 Nov 2023 19:46:45 GMT, Mandy Chung wrote:
> Ultimately, we want to know the jlink command-line options if it's linked
> with packaged modules. So I think `--verbose` output would serve as a good
> documentation. I'd like to hear other opinions.
Are you saying that for a run-time ima
On Tue, 28 Nov 2023 19:22:44 GMT, Mandy Chung wrote:
> The --verbose option can include the options for the plugins accumulated with
> the run-time image (such as --strip-debug --vendor-bug-url xxx)
I considered how to document the behavior of linking with packaged modules vs
from run-time ima
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Marked as reviewed by lancea (Review
On Tue, 28 Nov 2023 19:30:34 GMT, Naoto Sato wrote:
>> It is best practice to zero out the underlying buffer after use.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> corrected fromIndex
Looks good now.
-
Mark
On Tue, 28 Nov 2023 18:11:25 GMT, Brian Burkhalter wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update BigInteger(int, Random)
>>
>> Update a comment
>
> Do you have any actual benchmark measurements that y
On Mon, 27 Nov 2023 22:58:17 GMT, fabioromano1 wrote:
>> A faster and simpler way to generate random BigIntegers, avoiding eventually
>> trimming of leading zeros in magnitude array.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision
On Tue, 28 Nov 2023 19:23:45 GMT, Brian Burkhalter wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> corrected fromIndex
>
> src/java.base/share/classes/sun/nio/cs/StreamDecoder.java line 294:
>
>> 292: private vo
> It is best practice to zero out the underlying buffer after use.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
corrected fromIndex
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16861/files
- new: https://git.o
On Tue, 28 Nov 2023 19:12:50 GMT, Naoto Sato wrote:
> It is best practice to zero out the underlying buffer after use.
src/java.base/share/classes/sun/nio/cs/StreamDecoder.java line 294:
> 292: private void lockedFillZeroToPosition() throws IOException {
> 293: ensureOpen();
> 294:
On Thu, 23 Nov 2023 18:26:58 GMT, Severin Gehwolf wrote:
> Those are now being filtered (using exclude-resource) prior it being
> processed by the TRANSFORMER or ADDER phases. Furthermore, it prevents those
> classes to populate if plug-ins that generated them aren't used. This also
> removes
On Tue, 28 Nov 2023 08:51:17 GMT, Alan Bateman wrote:
> Update the jtreg test group configuration in the jdk test tree so that the
> jpackage tests run in tier3 rather than tier2.
>
> At this time, the jpackage tests run in jdk:tier2, more specifically
> jdk:tier2_part2 as part of the core_too
It is best practice to zero out the underlying buffer after use.
-
Commit messages:
- copyright year
- fill zero to position
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16861/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16861&range=00
Issue: https://bug
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull re
>
> But keeping this "peculiarity" afloat does not come for free either.
>
Let me add that keeping the constants also incurs a maintenance cost: The
fact that these constants are "effectively and accidentally public" is
unusual, but needs to be understood and enforced by maintainers. Their
names,
On Wed, 15 Nov 2023 20:10:53 GMT, Eirik Bjorsnos wrote:
>> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
>> number of compressed or uncompressed bytes read from the inflater is larger
>> than the Zip64 magic value.
>>
>> While the ZIP format mandates that the data de
On Thu, 23 Nov 2023 09:18:44 GMT, Alan Bateman wrote:
> The deadlock prone Thread/ThreadGroup suspend/resume were deprecated since
> JDK 1.2, deprecated for removal in Java 14, and re-specified/degraded to
> throw UnsupportedOperationException unconditionally in Java 19/20. Early in
> Java 23
On Mon, 27 Nov 2023 08:03:04 GMT, Alan Bateman wrote:
> > > I use the jdk_core test group. I know the split doesn't impact users of
> > > this test group but it's not clear why the change is being done. Would it
> > > be possible to explain why you are doing this? There is nothing in the
> > >
> Please review this PR which converts the shell test,
> _java/util/currency/PropertiesTest.sh_ to a normal java test.
>
> This test is a test runner that launches test methods from
> _PropertiesTest.java_. It tests both the ways to supersede the default
> currencies, that is, either using a cu
> @bwhuang-us @mahendrachhipa
Ivan Šipka has updated the pull request incrementally with one additional
commit since the last revision:
added jdk_core_no_security as additional group defintion, reverting old base
definition
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16
On Tue, Nov 28, 2023 at 6:16 PM Alan Bateman
wrote:
> > In light of this, I would like to revisit this issue, 22 years later:
> [...]
>
> This is a JDK 1.1 era mistake. It would a source incompatible change to
> "remove" the constants. It would require corpus searches to gauge the
> impact. I t
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote:
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.
On Mon, 27 Nov 2023 22:58:17 GMT, fabioromano1 wrote:
>> A faster and simpler way to generate random BigIntegers, avoiding eventually
>> trimming of leading zeros in magnitude array.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision
On Tue, 28 Nov 2023 11:46:10 GMT, fabioromano1 wrote:
>> Indeed it looks as if that is correct.
>
> As specified in
> https://docs.oracle.com/javase/specs/jls/se21/html/jls-15.html#jls-15.19:
> "If the promoted type of the left-hand operand is int, then only the five
> lowest-order bits of the
I agree, I am not sure there is a large benefit to changing this at this time.
Seems a lot of effort for minimal gain at best.
On Nov 28, 2023, at 12:15 PM, Alan Bateman
mailto:alan.bate...@oracle.com>> wrote:
On 28/11/2023 15:50, Eirik Bjørsnøs wrote:
:
In light of this, I would like to revi
On Tue, 28 Nov 2023 08:51:17 GMT, Alan Bateman wrote:
> Update the jtreg test group configuration in the jdk test tree so that the
> jpackage tests run in tier3 rather than tier2.
>
> At this time, the jpackage tests run in jdk:tier2, more specifically
> jdk:tier2_part2 as part of the core_too
On Mon, 27 Nov 2023 19:32:04 GMT, Justin Lu wrote:
> Please review this PR which fixes timeouts for the two tests:
> _java/util/Locale/LocaleProvidersRun.java_ and
> _java/util/ResourceBundle/modules/visibility/VisibilityTest.java_.
>
> These tests were updated to accept VM flags in
> [JDK-83
On 28/11/2023 15:50, Eirik Bjørsnøs wrote:
:
In light of this, I would like to revisit this issue, 22 years later:
- Is my assessment that this change is actually not binary
incompatible sound, or did I miss something?
- Would it in any case make sense to mark ZipConstants as @Deprecated,
may
On Tue, 21 Nov 2023 17:57:32 GMT, Kevin Walls wrote:
> RMI Connections (in general) should use a timeout on the Socket connect call
> by default.
>
> JMX connections use RMI and some connection failures never terminate. The
> hang described in 8316649 is hard to reproduce manually: the descri
Over the year, even though we have tried to be diligent, there have been
commits that modify files without updating the copyright year. Here is a mass
update of the copyright years in the build system (`make/**`, `.github/**`).
Feel free to verify that these files have indeed been modified in 2
On Tue, Nov 28, 2023 at 10:38 AM Eirik Bjørsnøs wrote:
>
>
> On Tue, Nov 28, 2023 at 5:28 PM David Lloyd
> wrote:
>
>> I agree, I always thought that this was a bizarre thing to expose in a
>> public API so it being accidental does explain things. But maybe the
>> appropriate fix is even simpler
On Tue, Nov 28, 2023 at 5:28 PM David Lloyd wrote:
> I agree, I always thought that this was a bizarre thing to expose in a
> public API so it being accidental does explain things. But maybe the
> appropriate fix is even simpler now in these modern times: one could remove
> the `implements` and a
On Tue, Nov 28, 2023 at 10:01 AM Eirik Bjørsnøs wrote:
> Hi,
>
> JDK-4512189 [1] raised the issue that ZipFile, ZipEntry, ZipInputStream
> and ZipOutputStream all implement the non-public ZipConstants interface.
> While the interface itself is non-public, the constants defined
> unfortunately lea
On Fri, 24 Nov 2023 18:30:17 GMT, Erik Österlund wrote:
>> The current logic for closing memory in panama today is susceptible to live
>> lock if we have a closing thread that wants to close the memory in a loop
>> that keeps failing, and a bunch of accessing threads that want to perform
>> ac
On Mon, 27 Nov 2023 16:58:29 GMT, Alan Bateman wrote:
> ThreadGroup.stop was deprecated since JDK 1.2, deprecated for removal in Java
> 18, and re-specified/degraded to throw UnsupportedOperationException
> unconditionally in Java 20. Early in Java 23 seems a fine time to finally
> remove this
Hi,
JDK-4512189 [1] raised the issue that ZipFile, ZipEntry, ZipInputStream and
ZipOutputStream all implement the non-public ZipConstants interface. While
the interface itself is non-public, the constants defined unfortunately
leak into the public API as constants of the mentioned classes. This me
On Tue, 28 Nov 2023 13:52:53 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - S
On Mon, 27 Nov 2023 23:46:00 GMT, Joe Darcy wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Requested changes
>
> test/langtools/tools/javac/ImplicitClass/TestImplicitClass.java line 35:
>
>> 33: import java.lang.re
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull re
On Mon, 27 Nov 2023 16:58:29 GMT, Alan Bateman wrote:
> It would be nice if we could remove Thread.stop at the same time. Sadly there
> are still quite a few artifacts containing code (and in some cases tests)
> that reference this method. We will have to come back to this in some future
> rel
On Mon, 27 Nov 2023 19:09:40 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that migh
On Tue, 28 Nov 2023 13:52:53 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - S
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull re
On Tue, 28 Nov 2023 14:15:48 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 40 commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into 8315458
>> - Requested changes
>> - Rem
1 - 100 of 121 matches
Mail list logo
