On Tue, 28 Nov 2023 19:12:50 GMT, Naoto Sato <na...@openjdk.org> wrote:
> It is best practice to zero out the underlying buffer after use. src/java.base/share/classes/sun/nio/cs/StreamDecoder.java line 294: > 292: private void lockedFillZeroToPosition() throws IOException { > 293: ensureOpen(); > 294: Arrays.fill(bb.array(), 0, bb.arrayOffset() + bb.position(), > (byte)0); Should the `from` parameter be zero or `bb.arrayOffset()`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16861#discussion_r1408281785