On Tue, Nov 28, 2023 at 5:28 PM David Lloyd <david.ll...@redhat.com> wrote:

> I agree, I always thought that this was a bizarre thing to expose in a
> public API so it being accidental does explain things. But maybe the
> appropriate fix is even simpler now in these modern times: one could remove
> the `implements` and add a `static import` of `ZipConstants.*`, which at
> approximately one or two lines is a much more minimal (and
> conflict-resistant, for those who care about backporting subsequent fixes
> of this class) change IMO.
>

Thanks David!

Not entirely sure I understand what you suggest this as an alternative to.
Removing "implements" and replacing that with static imports is surely
where I would eventually see this going. But before we get there, I think
we need to discuss the compatibility impact of such a change, and how to go
about it with regards to the deprecation process etc.

Eirik.

Reply via email to