On Mon, 27 Nov 2023 08:03:04 GMT, Alan Bateman <al...@openjdk.org> wrote:
> > > I use the jdk_core test group. I know the split doesn't impact users of > > > this test group but it's not clear why the change is being done. Would it > > > be possible to explain why you are doing this? There is nothing in the > > > JBS issue or PR to explain. > > > > > > explained in private communication: refactoring of internally used files to > > enable ergonomic result analysis for internal processes > > My concern with changes like this is that it's just adding to the complexity > of the definitions of important test groups. I think we need a new > section/heading at the end of the file as the place to put these special test > runs (esp. the manual tests). For jdk_core_no_security then my strong > preference is not to hack the existing test group configurations, instead add > this to the special runs section at the end: > > ``` > jdk_core_no_security = \ > :jdk_core \ > -:jdk_security > ``` Code updated as per your suggestion, thank you. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16796#issuecomment-1830446899
