On Fri, 3 Nov 2023 08:21:15 GMT, Adam Sotona wrote:
>> Javap ignores --system option when searching for JDK classes.
>> This patch prepends search over JDK system modules.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional
This PR proposes to use unnamed variables now that they have become available
in Java.
There is also a cosmetic cleanup making a switch rake smaller and where
variables are pre-calculated rather than spreading expressions around.
-
Commit messages:
- Use unnamed variables
Changes
> I submitted PR #1 before, and there were too many changes. I split it
> into multiple PRs with small changes. This one is one of them.
>
> this PR removed the duplicate code for getChars in
> BigDecimal#StringBuilderHelper, i also make performance faster.
> Please review and don't hesitate
On Sun, 8 Oct 2023 17:01:37 GMT, Joe Darcy wrote:
>> @liach , thank you for working on this fix. I've given the changes an
>> initial skim, but will need to do a more thorough review before approving or
>> offering suggestions for changes. My top priority for the next few weeks
>> will be JDK
> I submitted PR #1 before, and there were too many changes. I split it
> into multiple PRs with small changes. This one is one of them.
>
> this PR removed the duplicate code for getChars in
> BigDecimal#StringBuilderHelper, i also make performance faster.
> Please review and don't hesitate
On Fri, 3 Nov 2023 19:14:18 GMT, Raffaello Giulietti
wrote:
>> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by
>> improving guarantees of internal invariants.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the las
On Fri, 10 Nov 2023 03:33:51 GMT, Sandhya Viswanathan
wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1648:
>>
>>> 1646: vpermd(xtmp3, xtmp1, xtmp3, vlen_enc == Assembler::AVX_512bit ?
>>> vlen_enc : Assembler::AVX_256bit);
>>> 1647: vpsubd(xtmp1, xtmp1, xtmp2, vlen_enc);
On Fri, 10 Nov 2023 01:49:17 GMT, Leonid Mesnik wrote:
>> Test thread factory is a mode similar to VM flags and should not be used in
>> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
>> createTestJavaProcessBuilder() should use it like jtreg VM options.
>>
>> Adding the test thread
On Fri, 10 Nov 2023 01:49:17 GMT, Leonid Mesnik wrote:
>> Test thread factory is a mode similar to VM flags and should not be used in
>> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
>> createTestJavaProcessBuilder() should use it like jtreg VM options.
>>
>> Adding the test thread
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that might
On Fri, 10 Nov 2023 01:25:49 GMT, Sandhya Viswanathan
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolutions.
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1648:
>
>> 1646: vper
> j.u.Formatter now prints "%tF" (iso standard date) and the result is
> incorrect when processing year < 0 or year >
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
fix format 'ja-JP-u-ca-japanese' ChronoLocalDate
-
> j.u.Formatter now prints "%tF" (iso standard date) and the result is
> incorrect when processing year < 0 or year >
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
fix format 'ja-JP-u-ca-japanese' ChronoLocalDate
-
On Fri, 10 Nov 2023 01:49:17 GMT, Leonid Mesnik wrote:
>> Test thread factory is a mode similar to VM flags and should not be used in
>> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
>> createTestJavaProcessBuilder() should use it like jtreg VM options.
>>
>> Adding the test thread
> Test thread factory is a mode similar to VM flags and should not be used in
> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
> createTestJavaProcessBuilder() should use it like jtreg VM options.
>
> Adding the test thread factory requires the injection of arguments in the
> middle o
On Thu, 9 Nov 2023 18:56:19 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch optimizes sub-word gather operation for x86 targets with AVX2 and
>> AVX512 features.
>>
>> Following is the summary of changes:-
>>
>> 1) Intrinsify sub-word gather with high performance backend implementation
On Thu, 9 Nov 2023 17:44:44 GMT, Naoto Sato wrote:
> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
> null.
test/jdk/java/time/test/java/time/format/TestDateTimeParsing.java line 260:
> 258:
On Wed, 8 Nov 2023 23:23:48 GMT, Steve Dohrmann wrote:
> Below is baseline data collected using a modified version of the
> java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug
> report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake
> i7-1185G7, which doe
Below is baseline data collected using a modified version of the
java.lang.foreign.xor micro benchmark referenced by @mcimadamore in the bug
report. I collected data on an Ubuntu 22.04 laptop with a Tigerlake i7-1185G7,
which does support AVX512.
Baseline data
Benchmark (arrayKind) (siz
On Thu, 9 Nov 2023 21:58:12 GMT, Justin Lu wrote:
> Please review this PR which makes an `ArrayIndexOutOfBoundsException`
> apparent in ChoiceFormat::format.
>
> An _incomplete_ ChoiceFormat can be created, which is not revealed until
> format is invoked.
Marked as reviewed by naoto (Reviewer
Hi Sebastian,
Regarding the lack of "synchronized" wrappers for Sequenced Collections: the main
issue is that they provide only a limited sense of "thread safety" and as such don't
add much actual value. Specifically, the synchronized wrappers hold a lock only
around invocations of individual
On Thu, 9 Nov 2023 17:44:44 GMT, Naoto Sato wrote:
> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
> null.
LGTM
-
Marked as reviewed by jlu (Committer).
PR Review: https://git
Test jdk/incubator/vector/LoadJsvmlTest.java ignores VM flags and thus marked
as flagless through @requires vm.flagless per
[JDK-8319566](https://bugs.openjdk.org/browse/JDK-8319566).
-
Commit messages:
- Mark LoadJsvmlTest.java test as flagless
Changes: https://git.openjdk.org/jd
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that might
Please review this PR which makes an `ArrayIndexOutOfBoundsException` apparent
in ChoiceFormat::format.
An _incomplete_ ChoiceFormat can be created, which is not revealed until format
is invoked.
-
Commit messages:
- init
Changes: https://git.openjdk.org/jdk/pull/16587/files
Web
On Thu, 9 Nov 2023 14:41:10 GMT, Alan Bateman wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java.ba
On Thu, 9 Nov 2023 12:37:30 GMT, Per Minborg wrote:
>> Which parameters? The type parameters or the method parameters?
>
> Here is an example:
>
>
> static Collector of(Supplier supplier,
> BiConsumer accumulator,
>
On Thu, 9 Nov 2023 08:01:28 GMT, Per Minborg wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java.bas
On Thu, 9 Nov 2023 14:21:55 GMT, Alan Bateman wrote:
>> You mean "Returns a Gatherer which gathers elements into ..." ?
>
> Is "window" defined anywhere? If you are doing another pass over the docs
> then the windowXXX methods could be expanded a bit to explain this grouping
> concept. Also it
On Wed, 8 Nov 2023 17:36:42 GMT, Rémi Forax wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java.base
On Thu, 9 Nov 2023 07:57:27 GMT, Per Minborg wrote:
>> src/java.base/share/classes/java/util/stream/Gatherer.java line 216:
>>
>>> 214:
>>> 215: /**
>>> 216: * A function which accepts two intermediate states and combines
>>> them into
>>
>> We could use a {@return ..} here. There mi
On Thu, 9 Nov 2023 14:26:40 GMT, Alan Bateman wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java.ba
On Mon, 30 Oct 2023 17:26:53 GMT, Yakov Shafranovich wrote:
> The various Zip/Jar-file related Java APIs have some long-standing
> differences or peculiarities with respect to the ZIP-file specification or
> compared to other implementations which should be documented in the API-doc.
> This do
On Thu, 9 Nov 2023 17:44:44 GMT, Naoto Sato wrote:
> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
> null.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openj
> Hi All,
>
> This patch optimizes sub-word gather operation for x86 targets with AVX2 and
> AVX512 features.
>
> Following is the summary of changes:-
>
> 1) Intrinsify sub-word gather with high performance backend implementation
> based on hybrid algorithm which initially partially unrolls s
On Thu, 9 Nov 2023 17:44:44 GMT, Naoto Sato wrote:
> Fixing the `Format::parseObject(String, ParsePosition)` implementation in
> `DateTimeFormatter` class, to not throw `DateTimeException` but to return
> null.
Looks good.
-
Marked as reviewed by rriggs (Reviewer).
PR Review: ht
On Fri, 27 Oct 2023 13:26:33 GMT, Vladimir Yaroslavskiy
wrote:
>>> Hi Paul (@PaulSandoz), Alan (@AlanBateman), Any update? Do you agree with
>>> Radix sort in parallel case only?
>>
>> I think its definitely a better fit, but another aspect of my previous
>> comment was wondering if we need a
On Wed, 8 Nov 2023 21:58:47 GMT, Eamonn McManus wrote:
> This change simply replaces "period" with "duration", or in one case replaces
> "period unit" with just "unit".
The changes look ok.
A CSR will be needed so the TCK can be advised and stay in sync.
-
PR Review: https://git
On Thu, 9 Nov 2023 15:34:38 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/foreign/Linker.java line 792:
>>
>>> 790: * @param allowHeapAccess whether the linked function should
>>> allow access to the Java heap.
>>> 791: */
>>> 792: static Option crit
On Fri, 27 Oct 2023 13:26:33 GMT, Vladimir Yaroslavskiy
wrote:
>>> Hi Paul (@PaulSandoz), Alan (@AlanBateman), Any update? Do you agree with
>>> Radix sort in parallel case only?
>>
>> I think its definitely a better fit, but another aspect of my previous
>> comment was wondering if we need a
On Sun, 24 Sep 2023 13:17:05 GMT, Chen Liang wrote:
> 1. Primitive array VHs are now singletons and no longer need to record their
> array base and offset in their object themselves.
> 2. Moved Unsafe offset calculation to a utility method, like `index` in
> VarHandleByteArrayView.
Build chang
Fixing the `Format::parseObject(String, ParsePosition)` implementation in
`DateTimeFormatter` class, to not throw `DateTimeException` but to return null.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16586/files
Webrev: https://webrevs.openjdk.org/?
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote:
> 1. Adding required compiler flags.
> 2. Adding required symbols.
>
> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
> Problem: There is syslookup file which expects the required symbols to be
> exported using the
On Wed, 8 Nov 2023 00:52:36 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 8 Nov 2023 20:26:32 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which enhances the existing CEN header validation
>> checking to ensure that the
>> size of the CEN Header + name length + comment length + extra length do not
>> exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10
On Wed, 8 Nov 2023 19:59:34 GMT, Lance Andersen wrote:
> Please review this PR which enhances the existing CEN header validation
> checking to ensure that the
> size of the CEN Header + name length + comment length + extra length do not
> exceed 65,535 bytes per the PKWare APP.NOTE 4.4.10, 4.
On Wed, 8 Nov 2023 00:52:36 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo.
When running without security manager, the test references 'badfactoty.jar'
instead of 'badfactory.jar'. This change addresses this by correcting the jar
name.
-
Commit messages:
- 8319668: Fixup of jar
On Wed, 8 Nov 2023 21:04:49 GMT, Roger Riggs wrote:
> Tests that directly use ProcessBuilder to spawn processes and do not pass the
> standard test command line arguments should be marked as `vm.flagless` to
> indicate to the testing infrastructure that they do not accept them and
> should not
On Tue, 31 Oct 2023 21:06:13 GMT, Naoto Sato wrote:
> Upgrading CLDR to v44 (https://cldr.unicode.org/index/downloads/cldr-44).
> Besides the data upgrade, regression tests are modified to accommodate the
> following CLDR fixes:
>
> CLDR-16534: Suggestion to rename the Islamic Calendar to Hijr
On Wed, 1 Nov 2023 17:40:09 GMT, Naoto Sato wrote:
> Updating the ICU4J components to v74.1 (https://icu.unicode.org/download/74).
> This change completes the Unicode 15.1 upgrade. The change is merely
> replacing binary data files used for the Normalization and BiDi support
Marked as reviewed
> Add the ability to pass heap segments to native code. This requires using
> `Linker.Option.critical(true)` as a linker option. It has the same
> limitations as normal critical calls, namely: upcalls into Java are not
> allowed, and the native function should return relatively quickly. Heap
>
On Tue, 7 Nov 2023 12:29:54 GMT, Jim Laskey wrote:
>> Update String Templates for a second preview. With the addition of
>>
>> - Expression type and throws are determined from the `process` method of the
>> processor type and not the processor type.
>>
>> - Qualified `STR` and `RAW` are treate
On Thu, 9 Nov 2023 00:27:46 GMT, Vladimir Ivanov wrote:
> Even though it's straightforward to support on-heap accesses during critical
> function calls, object pinning would support that for non-critical function
> calls as well, but proposed API doesn't cover it and new API will be
> required
On Wed, 8 Nov 2023 00:52:36 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 8 Nov 2023 19:52:00 GMT, Vladimir Ivanov wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - a -> an
>> - add note to downcallHandle about passing heap segments by-reference
>
> src/hotspot/cpu/aarch64/downca
On Mon, 6 Nov 2023 07:41:46 GMT, Per Minborg wrote:
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling
On Thu, 9 Nov 2023 09:07:31 GMT, Chen Liang wrote:
> Just curious, how does benchmark
> StringConstructor.newStringFromCharsMixedBegin change before and after this
> patch? If we can see how much of an impact this has on CJK strings it would
> be appreciated.
You may have better insights from
On Thu, 9 Nov 2023 14:21:57 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as spell
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Thu, 9 Nov 2023 09:42:41 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/stream/Gatherers.java line 326:
>>
>>> 324:
>>> 325: /**
>>> 326: * Gathers elements into fixed-size windows. The last window may
>>> contain
>>
>> Returns a ...
>
> You mean "Returns a Gath
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote:
> 1. Adding required compiler flags.
> 2. Adding required symbols.
>
> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
For some context: `java.lang.foreign.Linker.nativeLinker().defaultLookup()`
returns a `SymbolLoo
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling and capitalization).
>
> I am aware this PR will (if
On Thu, 9 Nov 2023 13:07:24 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as spell
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling and capitalization).
>
> I am aware this PR will (if
On Thu, 9 Nov 2023 12:31:16 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as spell
On Thu, 9 Nov 2023 12:31:16 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as spell
On Thu, 9 Nov 2023 09:39:16 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/stream/Gatherer.java line 535:
>>
>>> 533: */
>>> 534: @ForceInline
>>> 535: static Integrator of(Integrator
>>> integrator) {
>>
>> While this idiom is very convenient, ther
On Thu, 9 Nov 2023 09:33:54 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/stream/Gatherer.java line 261:
>>
>>> 259: /**
>>> 260: * Returns an initializer which is the default initializer of a
>>> Gatherer.
>>> 261: * The returned initializer identifies that th
On Thu, 9 Nov 2023 11:46:55 GMT, Daniel Fuchs wrote:
>> Yeah, I agree with @amaembo, I think it is important to keep the contract
>> close to the caller.
>
> I don't mind either way - just wanted to note that the notion of blanket
> statements for `NullPointerException` is used in several areas
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling and capitalization).
>
> I am aware this PR will (if
On Wed, 8 Nov 2023 09:03:12 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as spell
On Wed, 8 Nov 2023 16:51:48 GMT, Lothar Kimmeringer wrote:
> return (year & 3) == 0 && (year & 15 == 0 || year % 100 != 0);
I tried this and many other variants but the one in this PR came out on top -
and it even seemed the additional redundancy helped the JIT. This might be due
a deficiency
On Thu, 9 Nov 2023 09:34:26 GMT, Viktor Klang wrote:
>> I think it's still better to specify this for every method. Many developers
>> read the documentation only for the specific method they are going to call,
>> using IDE features like quick documentation.
>
> Yeah, I agree with @amaembo, I t
On Wed, 1 Nov 2023 17:40:09 GMT, Naoto Sato wrote:
> Updating the ICU4J components to v74.1 (https://icu.unicode.org/download/74).
> This change completes the Unicode 15.1 upgrade. The change is merely
> replacing binary data files used for the Normalization and BiDi support
Marked as reviewed
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
On Mon, 30 Oct 2023 15:50:49 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which speeds up TestTooManyEntries and clarifies its
>> purpose:
>>
>> - The name 'TestTooManyEntries' does not clearly convey the purpose of the
>> test. What is tested is the validation that the total CEN size f
On Thu, 9 Nov 2023 05:01:35 GMT, David Holmes wrote:
> I remain concerned that this means that a whole swag of tests will never be
> run with virtual threads, which reduces our virtual thread test coverage.
> Hard to quantify. Do you have any stats on how many tests this will affect
> and whic
On Thu, 9 Nov 2023 09:40:34 GMT, Tagir F. Valeev wrote:
>> src/java.base/share/classes/java/util/stream/Gatherers.java line 426:
>>
>>> 424: * transformation for scenarios where no combiner-function can be
>>> 425: * implemented, or for reductions which are intrinsically
>>> 426:
On Wed, 8 Nov 2023 17:11:39 GMT, Rémi Forax wrote:
>> The API should be client-friendly, not implementor-friendly, given that it's
>> expected to have much more clients than implementors. An implementor can
>> easily delegate to a private method to add missing type parameters. I did
>> exactly
On Thu, 9 Nov 2023 09:39:33 GMT, Tagir F. Valeev wrote:
>> Ah, now I see what you mean. In this specific case you might be able to
>> create a combiner (which would also need a Downstream) such that you can add
>> the missing combinations (the end of the "left" and the beginning of the
>> "rig
On Thu, 9 Nov 2023 08:15:02 GMT, Per Minborg wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java.bas
On Thu, 9 Nov 2023 08:18:33 GMT, Per Minborg wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java.bas
On Wed, 8 Nov 2023 21:03:59 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/stream/Gatherer.java line 272:
>>
>>> 270: * Returns a combiner which is the default combiner of a Gatherer.
>>> 271: * The returned combiner identifies that the owning Gatherer must
>>> only
On Thu, 9 Nov 2023 08:28:37 GMT, Per Minborg wrote:
>> src/java.base/share/classes/java/util/stream/Gatherer.java line 509:
>>
>>> 507: @PreviewFeature(feature = PreviewFeature.Feature.STREAM_GATHERERS)
>>> 508: interface Integrator {
>>> 509: /** Integrate is the method which gi
On Wed, 8 Nov 2023 16:37:29 GMT, Viktor Klang wrote:
>> Sorry, I'm not sure what do you mean by incrementally. But I've realized
>> that to implement this you may need to push to downstream during combining.
>> E.g., imagine the stream of numbers 1...1000, and you want to make
>> `parallel().g
On Sun, 5 Nov 2023 17:40:29 GMT, Tagir F. Valeev wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java
On Thu, 9 Nov 2023 09:31:50 GMT, Tagir F. Valeev wrote:
>> src/java.base/share/classes/java/util/stream/Gatherer.java line 306:
>>
>>> 304: * @param the type of input elements for the new gatherer
>>> 305: * @param the type of results for the new gatherer
>>> 306: * @throws Null
On Mon, 6 Nov 2023 15:30:46 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/lang/StringUTF16.java line 202:
>>
>>> 200: @ForceInline
>>> 201: public static byte[] compress(final char[] val, final int off,
>>> final int count) {
>>> 202: byte[] latin1 = new byte[count
On Thu, 9 Nov 2023 04:16:25 GMT, Roger Riggs wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that might
On Tue, 31 Oct 2023 07:19:53 GMT, Leo Korinth wrote:
> Updates to javadoc after improvement ideas in the review of 8315097. I have
> also removed the incomplete invocation command line. I also removed
> incomplete information in `executeTestJvm` and added a link to
> `createLimitedTestJavaProc
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR goe
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Thu, 9 Nov 2023 07:48:04 GMT, Per Minborg wrote:
> Sharing code might sometimes have performance issues because the shared code
> is used differently from different call sites. See
> https://bugs.openjdk.org/browse/JDK-8015417. Is this something we should
> check here?
This patch mainly
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Thu, 9 Nov 2023 08:27:26 GMT, Per Minborg wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java.bas
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
1 - 100 of 104 matches
Mail list logo
