On Wed, 8 Nov 2023 17:36:42 GMT, Rémi Forax <fo...@openjdk.org> wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the rhs Gatherer state type
>
> src/java.base/share/classes/java/util/stream/GathererOp.java line 99:
>
>> 97:
>> 98: public NodeBuilder<X> join(NodeBuilder<X> that) {
>> 99: if (isEmpty())
>
> Please add curly braces around if and if/else
That's not the code style in most of the reference implementation of Stream, so
I tried to keep it as harmonized with the rest as possible when not warranted
by performance.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16420#discussion_r1388590401
